From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: Jonathan Corbet <corbet@lwn.net>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Russell King <linux@armlinux.org.uk>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Kukjin Kim <kgene@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Tomasz Figa <tomasz.figa@gmail.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Guenter Roeck <linux@roeck-us.net>, Rob Herring <robh@kernel.org>,
Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Huang Shijie <sjhuang@iluvatar.ai>,
Akshu Agrawal <Akshu.Agrawal@amd.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Daniel Kurtz <djkurtz@chromium.org>,
mazziesaccount@gmail.com
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
matti.vaittinen@fi.rohmeurope.com
Subject: [PATCH v2 0/8] clk: clkdev: managed clk lookup and provider registrations
Date: Thu, 1 Nov 2018 09:17:25 +0200 [thread overview]
Message-ID: <cover.1541054985.git.matti.vaittinen@fi.rohmeurope.com> (raw)
Patch series adding managed clkdev and of_provider registrations
Few clk drivers appear to be leaking clkdev lookup registrations at
driver remove. The patch series adds devm versions of lookup
registrations and cleans up few drivers. Driver clean-up patches have
not been tested as I lack the HW. All testing and comments if
driver/device removal is even possible for changed drivers is highly
appreciated. If removal is not possible I will gladly drop the patches
from series - although leaking lookups may serve as bad example for new
developers =)
Changed drivers are:
clk-max77686, clk-s3c2410-dclk, clk-st, clk-hi655x, rk808, clk-twl6040
and apcs-msm8916.
New devm registration variants have been tested on BeagleBoneBlack
using ROHM BD71837 PMIC driver.
Same devm variants were earlier proposed together with BD71837/BD71847
PMIC clk driver in this series:
https://lore.kernel.org/linux-clk/cover.1535630942.git.matti.vaittinen@fi.rohmeurope.com/
The BD71837/BD71847 work is currently pending for related MFD commits to
get merged in clk-tree and the devm functions are now submitted in this
series.
Changelog v2
Issue spotted by 0-Day test suite
- Add a stub function 'devm_of_clk_add_parent_hw_provider' for no OF config.
- patches 2-8 are unchanged.
This patch series is based on clk-next
---
Matti Vaittinen (8):
clk: clkdev/of_clk - add managed lookup and provider registrations
clk: clk-max77686: Clean clkdev lookup leak and use devm
clk: clk-s3c2410-dclk: clean up clkdev lookup leak
clk: clk-st: avoid clkdev lookup leak at remove
clk: clk-hi655x: Free of_provider at remove
clk: rk808: use managed version of of_provider registration
clk: clk-twl6040: Free of_provider at remove
clk: apcs-msm8916: simplify probe cleanup by using devm
Documentation/driver-model/devres.txt | 3 +
drivers/clk/clk-hi655x.c | 4 +-
drivers/clk/clk-max77686.c | 25 ++-----
drivers/clk/clk-rk808.c | 15 +---
drivers/clk/clk-twl6040.c | 5 +-
drivers/clk/clk.c | 28 ++++++--
drivers/clk/clkdev.c | 122 ++++++++++++++++++++++++++-------
drivers/clk/qcom/apcs-msm8916.c | 5 +-
drivers/clk/samsung/clk-s3c2410-dclk.c | 15 ++--
drivers/clk/x86/clk-st.c | 3 +-
include/linux/clk-provider.h | 11 +++
include/linux/clkdev.h | 4 ++
12 files changed, 158 insertions(+), 82 deletions(-)
--
2.14.3
--
Matti Vaittinen
ROHM Semiconductors
~~~ "I don't think so," said Rene Descartes. Just then, he vanished ~~~
next reply other threads:[~2018-11-01 7:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 7:17 Matti Vaittinen [this message]
2018-11-01 7:18 ` [PATCH v2 1/8] clk: clkdev/of_clk - add managed lookup and provider registrations Matti Vaittinen
2018-11-01 7:18 ` [PATCH v2 2/8] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-11-02 8:15 ` Krzysztof Kozlowski
2018-11-02 11:04 ` Matti Vaittinen
2018-11-01 7:19 ` [PATCH v2 3/8] clk: clk-s3c2410-dclk: clean up clkdev lookup leak Matti Vaittinen
2018-11-02 8:19 ` Krzysztof Kozlowski
2018-11-02 9:18 ` Matti Vaittinen
2018-11-01 7:19 ` [PATCH v2 4/8] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-11-01 7:20 ` [PATCH v2 5/8] clk: clk-hi655x: Free of_provider " Matti Vaittinen
2018-11-01 7:20 ` [PATCH v2 6/8] clk: rk808: use managed version of of_provider registration Matti Vaittinen
2018-11-01 7:21 ` [PATCH v2 7/8] clk: clk-twl6040: Free of_provider at remove Matti Vaittinen
2018-11-01 7:21 ` [PATCH v2 8/8] clk: apcs-msm8916: simplify probe cleanup by using devm Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1541054985.git.matti.vaittinen@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=Akshu.Agrawal@amd.com \
--cc=andrew.smirnov@gmail.com \
--cc=andy.gross@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=corbet@lwn.net \
--cc=cw00.choi@samsung.com \
--cc=david.brown@linaro.org \
--cc=djkurtz@chromium.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
--cc=mazziesaccount@gmail.com \
--cc=mturquette@baylibre.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@kernel.org \
--cc=sjhuang@iluvatar.ai \
--cc=sre@kernel.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).