From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C3FDC4727D for ; Tue, 22 Sep 2020 20:54:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 002AA235FD for ; Tue, 22 Sep 2020 20:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726631AbgIVUyq (ORCPT ); Tue, 22 Sep 2020 16:54:46 -0400 Received: from mga05.intel.com ([192.55.52.43]:11102 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726589AbgIVUyp (ORCPT ); Tue, 22 Sep 2020 16:54:45 -0400 IronPort-SDR: IbWLdy+HvZ5oipwaxgweJedzkWF//iyW7AuZ1cwCDDucuXcg0SE+U7dqrOedrvzoH7aOwv4tEn mj8Kbx96HNgA== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="245542541" X-IronPort-AV: E=Sophos;i="5.77,292,1596524400"; d="scan'208";a="245542541" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 13:54:42 -0700 IronPort-SDR: 5FCHO4veOMnmQr/vYqzSWcHLfbRAnshMAy/WKfU6qLiQv7valflFUNp3exXXy/X0Y6le81VU8n QaAs1eL+vRJA== X-IronPort-AV: E=Sophos;i="5.77,292,1596524400"; d="scan'208";a="510718929" Received: from fkhoshne-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.255.230.168]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 13:54:41 -0700 From: sathyanarayanan.kuppuswamy@linux.intel.com To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH v9 0/5] Simplify PCIe native ownership detection logic Date: Tue, 22 Sep 2020 13:54:27 -0700 Message-Id: X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuppuswamy Sathyanarayanan Currently, PCIe capabilities ownership status is detected by verifying the status of pcie_ports_native, pcie_ports_dpc_native and _OSC negotiated results (cached in struct pci_host_bridge ->native_* members). But this logic can be simplified, and we can use only struct pci_host_bridge ->native_* members to detect it. This patchset removes the distributed checks for pcie_ports_native, pcie_ports_dpc_native parameters. Changes since v8: * Simplified setting _OSC ownwership logic * Moved bridge->native_ltr out of #ifdef CONFIG_PCIEPORTBUS. Changes since v7: * Fixed "fix array_size.cocci warnings". Changes since v6: * Created new patch for CONFIG_PCIEPORTBUS check in pci_init_host_bridge(). * Added warning message for a case when pcie_ports_native overrides _OSC negotiation result. Changes since v5: * Rebased on top of v5.8-rc1 Changes since v4: * Changed the patch set title (Original link: https://lkml.org/lkml/2020/5/26/1710) * Added AER/DPC dependency logic cleanup fixes. Kuppuswamy Sathyanarayanan (5): PCI: Conditionally initialize host bridge native_* members ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set. ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set. PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic PCI/DPC: Move AER/DPC dependency checks out of DPC driver drivers/acpi/pci_root.c | 37 ++++++++++++++++++++++--------- drivers/pci/hotplug/pciehp_core.c | 2 +- drivers/pci/pci-acpi.c | 3 --- drivers/pci/pcie/aer.c | 2 +- drivers/pci/pcie/dpc.c | 3 --- drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_core.c | 13 +++++------ drivers/pci/probe.c | 6 +++-- include/linux/acpi.h | 2 ++ include/linux/pci.h | 2 ++ 10 files changed, 42 insertions(+), 30 deletions(-) -- 2.17.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DF04C4727D for ; Mon, 28 Sep 2020 01:11:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C30D23A33 for ; Mon, 28 Sep 2020 01:11:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ip7HYjaF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgI1BLo (ORCPT ); Sun, 27 Sep 2020 21:11:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgI1BLo (ORCPT ); Sun, 27 Sep 2020 21:11:44 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6626BC0613CE; Sun, 27 Sep 2020 18:11:44 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id t14so6841137pgl.10; Sun, 27 Sep 2020 18:11:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=brvnhRHveKpcyA289fKWkqddwqDpTeKxSpM0NIBNgNI=; b=Ip7HYjaFcNh8iBube4A0vFBHWqdpBW2GLeGxz8cmRVlZ7LLKoXUyrChLzenGuv+7d+ Gelka4dnulxH5OtNGJy6f/qLZ6BYBcgBbwB724etiMUmajB6wDgl8PKKjCFg6folDwAp tFuHWKPTPoxusgpvz7G2ab9RYnAHZWH5bdV1t7EurDA3jHh9ThKkMUhq11KBdfkd/Rue HnN3C7U5MfKsi8+70iPdW9t5gflIveiAKQLwlJKZIOpn8IvWEAQregFmuylPGfsXnw17 BANbDZajhoKUkpXe/O7JSFHx3uhRGvCdpJ6Ivg/mz5mrA54IztqCyhUlIIQlturrSrqP fjVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=brvnhRHveKpcyA289fKWkqddwqDpTeKxSpM0NIBNgNI=; b=Bz9RRkTvRBsP7lfD1BG/7B47lKxK6PgJiykaAbUN7l7nYXcBDlSIIGi5OH2O53B2V9 dVYBAiA2CMPnKecSLRO7fLwCaAxdAqOZI3okz6JzqB1qxEC836AUUJj3WlH49gKlwAEd r9NVyZ+CU0roFoHHCQodAntreaRzl2GLJjs4hGsn6S50g2hvkQer8rK9Ja5siUAu/4g7 C2emfWLKI9VwgkvU0tXNY83hUvPcOunPVSd+OLVIxZpgpDxPqKmndLgjn0j4EQ+kT5bv DZ959MjkcfmWmVdAW3QIrR3CVE0mcTpugW9DAfPMPq9M6c83V6OJEEv30S5eJ31GiXfu 33VQ== X-Gm-Message-State: AOAM532sLwiM3qtgj2WHPc6kmsAaRjEQyMYrqCH3jupmhO0oKV/NVd1h QPkX5JU57QXkoIEHAZ8bkJA= X-Google-Smtp-Source: ABdhPJwXs2WQgMY/3KIGHrSBplUPoLhS47mHpcCvyOvOnfvhOYpy3gs2bT9z4JNoF0LKZT0PFljIEA== X-Received: by 2002:a63:c00d:: with SMTP id h13mr7294429pgg.358.1601255503840; Sun, 27 Sep 2020 18:11:43 -0700 (PDT) Received: from skuppusw-mobl5.amr.corp.intel.com (jfdmzpr04-ext.jf.intel.com. [134.134.137.73]) by smtp.gmail.com with ESMTPSA id 137sm9368048pfb.183.2020.09.27.18.11.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 18:11:43 -0700 (PDT) From: Kuppuswamy Sathyanarayanan X-Google-Original-From: Kuppuswamy Sathyanarayanan To: bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, ashok.raj@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH v9 0/5] Simplify PCIe native ownership detection logic Date: Sun, 27 Sep 2020 18:11:31 -0700 Message-ID: X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Message-ID: <20200928011131.MI-pJpJNRQw6c35j_O6019flLWHe08C4WvKPmKEbnik@z> Currently, PCIe capabilities ownership status is detected by verifying the status of pcie_ports_native, pcie_ports_dpc_native and _OSC negotiated results (cached in struct pci_host_bridge ->native_* members). But this logic can be simplified, and we can use only struct pci_host_bridge ->native_* members to detect it. This patchset removes the distributed checks for pcie_ports_native, pcie_ports_dpc_native parameters. Changes since v8: * Simplified setting _OSC ownwership logic * Moved bridge->native_ltr out of #ifdef CONFIG_PCIEPORTBUS. Changes since v7: * Fixed "fix array_size.cocci warnings". Changes since v6: * Created new patch for CONFIG_PCIEPORTBUS check in pci_init_host_bridge(). * Added warning message for a case when pcie_ports_native overrides _OSC negotiation result. Changes since v5: * Rebased on top of v5.8-rc1 Changes since v4: * Changed the patch set title (Original link: https://lkml.org/lkml/2020/5/26/1710) * Added AER/DPC dependency logic cleanup fixes. Kuppuswamy Sathyanarayanan (5): PCI: Conditionally initialize host bridge native_* members ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set. ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set. PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic PCI/DPC: Move AER/DPC dependency checks out of DPC driver drivers/acpi/pci_root.c | 37 ++++++++++++++++++++++--------- drivers/pci/hotplug/pciehp_core.c | 2 +- drivers/pci/pci-acpi.c | 3 --- drivers/pci/pcie/aer.c | 2 +- drivers/pci/pcie/dpc.c | 3 --- drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_core.c | 13 +++++------ drivers/pci/probe.c | 6 +++-- include/linux/acpi.h | 2 ++ include/linux/pci.h | 2 ++ 10 files changed, 42 insertions(+), 30 deletions(-) -- 2.17.1