From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Omar Sandoval <osandov@osandov.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH for-next 0/2] optimise sbitmap deferred clear
Date: Sat, 21 Nov 2020 00:01:14 +0000 [thread overview]
Message-ID: <cover.1605908165.git.asml.silence@gmail.com> (raw)
In short, sbitmap_deferred_clear() lights up pretty much in my profiler,
so these optimisations gave me ~1% more t-put. All the heavy stuff is in
[2/2]. Would love someones eye to check it.
I also want to replace cmpxchg() in that function with a single
atomic and, that's slightly lighter and also transfers it from
lock-free to wait-free, that's pretty neat.
The problem is that apparently there is a non-atomic_t atomic and,
and atomic_t is unsigned int but all the bitmap do unsigned long.
Advice is welcome.
Pavel Begunkov (2):
sbitmap: optimise sbitmap_deferred_clear()
sbitmap: remove swap_lock
include/linux/sbitmap.h | 5 -----
lib/sbitmap.c | 21 +++++++--------------
2 files changed, 7 insertions(+), 19 deletions(-)
--
2.24.0
next reply other threads:[~2020-11-21 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 0:01 Pavel Begunkov [this message]
2020-11-21 0:01 ` [PATCH 1/2] sbitmap: optimise sbitmap_deferred_clear() Pavel Begunkov
2020-11-21 0:01 ` [PATCH 2/2] sbitmap: remove swap_lock Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1605908165.git.asml.silence@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).