From: Guru Das Srinagesh <firstname.lastname@example.org> To: Mark Brown <email@example.com>, Markus Elfring <Markus.Elfring@web.de>, Lee Jones <firstname.lastname@example.org>, Rob Herring <email@example.com> Cc: Bjorn Andersson <firstname.lastname@example.org>, Greg KH <email@example.com>, Guenter Roeck <firstname.lastname@example.org>, Joe Perches <email@example.com>, Subbaraman Narayanamurthy <firstname.lastname@example.org>, David Collins <email@example.com>, Anirudh Ghayal <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, Guru Das Srinagesh <firstname.lastname@example.org> Subject: [RFC PATCH v3 0/3] Add support for Qualcomm MFD PMIC register layout Date: Wed, 10 Mar 2021 16:39:51 -0800 [thread overview] Message-ID: <email@example.com> (raw) Changes from v2: - Split up framework changes patch for better comprehension. - Dropped PM8008 driver example and converted it into example code in cover letter and commit text. - Added more info in cover letter and commit message as per v2 feedback. This is a follow-up as promised  to the earlier attempts   to upstream the driver that has been hitherto used to handle IRQs for Qualcomm's PMICs that have multiple on-board peripherals when they are interfaced over the I2C interface. This series is a rewrite of that driver while making use of the regmap-irq framework, which needs some modifications to handle the register layout of Qualcomm's PMICs. This is an RFC because I would like to get feedback on my general approach before submitting as a patch per se. Qualcomm's MFD chips have a top level interrupt status register and sub-irqs (peripherals). When a bit in the main status register goes high, it means that the peripheral corresponding to that bit has an unserviced interrupt. If the bit is not set, this means that the corresponding peripheral does not. The differences between Qualcomm's register layout and what the regmap-irq framework assumes are best described with an example: Suppose that there are three peripherals onboard an MFD chip: MISC, TEMP_ALARM and GPIO01. Each of these peripherals has the following IRQ configuration registers: mask, type and ack. There is a top level interrupt status register and per-peripheral status registers as well (not shown below). The regmap-irq framework expects all similar registers to be at a fixed stride from each other, for each peripheral, as below (with stride = 1). /* All mask registers together */ MISC_INT_MASK 0x1011 TEMP_ALARM_INT_MASK 0x1012 GPIO01_INT_MASK 0x1013 /* All type registers together */ MISC_INT_TYPE 0x2011 TEMP_ALARM_INT_TYPE 0x2012 GPIO01_INT_TYPE 0x2013 /* All ack registers together */ MISC_INT_ACK 0x3011 TEMP_ALARM_INT_ACK 0x3012 GPIO01_INT_ACK 0x3013 In contrast, QCOM's registers are laid out as follows: /* All of MISC peripheral's registers together */ MISC_INT_MASK 0x1011 MISC_INT_TYPE 0x1012 MISC_INT_ACK 0x1013 /* All of TEMP_ALARM peripheral's registers together */ TEMP_ALARM_INT_MASK 0x2011 TEMP_ALARM_INT_TYPE 0x2012 TEMP_ALARM_INT_ACK 0x2013 /* All of GPIO01 peripheral's registers together */ GPIO01_INT_MASK 0x3011 GPIO01_INT_TYPE 0x3012 GPIO01_INT_ACK 0x3013 As is evident, the different IRQ configuration registers are just (0x11, 0x12, 0x13) with offsets of (0x1000, 0x2000 and 0x3000) respectively in QCOM's case. If the *_base registers fed to the struct regmap_irq_chip could be set to the first peripheral (MISC in this example), then through the sub_reg_offsets mechanism, we could add the offsets _to_ the *_base register values to get at the configuration registers for each peripheral. Hopefully this will help when reviewing the changes in this series.  https://lore.kernel.org/lkml/20200519185757.GA13992@codeaurora.org/  https://firstname.lastname@example.org/  https://email@example.com/ Guru Das Srinagesh (3): regmap-irq: Extend sub-irq to support non-fixed reg strides regmap-irq: Add support for POLARITY_HI and POLARITY_LO config regs regmap-irq: Modify type_buf handling for IRQ_TYPE_LEVEL_* drivers/base/regmap/regmap-irq.c | 152 +++++++++++++++++++++++++++++++-------- include/linux/regmap.h | 11 +++ 2 files changed, 133 insertions(+), 30 deletions(-) -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next reply other threads:[~2021-03-11 0:40 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-11 0:39 Guru Das Srinagesh [this message] 2021-03-11 0:39 ` [RFC PATCH v3 1/3] regmap-irq: Extend sub-irq to support non-fixed reg strides Guru Das Srinagesh 2021-04-12 6:05 ` Matti Vaittinen 2021-04-12 11:08 ` Vaittinen, Matti 2021-04-12 18:08 ` Guru Das Srinagesh 2021-03-11 0:39 ` [RFC PATCH v3 2/3] regmap-irq: Add support for POLARITY_HI and POLARITY_LO config regs Guru Das Srinagesh 2021-03-12 12:19 ` Mark Brown 2021-03-15 20:33 ` Guru Das Srinagesh 2021-03-15 20:36 ` Guru Das Srinagesh 2021-03-17 20:42 ` Mark Brown 2021-03-20 2:37 ` Guru Das Srinagesh 2021-03-11 0:39 ` [RFC PATCH v3 3/3] regmap-irq: Modify type_buf handling for IRQ_TYPE_LEVEL_* Guru Das Srinagesh 2021-03-18 18:33 ` (subset) [RFC PATCH v3 0/3] Add support for Qualcomm MFD PMIC register layout Mark Brown 2021-03-18 18:36 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --cc=Markus.Elfring@web.de \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [RFC PATCH v3 0/3] Add support for Qualcomm MFD PMIC register layout' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).