From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07FF8C433ED for ; Mon, 5 Apr 2021 16:50:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE86C611AF for ; Mon, 5 Apr 2021 16:50:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231822AbhDEQuU (ORCPT ); Mon, 5 Apr 2021 12:50:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229735AbhDEQuS (ORCPT ); Mon, 5 Apr 2021 12:50:18 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6789AC061756 for ; Mon, 5 Apr 2021 09:50:11 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id r14-20020a05600c35ceb029010fe0f81519so4425771wmq.0 for ; Mon, 05 Apr 2021 09:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gPfTaF4f61niwOGxXWsD+hVfFZNowGCSAbAq2kTY6aM=; b=Wqe3zo9iBWtoAOeNGdjAM+RAT4M8svsQoneMnXc7wv7EkKstiyMLs2ylnQaANp4XOR hZo//KKRRzwSJKeP3LB4Cw2gyqIdowXt8HgrTrBEs0ORRCNwiDLH0B5Veqe9gyScLFg9 nYNsHHbue/5OHq2/Puzjja7ni0JHg/zI+3uou+YcrLfVSJX0ZAafbaolME0PnMyLRL5Z RPPK6y+zHzSsmQfTM2I2ZzQZfPgO+SmWAzrvL1acAtSDnHHsNWEq+5eNojn4Yr0uS5v0 NfJ3ShZY1TCC6F3ZitGtmbUyL42bEBGnB+JbsfG24c4799Xg/qV9WP5+BtcuNYriIVso zmFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gPfTaF4f61niwOGxXWsD+hVfFZNowGCSAbAq2kTY6aM=; b=p1XQ8s/y32fh+qQsmIDXB7hpEXHxkv7bmWc3d09wdPnKM1PKs4hZFPk6ik7pUw9Ira 9kGEddfOfC2a/MyoE2vOaNDfesGc78xcvppIyVC057koAk+EaUB8FTPQvfnOLa4QUtxx t/AAuT1C0x6DP17Wqao4ENKzon98K0btHDohN//Ia33lpnp816dX+D/4JaJhdwcdjZ+8 1jFfz2FeXlAeWVoiy4H14QPNow1oX2oY/1xspUr/4GfUoqESYQyUvq2lEmPeec1Z48H7 wTwC+MudCJsDGg0Jdux8Pw89GpM9OC1hpIT8gOzcbHYnEEWQQalhz8C6+8KIpBnVHtXR 1t2g== X-Gm-Message-State: AOAM532DsRhLAo7hru+xvIH/iKMpvtZhiJEQQStvtLvjUr+BP4gBa0ES zAhP1HN/Dj0tj4YHkR8Fmks= X-Google-Smtp-Source: ABdhPJx/V1BFwD23If6cf9JbGSYqTBNZsLBzujn0wMhcwfZW2n9WEbB0phfQ7dxx1xMswoisYA/BKg== X-Received: by 2002:a05:600c:4103:: with SMTP id j3mr21010wmi.175.1617641410079; Mon, 05 Apr 2021 09:50:10 -0700 (PDT) Received: from agape ([5.171.72.58]) by smtp.gmail.com with ESMTPSA id 187sm1369311wma.0.2021.04.05.09.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Apr 2021 09:50:09 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: dan.carpenter@oracle.com, joe@perches.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH 00/10] staging: rtl8723bs: completely remove RT_TRACE logs Date: Mon, 5 Apr 2021 18:49:47 +0200 Message-Id: X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patchset removes all RT_TRACE usages left and definitions The whole private tracing system is not tied to a configuration symbol and the default behaviour is _trace nothing_. It's verbose and relies on a private log level tracing doomed to be removed. The patchset consist on a first patch applying the following semantic patch on rtl8723bs directory: $ cat RT_TRACE.cocci @@ expression a, b, c; @@ - RT_TRACE(a, b, (c)); Then follows a patch removing commented out RT_TRACE calls. Third patch removes RT_TRACE definitions. All other patches, do some code cleaning on sites left blank by RT_TRACE removal. This scheme was suggested by Joe Perches. https://lore.kernel.org/linux-staging/1cd79d781cdcccf621ce8e104a9cdf1e90e7f803.camel@perches.com/ Fabio Aiuto (10): staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/ staging: rtl8723bs: remove commented out RT_TRACE logs in hal/ and os_dep/ staging: rtl8723bs: remove RT_TRACE log definitions staging: rtl8723bs: remove empty if, else blocks after RT_TRACE deletion staging: rtl8723bs: remove empty #ifdef blocks after RT_TRACE deletion staging: rtl8723bs: remove unnecessary bracks after RT_TRACE deletion staging: rtl8723bs: place constant on the right side of the test staging: rtl8723bs: rewrite comparisons to null staging: rtl8723bs: remove empty for cycles staging: rtl8723bs: remove commented code block .../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 3 - drivers/staging/rtl8723bs/hal/HalPwrSeqCmd.c | 46 ------ .../staging/rtl8723bs/hal/hal_com_phycfg.c | 20 --- drivers/staging/rtl8723bs/hal/hal_intf.c | 2 - .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 131 +----------------- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 33 ----- .../staging/rtl8723bs/hal/rtl8723b_rf6052.c | 2 - .../staging/rtl8723bs/hal/rtl8723bs_recv.c | 5 +- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 41 +----- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 49 +------ drivers/staging/rtl8723bs/hal/sdio_ops.c | 35 +---- drivers/staging/rtl8723bs/include/rtw_debug.h | 18 --- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 6 - .../staging/rtl8723bs/os_dep/ioctl_linux.c | 69 +-------- drivers/staging/rtl8723bs/os_dep/mlme_linux.c | 4 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 52 +------ .../staging/rtl8723bs/os_dep/osdep_service.c | 4 +- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 12 +- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 28 +--- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 5 - 20 files changed, 24 insertions(+), 541 deletions(-) -- 2.20.1