From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v3 00/43] staging: rtl8723bs: clean up driver from private debug facilities
Date: Fri, 30 Apr 2021 16:56:22 +0200 [thread overview]
Message-ID: <cover.1619794331.git.fabioaiuto83@gmail.com> (raw)
This patchset remove all private debug facilities.
It removes unused macros and _do nothing_ ones (i.e. macros
whose behaviour is activated by manual code update).
Replace tracing macros wrapping raw printk calls by
netdev_dbg() calls which is best suited for a network
driver.
Remove all unused macros and function definition tied to
the whole private tracing facility.
------------------------------------------------
Changes in v3:
- fix spelling error in subject of patch 2
as reported by Bryan Brattlof.
Changes in v2:
- fix patch 4 did not compile due to missing removal
of target file in Makefile (as reported by
kernel test robot). Remove deleted file target.
- patch 40 did not compile due to missing removal
of target file in Makefile. Remove deleted file
taget.
- reword of both patches 4 and 40.
Fabio Aiuto (43):
staging: rtl8723bs: remove ODM_RT_TRACE logs
staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE
deletion
staging: rtl8723bs: remove empty functions
staging: rtl8723bs: remove empty hal/odm_PathDiv.c source file
staging: rtl8723bs: remove undefined function prototypes
staging: rtl8723bs: remove empty header file
staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defs
staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs
staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg()
staging: rtl8723bs: remove unused ODM_RT_ASSERT macro
staging: rtl8723bs: remove unused ODM_PRINT_ADDR macro
staging: rtl8723bs: remove unused ODM_dbg_trace macro
staging: rtl8723bs: remove unused ODM_dbg_enter
staging: rtl8723bs: remove unused ODM_dbg_exit macro
staging: rtl8723bs: remove empty ifdef block
staging: rtl8723bs: remove unused ASSERT macro
staging: rtl8723bs: remove empty #ifndef block
staging: rtl8723bs: remove commented out RT_ASSERT occurrences
staging: rtl8723bs: remove unused RT_PRINTK macro
staging: rtl8723bs: remove BTC_PRINT logs
staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT
removal
staging: rtl8723bs: remove braces around single statement in if block
staging: rtl8723bs: remove commented out BTC_PRINT logs
staging: rtl8723bs: remove BTC_PRINT macro definitions
staging: rtl8723bs: remove BTC_PRINT_ADDR macro definitions
staging: rtl8723bs: remove BTC_PRINT_DATA definitions
staging: rtl8723bs: remove BTC_PRINT_F macro definition
staging: rtl8723bs: remove empty #ifdef block
staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() function
staging: rtl8723bs: remove hal_btcoex_GetDBG() function
staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() function
staging: rtl8723bs: remove obsolete GLBtcDbgType array declarations
staging: rtl8723bs: remove unused enum
staging: rtl8723bs: remove obsolete debug macros
staging: rtl8723bs: remove commented out DbgPrint logs
staging: rtl8723bs: remove unused DbgPrint macro
staging: rtl8723bs: remove commented out *RT_DISP logs
staging: rtl8723bs: remove RT_DISP macro definition
staging: rtl8723bs: remove ODM_InitDebugSetting() function
staging: rtl8723bs: remove empty hal/odm_debug.c file
staging: rtl8723bs: remove member in dm_odm_t struct
staging: rtl8723bs: remove DebugLevel member in dm_odm_t struct
staging: rtl8723bs: remove odm_debug.h header file
drivers/staging/rtl8723bs/Makefile | 2 -
drivers/staging/rtl8723bs/core/rtw_efuse.c | 1 -
drivers/staging/rtl8723bs/core/rtw_recv.c | 22 -
.../staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 604 +-----------------
.../staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 502 +--------------
drivers/staging/rtl8723bs/hal/HalBtcOutSrc.h | 67 --
.../staging/rtl8723bs/hal/HalHWImg8723B_BB.c | 62 --
.../staging/rtl8723bs/hal/HalHWImg8723B_MAC.c | 49 --
.../staging/rtl8723bs/hal/HalHWImg8723B_RF.c | 63 --
drivers/staging/rtl8723bs/hal/HalPhyRf.c | 332 ----------
.../staging/rtl8723bs/hal/HalPhyRf_8723B.c | 177 +----
drivers/staging/rtl8723bs/hal/hal_btcoex.c | 171 -----
drivers/staging/rtl8723bs/hal/hal_com.c | 14 -
drivers/staging/rtl8723bs/hal/odm.c | 53 +-
drivers/staging/rtl8723bs/hal/odm.h | 4 -
.../staging/rtl8723bs/hal/odm_CfoTracking.c | 107 ----
drivers/staging/rtl8723bs/hal/odm_DIG.c | 320 ----------
.../rtl8723bs/hal/odm_EdcaTurboCheck.c | 18 -
drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 38 --
.../staging/rtl8723bs/hal/odm_NoiseMonitor.c | 27 -
drivers/staging/rtl8723bs/hal/odm_PathDiv.c | 34 -
drivers/staging/rtl8723bs/hal/odm_PathDiv.h | 21 -
drivers/staging/rtl8723bs/hal/odm_RTL8723B.c | 1 -
.../rtl8723bs/hal/odm_RegConfig8723B.c | 66 --
drivers/staging/rtl8723bs/hal/odm_debug.c | 44 --
drivers/staging/rtl8723bs/hal/odm_debug.h | 165 -----
drivers/staging/rtl8723bs/hal/odm_precomp.h | 2 -
.../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 -
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 7 -
.../staging/rtl8723bs/include/hal_btcoex.h | 2 -
30 files changed, 6 insertions(+), 2972 deletions(-)
delete mode 100644 drivers/staging/rtl8723bs/hal/odm_PathDiv.c
delete mode 100644 drivers/staging/rtl8723bs/hal/odm_PathDiv.h
delete mode 100644 drivers/staging/rtl8723bs/hal/odm_debug.c
delete mode 100644 drivers/staging/rtl8723bs/hal/odm_debug.h
--
2.20.1
next reply other threads:[~2021-04-30 14:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 14:56 Fabio Aiuto [this message]
2021-04-30 14:56 ` [PATCH v3 01/43] staging: rtl8723bs: remove ODM_RT_TRACE logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 02/43] staging: rtl8723bs: remove if-else blocks left empty by ODM_RT_TRACE deletion Fabio Aiuto
2021-05-03 7:27 ` Dan Carpenter
2021-05-03 7:42 ` Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 03/43] staging: rtl8723bs: remove empty functions Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 04/43] staging: rtl8723bs: remove empty hal/odm_PathDiv.c source file Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 05/43] staging: rtl8723bs: remove undefined function prototypes Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 06/43] staging: rtl8723bs: remove empty header file Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 07/43] staging: rtl8723bs: remove ODM_RT_TRACE* unused macro defs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 08/43] staging: rtl8723bs: remove all commented out ODM_RT_TRACE logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 09/43] staging: rtl8723bs: replace ODM_RT_ASSERT with netdev_dbg() Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 10/43] staging: rtl8723bs: remove unused ODM_RT_ASSERT macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 11/43] staging: rtl8723bs: remove unused ODM_PRINT_ADDR macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 12/43] staging: rtl8723bs: remove unused ODM_dbg_trace macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 13/43] staging: rtl8723bs: remove unused ODM_dbg_enter Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 14/43] staging: rtl8723bs: remove unused ODM_dbg_exit macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 15/43] staging: rtl8723bs: remove empty ifdef block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 16/43] staging: rtl8723bs: remove unused ASSERT macro Fabio Aiuto
2021-05-03 7:31 ` Dan Carpenter
2021-05-03 7:43 ` Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 17/43] staging: rtl8723bs: remove empty #ifndef block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 18/43] staging: rtl8723bs: remove commented out RT_ASSERT occurrences Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 19/43] staging: rtl8723bs: remove unused RT_PRINTK macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 20/43] staging: rtl8723bs: remove BTC_PRINT logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 21/43] staging: rtl8723bs: remove empty if-else blocks after BTC_PRINT removal Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 22/43] staging: rtl8723bs: remove braces around single statement in if block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 23/43] staging: rtl8723bs: remove commented out BTC_PRINT logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 24/43] staging: rtl8723bs: remove BTC_PRINT macro definitions Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 25/43] staging: rtl8723bs: remove BTC_PRINT_ADDR " Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 26/43] staging: rtl8723bs: remove BTC_PRINT_DATA definitions Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 27/43] staging: rtl8723bs: remove BTC_PRINT_F macro definition Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 28/43] staging: rtl8723bs: remove empty #ifdef block Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 29/43] staging: rtl8723bs: remove unsed hal_btcoex_SetDBG() function Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 30/43] staging: rtl8723bs: remove hal_btcoex_GetDBG() function Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 31/43] staging: rtl8723bs: remove unnecessary halbtcoutsrc_DbgInit() function Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 32/43] staging: rtl8723bs: remove obsolete GLBtcDbgType array declarations Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 33/43] staging: rtl8723bs: remove unused enum Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 34/43] staging: rtl8723bs: remove obsolete debug macros Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 35/43] staging: rtl8723bs: remove commented out DbgPrint logs Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 36/43] staging: rtl8723bs: remove unused DbgPrint macro Fabio Aiuto
2021-04-30 14:56 ` [PATCH v3 37/43] staging: rtl8723bs: remove commented out *RT_DISP logs Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 38/43] staging: rtl8723bs: remove RT_DISP macro definition Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 39/43] staging: rtl8723bs: remove ODM_InitDebugSetting() function Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 40/43] staging: rtl8723bs: remove empty hal/odm_debug.c file Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 41/43] staging: rtl8723bs: remove member in dm_odm_t struct Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 42/43] staging: rtl8723bs: remove DebugLevel " Fabio Aiuto
2021-04-30 14:57 ` [PATCH v3 43/43] staging: rtl8723bs: remove odm_debug.h header file Fabio Aiuto
2021-05-03 7:52 ` [PATCH v3 00/43] staging: rtl8723bs: clean up driver from private debug facilities Dan Carpenter
2021-05-03 8:17 ` Fabio Aiuto
2021-05-03 9:24 ` Sergio Paracuellos
2021-05-03 10:34 ` Fabio Aiuto
2021-05-03 11:48 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1619794331.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).