From: Ojaswin Mujoo <firstname.lastname@example.org> To: email@example.com Cc: Ojaswin Mujoo <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com Subject: [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code Date: Wed, 21 Jul 2021 21:50:48 +0530 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) Hello, This patchset adderesses the TODO item number 10 specified at: drivers/staging/vc04-services/interface/TODO For reference, the task is: 10) Reorganize file structure: Move char driver to it's own file and join both platform files The cdev is defined alongside with the platform code in vchiq_arm.c. It would be nice to completely decouple it from the actual core code. For instance to be able to use bcm2835-audio without having /dev/vchiq created. One could argue it's better for security reasons or general cleanliness. It could even be interesting to create two different kernel modules, something the likes of vchiq-core.ko and vchiq-dev.ko. This would also ease the upstreaming process. A summary of the patches is as follows: - Patch 1: Move cdev init code into a function - Patch 2: Shift some devlarations from vchiq_arm.c to vchiq_arm.h for sharing - Patch 3: Move vchiq cdev init code from vchiq_arm.c into vchiq_dev.c - Patch 4: Decouple cdev code by defining a Kconfig entry to allow optional compilation of it. - Patch 5: Merge code in vchiq_2835_arm.c to vchiq_arm.c Changes since v3 : * In Patch 5, replace forward declarations of some of the functions with function definition Changes since v2 : * In Patch 1, as suggested, I have added error handling code back to ensure the driver exits when there is an error in creating vchiq cdev * I have built this patch against the right kernel (gregkh/staging, staging-next branch) to avoid introducing any unwanted inconsistencies like whitespace changes I have tested the patch using vchiq_test utility on RPi 3B+. Regards, Ojaswin  v2: https://lore.kernel.org/patchwork/cover/1449117/  v3: https://lore.kernel.org/patchwork/cover/1453915/ Ojaswin Mujoo (5): staging: vchiq: Refactor vchiq cdev code staging: vchiq: Move certain declarations to vchiq_arm.h staging: vchiq: Move vchiq char driver to its own file staging: vchiq: Make creation of vchiq cdev optional staging: vchiq: Combine vchiq platform code into single file drivers/staging/vc04_services/Kconfig | 10 + drivers/staging/vc04_services/Makefile | 5 +- .../interface/vchiq_arm/vchiq_2835_arm.c | 564 ---- .../interface/vchiq_arm/vchiq_arm.c | 2330 +++++------------ .../interface/vchiq_arm/vchiq_arm.h | 82 + .../interface/vchiq_arm/vchiq_dev.c | 1440 ++++++++++ 6 files changed, 2251 insertions(+), 2180 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c create mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c -- 2.25.1
next reply other threads:[~2021-07-21 16:21 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-21 16:20 Ojaswin Mujoo [this message] 2021-07-21 16:20 ` [PATCH v4 1/5] staging: vchiq: Refactor vchiq " Ojaswin Mujoo 2021-07-21 16:20 ` [PATCH v4 2/5] staging: vchiq: Move certain declarations to vchiq_arm.h Ojaswin Mujoo 2021-07-21 16:20 ` [PATCH v4 3/5] staging: vchiq: Move vchiq char driver to its own file Ojaswin Mujoo 2021-07-21 16:20 ` [PATCH v4 4/5] staging: vchiq: Make creation of vchiq cdev optional Ojaswin Mujoo 2021-07-27 13:25 ` Greg KH 2021-07-27 16:55 ` Ojaswin Mujoo 2021-07-21 16:20 ` [PATCH v4 5/5] staging: vchiq: Combine vchiq platform code into single file Ojaswin Mujoo 2021-07-23 11:02 ` [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code Greg KH 2021-07-23 12:59 ` Ojaswin Mujoo 2021-07-23 13:31 ` Stefan Wahren 2021-07-24 10:44 ` Ojaswin Mujoo 2021-07-24 9:38 ` Stefan Wahren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH v4 0/5] vchiq: Patch to separate platform and cdev code' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).