From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Robert Schlabbach <robert_s@gmx.net>,
Antti Palosaari <crope@iki.fi>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: [PATCH v3 0/4] media: si2157: rework firmware load logic
Date: Fri, 10 Dec 2021 08:56:55 +0100 [thread overview]
Message-ID: <cover.1639120421.git.mchehab+huawei@kernel.org> (raw)
As pointed bt Robert, if there's already a firmware for si2157 at
/lib/firmware, it is preferred to use it, instead of the default firmware.
Yet, when this is missed, the driver may still work. That's the case,
for instance, of the devices explicitly flagged with dont_load_firmware
(currently, Terratec Cinergy TC2).
So, rework the firmware logic in a way that it will emit a warning for
devices that are using the eeprom firmware and may not work well
with it.
Compile-tested only.
--
v3:
- Rename some data structs;
- Better handle the cases where the ROM is unknown.
v2:
- added a patch to allow supporting different firmwares depending on
the device's reported ROM ID.
Mauro Carvalho Chehab (3):
media: si2157: move firmware load to a separate function
media: si2157: rework the firmware load logic
media: si2157: use a different namespace for firmware
Robert Schlabbach (1):
media: si2157: Add optional firmware download
drivers/media/tuners/si2157.c | 254 +++++++++++++++++------------
drivers/media/tuners/si2157_priv.h | 31 ++++
2 files changed, 184 insertions(+), 101 deletions(-)
--
2.33.1
next reply other threads:[~2021-12-10 7:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 7:56 Mauro Carvalho Chehab [this message]
2021-12-10 7:56 ` [PATCH v3 1/4] media: si2157: move firmware load to a separate function Mauro Carvalho Chehab
2021-12-10 7:56 ` [PATCH v3 2/4] media: si2157: Add optional firmware download Mauro Carvalho Chehab
2021-12-10 7:56 ` [PATCH v3 3/4] media: si2157: rework the firmware load logic Mauro Carvalho Chehab
2021-12-10 7:56 ` [PATCH v3 4/4] media: si2157: use a different namespace for firmware Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1639120421.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mauro.chehab@huawei.com \
--cc=mchehab@kernel.org \
--cc=robert_s@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).