From: Andrew Jeffery <andrew@aj.id.au>
To: linux-hwmon@vger.kernel.org
Cc: Andrew Jeffery <andrew@aj.id.au>,
linux@roeck-us.net, robh+dt@kernel.org, mark.rutland@arm.com,
jdelvare@suse.com, corbet@lwn.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
joel@jms.id.au, openbmc@lists.ozlabs.org
Subject: [PATCH v5 0/4] pmbus: Expand fan support and add MAX31785 driver
Date: Sat, 18 Nov 2017 13:56:02 +1030 [thread overview]
Message-ID: <cover.8f64654fcede136901874050318e64de7f1a68cb.1510974230.git-series.andrew@aj.id.au> (raw)
Hello,
This series introduces support for the MAX31785 intelligent fan controller, a
PMBus device providing closed-loop fan control among a number of other
features. Along the way the series adds support to control fans and create
virtual pages to the PMBus core, the latter to support some of the more
annoying design decisions found in the 'A' variant of the chip.
This is the fifth spin of the series. v4 can be found here:
https://lkml.org/lkml/2017/11/3/15
The changes over v4 include a rework of the fan control support to provide a
more intuitive behaviour for fanX_target, pwmX. They now always read the value
last set (in v4 they returned 0 if they were not the active control mode, and
in even earlier spins they returned an error), which also allows implementation
of sane behaviour for pwmX_enable when switching control modes.
The default implementation for the PWM virtual registers is removed from pmbus
core in light of having no consumers (the max31785 driver implements them
itself), though whilst I was unsure about the generality of the scaling in
replies on v4, after some more thought I have reason to believe it should hold
in general. Regardless, it's gone for the moment, and I've added some
commentary about the scaling in the max31785 implementation.
Please review!
Andrew
Andrew Jeffery (4):
pmbus (core): Add fan control support
pmbus (max31785): Add fan control
pmbus (core): Add virtual page config bit
pmbus (max31785): Add dual tachometer support
Documentation/hwmon/max31785 | 15 +-
drivers/hwmon/pmbus/max31785.c | 285 +++++++++++++++++++++++++++++++-
drivers/hwmon/pmbus/pmbus.h | 41 ++++-
drivers/hwmon/pmbus/pmbus_core.c | 250 +++++++++++++++++++++++++---
4 files changed, 566 insertions(+), 25 deletions(-)
base-commit: ded0eb83449e8fcba22fd2736826336e101ffbcb
--
git-series 0.9.1
next reply other threads:[~2017-11-18 3:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-18 3:26 Andrew Jeffery [this message]
2017-11-18 3:26 ` [PATCH v5 1/4] pmbus (core): Add fan control support Andrew Jeffery
2017-11-18 3:26 ` [PATCH v5 2/4] pmbus (max31785): Add fan control Andrew Jeffery
2017-11-18 3:26 ` [PATCH v5 3/4] pmbus (core): Add virtual page config bit Andrew Jeffery
2017-11-19 16:49 ` Guenter Roeck
2017-11-20 0:40 ` Andrew Jeffery
2017-11-18 3:26 ` [PATCH v5 4/4] pmbus (max31785): Add dual tachometer support Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.8f64654fcede136901874050318e64de7f1a68cb.1510974230.git-series.andrew@aj.id.au \
--to=andrew@aj.id.au \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).