From: Bean Huo <huobean@gmail.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Can Guo <cang@codeaurora.org>,
Stanley Chu <stanley.chu@mediatek.com>
Subject: Re: [PATCH V4 1/2] scsi: ufs: Add DeepSleep feature
Date: Wed, 04 Nov 2020 11:57:03 +0100 [thread overview]
Message-ID: <d00acd2cef07c50de3e19e1b8517c996d67795b2.camel@gmail.com> (raw)
In-Reply-To: <20201103141403.2142-2-adrian.hunter@intel.com>
On Tue, 2020-11-03 at 16:14 +0200, Adrian Hunter wrote:
> DeepSleep is a UFS v3.1 feature that achieves the lowest power
> consumption
> of the device, apart from power off.
>
> In DeepSleep mode, no commands are accepted, and the only way to exit
> is
> using a hardware reset or power cycle.
>
> This patch assumes that if a power cycle was an option, then power
> off
> would be preferable, so only exit via a hardware reset is supported.
>
> Drivers that wish to support DeepSleep need to set a new capability
> flag
> UFSHCD_CAP_DEEPSLEEP and provide a hardware reset via the existing
> ->device_reset() callback.
>
> It is assumed that UFS devices with wspecversion >= 0x310 support
> DeepSleep.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Documentation/ABI/testing/sysfs-driver-ufs | 34 +++++++++++--------
> drivers/scsi/ufs/ufs-sysfs.c | 7 ++++
> drivers/scsi/ufs/ufs.h | 1 +
> drivers/scsi/ufs/ufshcd.c | 39
> ++++++++++++++++++++--
> drivers/scsi/ufs/ufshcd.h | 17 +++++++++-
> include/trace/events/ufs.h | 3 +-
> 6 files changed, 83 insertions(+), 18 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> b/Documentation/ABI/testing/sysfs-driver-ufs
> index adc0d0e91607..e77fa784d6d8 100644
> --- a/Documentation/ABI/testing/sysfs-driver-ufs
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -916,21 +916,24 @@ Date: September 2014
> Contact: Subhash Jadavani <subhashj@codeaurora.org>
> Description: This entry could be used to set or show the UFS device
> runtime power management level. The current driver
> - implementation supports 6 levels with next target
> states:
> + implementation supports 7 levels with next target
> states:
>
> == ===================================================
> =
> - 0 an UFS device will stay active, an UIC link will
> + 0 UFS device will stay active, UIC link will
> stay active
> - 1 an UFS device will stay active, an UIC link will
> + 1 UFS device will stay active, UIC link will
> hibernate
> - 2 an UFS device will moved to sleep, an UIC link will
> + 2 UFS device will be moved to sleep, UIC link will
> stay active
> - 3 an UFS device will moved to sleep, an UIC link will
> + 3 UFS device will be moved to sleep, UIC link will
> hibernate
> - 4 an UFS device will be powered off, an UIC link will
> + 4 UFS device will be powered off, UIC link will
> hibernate
> - 5 an UFS device will be powered off, an UIC link will
> + 5 UFS device will be powered off, UIC link will
> be powered off
> + 6 UFS device will be moved to deep sleep, UIC link
> + will be powered off. Note, deep sleep might not be
> + supported in which case this value will not be accepted
> == ===================================================
> =
>
> What: /sys/bus/platform/drivers/ufshcd/*/rpm_target_d
> ev_state
> @@ -954,21 +957,24 @@ Date: September 2014
> Contact: Subhash Jadavani <subhashj@codeaurora.org>
> Description: This entry could be used to set or show the UFS device
> system power management level. The current driver
> - implementation supports 6 levels with next target
> states:
> + implementation supports 7 levels with next target
> states:
>
> == ===================================================
> =
Hi Adrian
There doesn't have these equal sign lines in the sysfs-driver-ufs.
maybe you should remove these. or add + prefix.
Thanks,
Bean
next prev parent reply other threads:[~2020-11-04 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 14:14 [PATCH V4 0/2] scsi: ufs: Add DeepSleep feature Adrian Hunter
2020-11-03 14:14 ` [PATCH V4 1/2] " Adrian Hunter
2020-11-04 8:04 ` Can Guo
2020-11-04 8:29 ` Can Guo
2020-11-04 8:37 ` Adrian Hunter
2020-11-04 9:03 ` Can Guo
2020-11-04 10:57 ` Bean Huo [this message]
2020-11-04 11:55 ` Adrian Hunter
2020-11-04 13:19 ` Bean Huo
2020-11-04 16:35 ` Asutosh Das (asd)
2020-11-05 1:42 ` Stanley Chu
2020-11-03 14:14 ` [PATCH V4 2/2] scsi: ufs: Allow an error return value from ->device_reset() Adrian Hunter
2020-11-04 2:55 ` Stanley Chu
2020-11-04 8:05 ` Can Guo
2020-11-04 8:44 ` Bean Huo
2020-11-04 16:35 ` Asutosh Das (asd)
2020-11-05 4:06 ` [PATCH V4 0/2] scsi: ufs: Add DeepSleep feature Martin K. Petersen
2020-11-11 2:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d00acd2cef07c50de3e19e1b8517c996d67795b2.camel@gmail.com \
--to=huobean@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).