From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752746AbcG2IcK (ORCPT ); Fri, 29 Jul 2016 04:32:10 -0400 Received: from bear.ext.ti.com ([198.47.19.11]:39996 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751095AbcG2IcF (ORCPT ); Fri, 29 Jul 2016 04:32:05 -0400 Subject: Re: [PATCH v2 2/4] drivers: net: cpsw: fix wrong regs access in cpsw_remove To: Grygorii Strashko , "David S. Miller" , References: <20160728175037.22053-1-grygorii.strashko@ti.com> <20160728175037.22053-3-grygorii.strashko@ti.com> CC: Sekhar Nori , , From: Mugunthan V N Message-ID: Date: Fri, 29 Jul 2016 14:01:59 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160728175037.22053-3-grygorii.strashko@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 28 July 2016 11:20 PM, Grygorii Strashko wrote: > The L3 error will be generated and system will crash during unloading > of CPSW driver if CPSW is used as module and ethX devices are down. > This happens because CPSW can be power off by PM runtime now when ethX > devices are down. > > Hence, ensure that CPSW powered up by PM runtime before performing any > deinitialization actions which require CPSW registers access. In case > of PM runtime error just leave cpsw_remove() as we can't do anything > anymore. > > Signed-off-by: Grygorii Strashko Reviewed-by: Mugunthan V N Regards Mugunthan V N