From: Shuah Khan <shuahkh@osg.samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Alexandre Courbot <gnurou@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] tools: gpio add .gitignore for generated files
Date: Wed, 11 Jan 2017 09:02:26 -0700 [thread overview]
Message-ID: <d01c9c75-d8af-0c88-9538-cdeed1f01097@osg.samsung.com> (raw)
In-Reply-To: <CACRpkda=FdZ+G2rxMAk+WntHSdmm4=L9m=-0goTdAVJ2NnqHpg@mail.gmail.com>
On 01/11/2017 08:19 AM, Linus Walleij wrote:
> On Tue, Jan 10, 2017 at 3:07 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>> On 01/10/2017 02:29 AM, Linus Walleij wrote:
>>> On Thu, Jan 5, 2017 at 10:32 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
>>>
>>>> Add .gitignore for generated files.
>>>>
>>>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>>>> ---
>>>> tools/gpio/.gitignore | 4 ++++
>>>> 1 file changed, 4 insertions(+)
>>>> create mode 100644 tools/gpio/.gitignore
>>>>
>>>> diff --git a/tools/gpio/.gitignore b/tools/gpio/.gitignore
>>>> new file mode 100644
>>>> index 0000000..767ad24
>>>> --- /dev/null
>>>> +++ b/tools/gpio/.gitignore
>>>> @@ -0,0 +1,4 @@
>>>> +gpio-event-mon
>>>> +gpio-hammer
>>>> +lsgpio
>>>> +include
>>>
>>> I understand the first three.
>>>
>>> But "include"?
>>> How did you produce that?
>>>
>>> Yours,
>>> Linus Walleij
>>>
>>
>> I saw this after building selftests. gpio selftests Makefile installs
>> headres. "make kselftest" should reproduce the problem. This following
>> does an header install from tools/testing/selftests/gpio/Makefile
>>
>> ../../../../usr/include/linux/gpio.h:
>> make -C ../../../.. headers_install INSTALL_HDR_PATH=$(shell pwd)/../../../../usr/
>
> That seems like a bug.
>
> I applied the patch removing the ignore line for include,
> I think we should see this until we figured out what we do wrong.
>
> Yours,
> Linus Walleij
>
Sounds good.
thanks,
-- Shuah
prev parent reply other threads:[~2017-01-11 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 21:32 [PATCH] selftests: gpio add .gitignore for generated files Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: ipc add missing generated file to .gitignore Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: x86 protection_keys fix unused variable compile warnings Shuah Khan
2017-01-05 21:32 ` [PATCH] selftests: x86 protection_keys remove dead code Shuah Khan
2017-01-05 21:32 ` [PATCH] tools: gpio add .gitignore for generated files Shuah Khan
2017-01-10 9:29 ` Linus Walleij
2017-01-10 14:07 ` Shuah Khan
2017-01-11 15:19 ` Linus Walleij
2017-01-11 16:02 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01c9c75-d8af-0c88-9538-cdeed1f01097@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).