From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: deduplicate print_prefix() calls
Date: Mon, 26 Nov 2018 19:21:13 +0900 [thread overview]
Message-ID: <d01dbc9d-494c-79e2-0d16-918f56d0e285@i-love.sakura.ne.jp> (raw)
In-Reply-To: <20181126075626.GA5481@jagdpanzerIV>
On 2018/11/26 16:56, Sergey Senozhatsky wrote:
> Or we can "copy" the value of printk_time and use it in print_prefix(),
> and we will pick up an updated value next time we do msg_print_text()?
Yes, that is also possible. But it would be better to pass as a function
argument to print_prefix() rather than adding a global variable, and omit
calling print_time() if the passed argument is false. But however, removing
print_prefix() reduces object size, for it eliminates redundant instructions.
next prev parent reply other threads:[~2018-11-26 10:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 10:50 [PATCH] printk: don't unconditionally shortcut print_time() Tetsuo Handa
2018-11-24 14:28 ` [PATCH] printk: deduplicate print_prefix() calls Tetsuo Handa
2018-11-26 7:56 ` Sergey Senozhatsky
2018-11-26 10:21 ` Tetsuo Handa [this message]
2018-11-29 14:35 ` Petr Mladek
2018-11-29 14:19 ` [PATCH] printk: don't unconditionally shortcut print_time() Petr Mladek
2018-11-30 2:26 ` Tetsuo Handa
2018-11-30 12:30 ` Petr Mladek
2018-11-30 14:33 ` Tetsuo Handa
2018-12-01 11:30 ` Tetsuo Handa
2018-12-02 5:02 ` Tetsuo Handa
2018-12-03 13:16 ` Petr Mladek
2018-12-04 2:56 ` Sergey Senozhatsky
2018-12-04 10:06 ` Tetsuo Handa
2018-12-04 10:59 ` Sergey Senozhatsky
2018-12-03 14:14 ` Petr Mladek
2018-12-03 15:00 ` Tetsuo Handa
2018-11-30 4:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01dbc9d-494c-79e2-0d16-918f56d0e285@i-love.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).