From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E203C433B4 for ; Wed, 12 May 2021 03:11:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AE9061920 for ; Wed, 12 May 2021 03:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbhELDMK (ORCPT ); Tue, 11 May 2021 23:12:10 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2056 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229951AbhELDMI (ORCPT ); Tue, 11 May 2021 23:12:08 -0400 Received: from dggemx753-chm.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Fg07S59LVzWf2b; Wed, 12 May 2021 11:06:44 +0800 (CST) Received: from [10.136.110.154] (10.136.110.154) by dggemx753-chm.china.huawei.com (10.0.44.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 12 May 2021 11:10:59 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: avoid swapon failure by giving a warning first From: Chao Yu To: Jaegeuk Kim , , CC: kernel test robot References: <20210511214337.2857522-1-jaegeuk@kernel.org> <925bff47-de32-76b8-041d-0aad4fec0d54@huawei.com> Message-ID: Date: Wed, 12 May 2021 11:10:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <925bff47-de32-76b8-041d-0aad4fec0d54@huawei.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.110.154] X-ClientProxiedBy: dggemx704-chm.china.huawei.com (10.1.199.51) To dggemx753-chm.china.huawei.com (10.0.44.37) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/12 9:28, Chao Yu wrote: > On 2021/5/12 5:43, Jaegeuk Kim wrote: >> The final solution can be migrating blocks to form a section-aligned file >> internally. Meanwhile, let's ask users to do that when preparing the swap >> file initially like: >> 1) create() >> 2) ioctl(F2FS_IOC_SET_PIN_FILE) >> 3) fallocate() > > Let me take a look how to migrate unaligned swapfile during swapon(). :) > >> >> Reported-by: kernel test robot >> Fixes: 36e4d95891ed ("f2fs: check if swapfile is section-alligned") >> Signed-off-by: Jaegeuk Kim > > Reviewed-by: Chao Yu Wait, shouldn't this cover check_swap_activate_fast() as well? Thanks, > > Thanks, > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel > . >