From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89258C433E0 for ; Wed, 27 Jan 2021 10:42:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3637D205F4 for ; Wed, 27 Jan 2021 10:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236027AbhA0KmC (ORCPT ); Wed, 27 Jan 2021 05:42:02 -0500 Received: from mx2.suse.de ([195.135.220.15]:34804 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236028AbhA0KjA (ORCPT ); Wed, 27 Jan 2021 05:39:00 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3E383AD57; Wed, 27 Jan 2021 10:38:18 +0000 (UTC) Subject: Re: [PATCH 0/2] introduce DUMP_PREFIX_UNHASHED for hex dumps To: Petr Mladek , Steven Rostedt Cc: Timur Tabi , Sergey Senozhatsky , Matthew Wilcox , Andrew Morton , linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, roman.fietze@magna.com, keescook@chromium.org, John Ogness , linux-mm@kvack.org, Akinobu Mita References: <20210119014725.GH2260413@casper.infradead.org> <09c70d6b-c989-ca23-7ee8-b404bb0490f0@suse.cz> <083dd940-60c1-4cc8-fc89-8815b253d5c5@suse.cz> <20210126123912.23a5c3a1@gandalf.local.home> <20210126124032.0915f408@gandalf.local.home> From: Vlastimil Babka Message-ID: Date: Wed, 27 Jan 2021 11:38:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/27/21 11:11 AM, Petr Mladek wrote: > On Tue 2021-01-26 12:40:32, Steven Rostedt wrote: >> On Tue, 26 Jan 2021 12:39:12 -0500 >> Steven Rostedt wrote: >> >> > On Tue, 26 Jan 2021 11:30:02 -0600 >> > Timur Tabi wrote: >> > >> > > On 1/26/21 11:14 AM, Vlastimil Babka wrote: >> > > > If it was a boot option, I would personally be for leaving hashing enabled by >> > > > default, with opt-in boot option to disable it. >> > > >> > > A boot option would solve all my problems. I wouldn't need to recompile >> > > the kernel, and it would apply to all variations of printk. >> > >> > Should it be called "make-printk-insecure" > > Nit: This makes me feel that printk() might break (block) the system. > Please, make it more clear that it is about unveiling some secret > information, something like: > > "non-secret-printk" > "non-confidental-printk" > "unretricted-printk" > > I do not mind about the words order or using the > "make-printk-non-secret" form. Yeah, let's not be overly dramatic here. >> And even if we make this a boot time option, perhaps we should still >> include that nasty dmesg notice, which will let people know that the kernel >> has unhashed values. > > +1 If it's what it takes to have that option, fine :) > Best Regards, > Petr >