From: Liam Merwick <liam.merwick@oracle.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Lendacky <thomas.lendacky@amd.com>,
Brijesh Singh <brijesh.singh@amd.com>,
Liam Merwick <liam.merwick@oracle.com>
Subject: Re: [PATCH 0/9] KVM: SVM: Fix and clean up "can emulate" mess
Date: Thu, 20 Jan 2022 16:58:07 +0000 [thread overview]
Message-ID: <d02e3982-b34c-c529-11b5-4c788af480d2@oracle.com> (raw)
In-Reply-To: <20220120010719.711476-1-seanjc@google.com>
On 20/01/2022 01:07, Sean Christopherson wrote:
> Revert an amusing/embarassing goof reported by Liam Merwick, where KVM
> attempts to determine if RIP is backed by a valid memslot without first
> translating RIP to its associated GPA/GFN. Fix the underlying bug that
> was "fixed" by the misguided memslots check by (a) never rejecting
> emulation for !SEV guests and (b) using the #NPF error code to determine
> if the fault happened on the code fetch or on guest page tables, which is
> effectively what the memslots check attempted to do.
>
> Further clean up, harden, and document SVM's "can emulate" helper, and
> fix a #GP interception SEV bug found in the process of doing so.
FYI: I've applied all 9 commits to a 5.15 based branch (applied cleanly)
and the 3 stable candidates to a 5.4 based branch (applied with minor
contextual conflicts) and have been running my SEV test case (sysbench)
and kvm-unit-tests without issues for a number of hours now.
Regards,
Liam
>
> Sean Christopherson (9):
> KVM: SVM: Never reject emulation due to SMAP errata for !SEV guests
> Revert "KVM: SVM: avoid infinite loop on NPF from bad address"
> KVM: SVM: Don't intercept #GP for SEV guests
> KVM: SVM: Explicitly require DECODEASSISTS to enable SEV support
> KVM: x86: Pass emulation type to can_emulate_instruction()
> KVM: SVM: WARN if KVM attempts emulation on #UD or #GP for SEV guests
> KVM: SVM: Inject #UD on attempted emulation for SEV guest w/o insn
> buffer
> KVM: SVM: Don't apply SEV+SMAP workaround on code fetch or PT access
> KVM: SVM: Don't kill SEV guest if SMAP erratum triggers in usermode
>
> arch/x86/include/asm/kvm_host.h | 3 +-
> arch/x86/kvm/svm/sev.c | 9 +-
> arch/x86/kvm/svm/svm.c | 162 ++++++++++++++++++++++----------
> arch/x86/kvm/vmx/vmx.c | 7 +-
> arch/x86/kvm/x86.c | 11 ++-
> virt/kvm/kvm_main.c | 1 -
> 6 files changed, 135 insertions(+), 58 deletions(-)
>
>
> base-commit: edb9e50dbe18394d0fc9d0494f5b6046fc912d33
next prev parent reply other threads:[~2022-01-20 16:58 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 1:07 [PATCH 0/9] KVM: SVM: Fix and clean up "can emulate" mess Sean Christopherson
2022-01-20 1:07 ` [PATCH 1/9] KVM: SVM: Never reject emulation due to SMAP errata for !SEV guests Sean Christopherson
2022-01-20 14:16 ` Liam Merwick
2022-01-20 1:07 ` [PATCH 2/9] Revert "KVM: SVM: avoid infinite loop on NPF from bad address" Sean Christopherson
2022-01-20 14:17 ` Liam Merwick
2022-01-20 1:07 ` [PATCH 3/9] KVM: SVM: Don't intercept #GP for SEV guests Sean Christopherson
2022-01-20 14:30 ` Liam Merwick
2022-01-20 16:55 ` Sean Christopherson
2022-01-20 1:07 ` [PATCH 4/9] KVM: SVM: Explicitly require DECODEASSISTS to enable SEV support Sean Christopherson
2022-01-20 14:32 ` Liam Merwick
2022-01-20 1:07 ` [PATCH 5/9] KVM: x86: Pass emulation type to can_emulate_instruction() Sean Christopherson
2022-01-20 14:38 ` Liam Merwick
2022-01-20 1:07 ` [PATCH 6/9] KVM: SVM: WARN if KVM attempts emulation on #UD or #GP for SEV guests Sean Christopherson
2022-01-20 15:44 ` Liam Merwick
2022-01-20 17:04 ` Sean Christopherson
2022-01-25 14:56 ` Paolo Bonzini
2022-01-20 1:07 ` [PATCH 7/9] KVM: SVM: Inject #UD on attempted emulation for SEV guest w/o insn buffer Sean Christopherson
2022-01-20 16:11 ` Liam Merwick
2022-01-20 1:07 ` [PATCH 8/9] KVM: SVM: Don't apply SEV+SMAP workaround on code fetch or PT access Sean Christopherson
2022-01-20 16:37 ` Liam Merwick
2022-01-20 1:07 ` [PATCH 9/9] KVM: SVM: Don't kill SEV guest if SMAP erratum triggers in usermode Sean Christopherson
2022-01-20 16:46 ` Liam Merwick
2022-01-20 16:58 ` Liam Merwick [this message]
2022-01-21 8:30 ` [PATCH 0/9] KVM: SVM: Fix and clean up "can emulate" mess Liam Merwick
2022-01-25 14:52 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02e3982-b34c-c529-11b5-4c788af480d2@oracle.com \
--to=liam.merwick@oracle.com \
--cc=brijesh.singh@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).