From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E9FC3A5A6 for ; Tue, 27 Aug 2019 00:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D99620850 for ; Tue, 27 Aug 2019 00:08:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RX9x+6Dt" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727754AbfH0AIO (ORCPT ); Mon, 26 Aug 2019 20:08:14 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43263 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726441AbfH0AIO (ORCPT ); Mon, 26 Aug 2019 20:08:14 -0400 Received: by mail-pg1-f196.google.com with SMTP id k3so11546097pgb.10; Mon, 26 Aug 2019 17:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=op+KI7TlBsB6S6sFewOJ0t706uisxtkweddZPva/XUs=; b=RX9x+6DtGafaHO1iuCX95LpTQasZh6Epfv1c1WbVTDYTdGMgc1MTuuAunpoIXNNQhd dyvTNYlk5n1nkTqY721ASC09AaF3Jd2PeyOINmfcUce/x/U0YrVO2OGxhy1eJkkIdVcy TrypAKXyYIZgYBYIgWvMufNafmydykIbS4ktkSRekVFf1BscbukfP/gaj1ctYHrHIdI/ W2Mu0iyEX6/umnjyUCn9Ad/wL0b0RAXM5UjjCAMWeg1lV/NxmqX4SSqS6TOZJnhVTtps aBxZY57njSC06peMlK8cO24ROLSbspHwy4OMMx2ogZIgS5YEKWUSUpoc/lhDEs5fUsfy oF8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=op+KI7TlBsB6S6sFewOJ0t706uisxtkweddZPva/XUs=; b=dGN1RwPGW0ZZ6Z/3Xodq/LbksOlDLCJGVXP2EMQLik5UoFvp5fv/NYWKvnfaxOT31e C/eqswk1ttqqrsVi1Y8V8mTtFY5ZqWkUQ0pExNkSR0ML2HUgyPjgmeJy0WvYsj+5OH74 UM4vX9yYc01JbzvNmg1dgxippFnLdcRSIFgZc97OnvuHtiXECp5m3QMQmY2QIvvDtjVq 4G2adFp6gwlUmwFn+VZI4tz5qhRHQWf6lEhm6V0sEVq1x8l+NGFxJgemc5l1TA39LapH pn4xNo7kyuWiaWFgeMIxOavOJiY9rmJ5Iui1S6YilPADT+n9UeNSDCkbD7erqGO8CEwA 6AKA== X-Gm-Message-State: APjAAAX5d3x4/uke9q5awvBLOzOsb4KETHGX0KtI+2IWy9t7wEZBxZox 953OifCcssBV9G08TCojd64zOUcv X-Google-Smtp-Source: APXvYqyCOpJkfY8Cd0SdDE6aYRxO1Pg9WhbY61Aef8FokG+LaTjhPfxqLF8Bp0gzFOPMpKEYS54c7Q== X-Received: by 2002:a62:7789:: with SMTP id s131mr23022125pfc.50.1566864493131; Mon, 26 Aug 2019 17:08:13 -0700 (PDT) Received: from server.roeck-us.net (108-223-40-66.lightspeed.sntcca.sbcglobal.net. [108.223.40.66]) by smtp.gmail.com with ESMTPSA id b126sm17923109pfb.110.2019.08.26.17.08.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Aug 2019 17:08:12 -0700 (PDT) Subject: Re: [PATCH v2 4/4] dt-bindings/watchdog: Add access_cs0 option for alt-boot To: Andrew Jeffery , Ivan Mikhaylov , Wim Van Sebroeck Cc: Joel Stanley , linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, Alexander Amelkin , openbmc@lists.ozlabs.org, Rob Herring , Mark Rutland , devicetree@vger.kernel.org References: <20190826104636.19324-1-i.mikhaylov@yadro.com> <20190826104636.19324-5-i.mikhaylov@yadro.com> From: Guenter Roeck Message-ID: Date: Mon, 26 Aug 2019 17:08:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/26/19 4:57 PM, Andrew Jeffery wrote: > > > On Mon, 26 Aug 2019, at 20:17, Ivan Mikhaylov wrote: >> The option for the ast2400/2500 to get access to CS0 at runtime. >> >> Signed-off-by: Ivan Mikhaylov >> --- >> Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> index c5077a1f5cb3..023a9b578df6 100644 >> --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt >> @@ -34,6 +34,13 @@ Optional properties: >> engine is responsible for this. >> >> - aspeed,alt-boot: If property is present then boot from alternate >> block. >> + At alternate side 'access_cs0' sysfs file >> provides: > > Why are we talking about sysfs in the devicetree binding? This patch > doesn't seem right to me. > Correct; this is the wrong document. The attribute also will need to be better explained. "At alternate side" does not explain (at least not at all clearly enough) that the attribute only exists if the system has booted from the alternate flash / block. > Also if we're not supporting the aspeed,alt-boot property we should > probably document it as deprecated rather than making it disappear, > unless you're going to fix the systems that are using it. > Sorry, you lost me here. Where is it made to disappear ? Guenter