From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948063AbdEZPtQ (ORCPT ); Fri, 26 May 2017 11:49:16 -0400 Received: from mail-sn1nam01on0079.outbound.protection.outlook.com ([104.47.32.79]:11440 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1948073AbdEZPrr (ORCPT ); Fri, 26 May 2017 11:47:47 -0400 Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH v5 31/32] x86: Add sysfs support for Secure Memory Encryption To: , Dave Young , Borislav Petkov References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> <20170418212212.10190.73484.stgit@tlendack-t1.amdoffice.net> <20170518170153.eqiyat5s6q3yeejl@pd.tnic> <20170526024933.GA3228@dhcp-128-65.nay.redhat.com> <5927B767.3010701@redhat.com> CC: , Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , , , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , , , Jonathan Corbet , Joerg Roedel , , , Ingo Molnar , Andrey Ryabinin , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Andy Lutomirski , Thomas Gleixner , Dmitry Vyukov , , , , "Michael S. Tsirkin" , Paolo Bonzini From: Tom Lendacky Message-ID: Date: Fri, 26 May 2017 10:47:39 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <5927B767.3010701@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: CY4PR12CA0030.namprd12.prod.outlook.com (10.175.82.144) To CY4PR12MB1142.namprd12.prod.outlook.com (10.168.163.150) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PR12MB1142: X-MS-Office365-Filtering-Correlation-Id: 10a4058c-ccc0-472e-f430-08d4a44e8c8f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081)(201703131423075)(201703031133081);SRVR:CY4PR12MB1142; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;3:6jowg+DQ6NmdWSsE3NiVVeuEVPnuqJH8DrdcpN6BlJUnDOBcP44pKqtoQjnDkacowr8WUBLed/XpqJmu0VJWk84FsCZ0jkegOXeS/OjkMhWi+rVdmb5qU6amqO1RrbWcyeQW8APT+hC3ANBPFpiG4c3IyweSSLoz+GtSwgyTxq0rZ1KRBBvJKD1vrgHnqB4hqpuIYFfTLP6AuDy08e2dC7BseGRYB3OedJx0K9LIINVeI8Uy6xAIRNQu/f15EByWCW37+ZrKv0bd8rHmyoIch5A+Yg/uRxGVYHbBvtt8JeqgKfCdzq5+jto+p6TQoLoOaeb/jA0lLUkSiLzthYPSE64nzmJZtF2PBGovlBxYk9U=;25:3rGNLZzKnbA1vWEzoYEOLInWd/8IPFOIWTGL7d8bk7bI+t14PmK5krIjt3w6p+H9QM/CPlQB2oUmWEfPZmmHU2zYEuFCGxG/baQP0/y6FCOUqkX+/T1ZPKSIWVmxv9vmfvLjaJZZJJIZqq9hGYVeEWVSw39sMbKsX0iZRnWGVgUWk5qQesAqQvj7YLuB/MIAUeUtkPEMXz6rNm7fRX7yD2mnm4upQWcXguPY6yJ8/g0N5G32DGC+SRmdVvXvM1Vw94DzMZa7h4WZE1yU64CTTZ8UubVe8xC40WdKhaal9M3BK882uNFDe+0wwckPzoSKDiTHoDB7Ool3D/NLPFAx8dXYVurLfWL6uh8IAyj1IpWpfKrn4l5JAmK2NuKbp8FJc4RiguYhYTm2KLCXAlLcYkNvDoYcZ+MXkwY2sNYY8u3Yc4BZfHpNYMN5NAMS6n4VfkjORxIbewvlUf/KDYVYD4PrUuS014aqk+Jr9luiuTU= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;31:trCQ6gf/JcACCgX7qlOl+iAflBhaBZMqMlN0+WHPvGjBO7l878HnHmSQan++r215JpNOzOCXhwxA+QYrkdBXUOqbZxuVQaIiUocB+jqFCRiuhaXuH2FmVfn2jm6iAPR/+SHWIpuZWFVhEl+0PuUusCwu/AybFCm/Yck6/rPeDouQ3LKTGeDVNfs8QT8Mr+oDI/9d6bK0Yzmy7lU1UAeUHmXpYFnqUpCZVuQf+oWq1YA=;20:CoCYNZbghRlbYK2qZR/XR8Gz/ZOlf4xJMYjZd+WuS08PLJACjSDTfwvepW78a00ld/HrmhaxhlZWJupzGmunV421yVFf4bujIJSpVnhBnC4bbcwNskQNphThPK9WHsrKCsP7v9ejC/MoJFNCsgXG3r/Uaf5hQNGGpbCheg2/r13CPMK2j0P2ze/p8Zw8EuFFKtwCf4/eytar7AyEA39Bb/XEGtzFbrXMmiaYMfSRV9PMK8TF/oDERm1x+IznRyMo16+oh8apt53m2latDJdLertuaubMMSAtQQRT7YDA/Jzo0n0T4I7+ApotIhUUwdRJFwp0ztLgmc82Xasy/58u6FiKHOZ/Ua+24X+1kq43zc0/7y96PbrRUveOjcoZTmvBS5aJdjtbP9yR2O90EpjX82dNwQ4F3xJLxf79AWdWP0Qth8i5MJWx8+uI4CECKNKuj2KO2/TUTW3IkTLpcx8IS8CTK7DtdIc6IBvuO81Nx6R0l6ONQUn+KjfqrhGjWQvu X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(100405760836317); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123562025)(20161123564025)(20161123558100)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148);SRVR:CY4PR12MB1142;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1142; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;4:+AEXSrkLBD77OFO6R+/QqYA0gWLY11Ph/4EafqWebgx5LhLfYLXxHPdoKSoBVs1r3ofXTFrbHcmdoP0i0yQcI7FfWX4aP3Fx6lcQetSUndJiKAN48q8Bgh/Ln6U/82OqddU5YWTOcamgw/OiLlmftgQ8CSr52QoViShkI6ZjEULQTadMDmUGUHS5LneSG5tHpdRAiNp4LfcG+1W7SQwCKfDuGaixmHejV4aEUzeI33EOi6tV2lnilnkvPReZEVhtdo5XYFuN/7EpyZzlHarOMWey5kKqb6bVlVA6ORB3QgCjEf0raOWfcoHrcEUOASV7QuNx/AbliZm4GUvFwuUuJA+TUeIZrIjWHb14Gw6RkRoNduqmilJhyvuboxXQqVUR1LcCiBHs2wXXLB06H9zw8nBsYAycwuVRKLkiEsxnkNtIKz6Y0hYBGULal+cCJsZDNx4iC6nBtuaRomOanWVwK35hAD4jY8TWEDUpnSDCvlABcHQ4xbueIDDMPVlykOdbM/bNXUdfn0jVvWZ3oSyxrek4Vx/HV+ZqNsGl2/74i2LOt8cjUYJ319Jjqhb6zlo2mlYRiRDzhr8NlMb57MkzOApRo+lFafIQqTtvm1OfMajhzTBPTsURHncElDMOWKBSU3NcldXBRjk34m77VInGVWWCptot/DCYU7XEqFBXR7IDkPXO7PPHBhDvHZyUhUoAnvEEiaAqThBlxcfL9IfhqRIN0OPpKTi5FelG783DXdcZLrcjAv93zyLfBxlkMggyuaUn6rOndn/z1K/yJ8+1S12ed2imnNGiDc9x+/1mIrYpIcPaqcOgQkj2RybJLcCQLbz6KiR2e18//Pgbt9Y687enc/65Z6XSemlCVsxyhKs= X-Forefront-PRVS: 031996B7EF X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39860400002)(39840400002)(39400400002)(39850400002)(39450400003)(39410400002)(24454002)(377454003)(53936002)(6666003)(81166006)(93886004)(23746002)(2906002)(229853002)(2950100002)(25786009)(3260700006)(36756003)(31696002)(189998001)(86362001)(4001350100001)(72206003)(53546009)(230700001)(8676002)(6116002)(47776003)(7416002)(5660300001)(66066001)(7406005)(3846002)(38730400002)(65956001)(76176999)(90366009)(4326008)(33646002)(65806001)(64126003)(478600001)(6486002)(50466002)(77096006)(42186005)(6246003)(31686004)(54906002)(54356999)(305945005)(50986999)(83506001)(7736002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1142;H:[10.236.64.250];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR12MB1142;23:fPXXqdSlRFavcjeFWR6tBCg+P13wjRDsreFzq?= =?Windows-1252?Q?tN9CsXQwX4fSVJ1c58LxON4Yu55l/slqqcqKoAGvBjIRDdvG9eA8D8v9?= =?Windows-1252?Q?ZFxWfrcw1T8QNorZ218chH5qAUeejCdzBTxw+HGlDg+FF0XXsRudFh1Z?= =?Windows-1252?Q?l4iPnu58qSeh2gxLFdBYSd+vEZFHozJoCMPXVwVkFxkNFs3ObhjVysK2?= =?Windows-1252?Q?pxs2+xVMQCfWe9X/6OyJLGhpi4bHzgtLMJbB1hSVTFUcF0HZjUQuSD35?= =?Windows-1252?Q?lt1hot08xtmLvSSM62bsO09TIdzFYnvzSs9PiIXja821NESbOeqBlz/E?= =?Windows-1252?Q?g7MG9Qbnf3mvDa+QXIyPB2CEmkQeXYs3dty1k+nqqhhu2WOsN08CW0wf?= =?Windows-1252?Q?usGELJfBJlx7+rNU/U64Rqtydi5d+AE08PO+8ulx0w5eynCwXRqyW4S4?= =?Windows-1252?Q?kaCETyK+qWZqvj1yIS+5dLlAxOI/J5QkZyZxQauoz1AKPZUMurAHKc5e?= =?Windows-1252?Q?jVbENq2CmZdGYZZx+ftetJqLzIjHEUVlNk6Lt7h42pmsrvWfssGMqfNH?= =?Windows-1252?Q?W1ZR/XH771PLntzq9noX0fcJxFjwCPRWjMKfiTHFvKPMMgmANOt9PgUJ?= =?Windows-1252?Q?jMKnSqW/XbQYmiAQa7OBeyBCN50z+d2Dmi13z9v6IEPDgRBhYmK7KLz5?= =?Windows-1252?Q?lQgbD/R6oZJdvTPZ0v6hzHjGfLfjQXSkA1ec4N/Z6Io84Se+1caWTrDB?= =?Windows-1252?Q?D6os4MkaXu7tz8dKfb9EAVBv5TNWdNva0JjdKST9P37tuZrpqv+w7xEt?= =?Windows-1252?Q?19NoDUzNHk+rRogA8pOlvrbQIAFuboQ9r2nEIDYWfIwG0dJyptX2ud54?= =?Windows-1252?Q?U3I7+TMj7wbOtlTl0r3zhJqaCYAinrc0akOS72+GHlIXA8p266RuZzxg?= =?Windows-1252?Q?9+/LFfpEp/MUAiFP11RKYog44Yemg2FJKh9CJcRk3R5BE3G6F9lCrxk1?= =?Windows-1252?Q?4BDB7D6tptcKSk1CXU+AVh5MOJX0k4HCQduniSWwhB/u9gkdiBRSYPZz?= =?Windows-1252?Q?3NrK4UPuFERA5tGpoGYdGjnieFgpH/p15vA33tNUXJ0XUzna5kt6xmLP?= =?Windows-1252?Q?XBhall0YpfMBnOOpy8cqXsZ+B6lrRX1gtQR9XbH2vc/+UkVJpK3Oy7bZ?= =?Windows-1252?Q?XsnMbwItce63cX+vdfDTcZ7zaaXEcJ7nZ5C8WLTuW6ZaFvz6LPXHsfiT?= =?Windows-1252?Q?SIZa7cV53+CzIGXS3HBhSmY4QWNW7Dlp5FiOR81EQfBdng9lPdYJTQ+H?= =?Windows-1252?Q?c0U6KkHPNRhklVmkDSV/1Xha9UrVVuAOqAV4vQGUDRMphASbAmvj7PLv?= =?Windows-1252?Q?zYODkd2FnAYbiaijHYjjIiCsRf6NLyNatCCtlYaCTfI/kW3WXKHiLz9q?= =?Windows-1252?Q?8CMZxG31IKZBGK9h7EUJqpcyiKpJ83XCMXtV4kPtEOxox4Vypy6V2Neu?= =?Windows-1252?Q?bm0Ca4AQZt0h6amdBqr1jRZi5DMMsEBymYP+J8KKv0H/LOYvw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;6:j379Gaj7WZOpx1LLLF8w5Uu785AE/icVxDElNNm8xJ+IZtlFoEaxyNhzl0vaCr8tTDJ+3akrF+VL11588LG4TecfTxmkwU0wNMPSduk0VLaR6NCqzpHEnp3ZhxpB7ousFcjASwJ0cH1US91iR3R51Tzv8rUOlPKkz1uCV0WnDszN3ORXho1bUGxFrgBhlEYRYRPZMduHOzXu/Z4fSs2rVwuxOXhBEHpgNWhBqbwYRYGqESda35Y0LPEaSMQ8UPI/nTPN4le1Y+8yStVv7VIKMN/UFOgk4GyZ7AYKVR9arBEFlNT4gC5HTwQzNDCrl6g3vlS6q/sKIJdnHi5aaZvSvGbUgOv8fW5bWPRn/pJGVguEmrLJiHnIlENFcLV0DYYNpUYI9MYAKx0zj6cp+Ts+v/FFyRSlLFZ0BnZhFCcKciLVDkYPHk66ICaQ1u6OyWp/BhAjOXr3hA8d3LBTLkSO5Mbx3BmdBE4KS2udjw5mDie9zoVcvSZJPtCuW3ejIq30J7Ml5A+8VLusXTCwjPuYjeIMWG8HeDn/rWfmKWZgcKE=;5:yRWCpVHX7wiavQn1EZOhslITfPa0Hia1suGy5Eusds33dZ4t9kvZrLUnSnBdsk0OH1CdF9f5bOZPuTaQz6uZ1MBXfVK9xQDI1s6O0hS8dWSNvWRVoPX8RSLeTKhMHiX0SgV1JlYI1wx/LVk7zyimyQ==;24:VB/xEmbM06S72Zx2Fv591/UdPfTc/YqoM0Yrh2Glfv2MXTw0q6QEUyrxicnwHMFg038yl3bTcadufcEf7otpHakoD1Qfje60ZV+jaj20Ans= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1142;7:+owDrhpe3d5LBNKErXPVokgm18zSxbFybviNGgDwTJ2D6XujvoWrRMjcA1YBQ/601zIzgkRtG+CgLxfZEbGxDxXZ7ZOiFN4PT5fpiZhOaXMlLv9uUAGew+G78/cBF0UvQC/O+5Kpj35nYE/TnMYV0oHkttu9phoON8Uisl1/MkLBraXYQmZ10f8Ed7VlMkm8v7c0dhRYmHfyvAnuDYGRtHxIONd5SgvkL6JYdAGFscCU2rBOo85m3oHiXXRjZUXZe2pYxOu9LjBP9v3RvjTxZHC425Y+odnP0X6Vyoh3M29hsTvez0LVLtQx9E5ZF8hYNSJmB9Wio0PXgR+RqSEORg==;20:IiYvkzj42whRXz4+rEWXveIP3kEsrl7IiygPCJi60MSyFDS2BErVQ48ufnHiMX9MYSs/uds9/F0TtH2As3dqcCUnGkKKEB5BzhVEwLboiQkG9MfYWI1/KwzZVqgPOlASdf/c9Xw4v9z/DXSaVVQOX7XlVbU2m5god7Nq6Wqw9EVdBXjO2HFXeorhNsSQFYtG9a3+5tmJpEXQmWL/ewTmnrub/yePXuhPYiSIM+0GY108qMkHlzoIC5dToyiiTR1I X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2017 15:47:42.1096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1142 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/2017 12:04 AM, Xunlei Pang wrote: > On 05/26/2017 at 10:49 AM, Dave Young wrote: >> Ccing Xunlei he is reading the patches see what need to be done for >> kdump. There should still be several places to handle to make kdump work. >> >> On 05/18/17 at 07:01pm, Borislav Petkov wrote: >>> On Tue, Apr 18, 2017 at 04:22:12PM -0500, Tom Lendacky wrote: >>>> Add sysfs support for SME so that user-space utilities (kdump, etc.) can >>>> determine if SME is active. >>> But why do user-space tools need to know that? >>> >>> I mean, when we load the kdump kernel, we do it with the first kernel, >>> with the kexec_load() syscall, AFAICT. And that code does a lot of >>> things during that init, like machine_kexec_prepare()->init_pgtable() to >>> prepare the ident mapping of the second kernel, for example. >>> >>> What I'm aiming at is that the first kernel knows *exactly* whether SME >>> is enabled or not and doesn't need to tell the second one through some >>> sysfs entries - it can do that during loading. >>> >>> So I don't think we need any userspace things at all... >> If kdump kernel can get the SME status from hardware register then this >> should be not necessary and this patch can be dropped. > > Yes, I also agree with dropping this one. Consensus is to drop, so it will be. Thanks, Tom > > Regards, > Xunlei >