From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756565AbcIRGLL (ORCPT ); Sun, 18 Sep 2016 02:11:11 -0400 Received: from mout.web.de ([212.227.15.4]:63022 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753885AbcIRGLH (ORCPT ); Sun, 18 Sep 2016 02:11:07 -0400 Subject: [PATCH 01/] firewire-net: Use kmalloc_array() in fwnet_broadcast_start() To: linux1394-devel@lists.sourceforge.net, Stefan Richter References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Sun, 18 Sep 2016 08:10:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:z56ekGMW+l0kJQsb/QyVi5OQk4Qat2T/6BhCarFrsMru3uVDGAi pzyNRHzc5S5Xn9YR7jVk4S+lHgYK98WwYHyMHNB1Hmakh+hVxqwzCxJqReBgcsyf7tpf5Zr wz7Nem5cN3u8SPdVtDlysETihS3+b35Nj43J9Cux837jzMEFGb2PLMWT0+5fL7uzJSYnJ3C +oJuJeMofYUwgVXa2gb7Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:+GVPDaGlnRs=:T4D67atPnCJcgWUtkx0tiQ gTrSselTm8/dDq1eyX87uALJmnxs+Ppdw0bH+FmMHsghl9agB4cvGMjCPIHyI8CjOi5fcLyG7 Rugh8HAzAHEHaZVLYk7vSg3PH+KVJP68pJtw4M9XKSLT/opLrqysys5x4yg3XZtZ6ww6Us8z5 xAtTbnywgoce4EqORd4lCHEI72MT5JWvO2V8OaWDvNJOJnZkFiBTeJOPz78+wo0kqeKMy0uF+ UGfLk+NpfR3f7JVbXR5JZfBKCfLpxoxlacZuM7P1mNSEzIxCx2xgnDCUgTbtmk3OW9lj8hDhw 4gSAbbEgh121w+AqcwWKVK42/YaKYpPFy9Z2LQ9VJ2HHB9SpELXp+RfrcjvYG6VkD3Yq+KCMg Ra17awvAVdQzB7C6cHE+c1Ty2Vs57vupxE1w1VEXfGz+2T4B4KsOUC6GjYS9HQ/5gx6fyXpLI fc564dA80HEeomNnobmUCZGmKKuBsRK4yaWxNY3myzBE2jn23oHuL99+1c51Ouf7dBOj4C8hv 6EaH57rroFHN8n6OXk9I9ABsjA37GA4racUBVUxA7kyvNsB2Ypmuwxola6CMm2eqMkk5Txdc0 AGDXbO3hauYkPPRZ2cDMbZ6rnpQNqa37pg9m/xR4EF/pRAvHxmeHR/RAHDs/wWwsVosUrVQL7 7CbQU7eQhUPNLqKj7PG2CHacK1xwXDmNryipCJNmHzIn8T+8BMvZcVcTeUUEKQcXHAOWRksIx MdyDUFVeW/JkRH3Yah8gobge32vAtLsaPEpLbQbqjIj+namAzEfs3jwq44c+2lNKr3DaculQv sSXNmn7 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 17 Sep 2016 21:55:42 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data type by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/firewire/net.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index 309311b..7911f13 100644 --- a/drivers/firewire/net.c +++ b/drivers/firewire/net.c @@ -1103,8 +1103,7 @@ static int fwnet_broadcast_start(struct fwnet_device *dev) max_receive = 1U << (dev->card->max_receive + 1); num_packets = (FWNET_ISO_PAGE_COUNT * PAGE_SIZE) / max_receive; - - ptrptr = kmalloc(sizeof(void *) * num_packets, GFP_KERNEL); + ptrptr = kmalloc_array(num_packets, sizeof(*ptrptr), GFP_KERNEL); if (!ptrptr) { retval = -ENOMEM; goto failed; -- 2.10.0