From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbdF3Vhr (ORCPT ); Fri, 30 Jun 2017 17:37:47 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:33524 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753111AbdF3Vhq (ORCPT ); Fri, 30 Jun 2017 17:37:46 -0400 Subject: Re: [PATCH v2] pata_imx: print error message on platform_get_irq failure To: "Gustavo A. R. Silva" , Bartlomiej Zolnierkiewicz , Tejun Heo References: <20170630213056.GA12695@embeddedgus> Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: Date: Sat, 1 Jul 2017 00:37:36 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170630213056.GA12695@embeddedgus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2017 12:30 AM, Gustavo A. R. Silva wrote: > Print error message on platform_get_irq failure before return. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > Print the return value of platform_get_irq on failure. > > drivers/ata/pata_imx.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c > index d4caa23..66fb1ab 100644 > --- a/drivers/ata/pata_imx.c > +++ b/drivers/ata/pata_imx.c > @@ -132,9 +132,10 @@ static int pata_imx_probe(struct platform_device *pdev) > int ret; > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) > + if (irq < 0) { > + dev_err(&pdev->dev, "failed to get IRQ: %d\n", irq); > return irq; > - > + } Removing empty line here doesn't seem a good idea... > priv = devm_kzalloc(&pdev->dev, > sizeof(struct pata_imx_priv), GFP_KERNEL); > if (!priv) MBR, Sergei