From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932471AbeCOOsR (ORCPT ); Thu, 15 Mar 2018 10:48:17 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:43502 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752311AbeCOOsM (ORCPT ); Thu, 15 Mar 2018 10:48:12 -0400 Subject: Re: [PATCH v3 01/14] KVM: s390: refactor crypto initialization To: Pierre Morel , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: freude@de.ibm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com, pbonzini@redhat.com, alex.williamson@redhat.com, alifm@linux.vnet.ibm.com, mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com, thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com, fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com References: <1521051954-25715-1-git-send-email-akrowiak@linux.vnet.ibm.com> <1521051954-25715-2-git-send-email-akrowiak@linux.vnet.ibm.com> From: Tony Krowiak Date: Thu, 15 Mar 2018 10:48:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-TM-AS-GCONF: 00 x-cbid: 18031514-0024-0000-0000-000018155DB9 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008679; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000254; SDB=6.01003432; UDB=6.00510667; IPR=6.00782759; MB=3.00020051; MTD=3.00000008; XFM=3.00000015; UTC=2018-03-15 14:48:09 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18031514-0025-0000-0000-00004F1D8533 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-03-15_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1803150164 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/15/2018 08:26 AM, Pierre Morel wrote: > On 14/03/2018 19:25, Tony Krowiak wrote: >> This patch refactors the code that initializes the crypto >> configuration for a guest. The crypto configuration is contained in >> a crypto control block (CRYCB) which is a satellite control block to >> our main hardware virtualization control block. The CRYCB is >> attached to the main virtualization control block via a CRYCB >> designation (CRYCBD) designation field containing the address of >> the CRYCB as well as its format. >> >> Prior to the introduction of AP device virtualization, there was >> no need to provide access to or specify the format of the CRYCB for >> a guest unless the MSA extension 3 (MSAX3) facility was installed >> on the host system. With the introduction of AP device virtualization, >> the CRYCB and its format must be made accessible to the guest >> regardless of the presence of the MSAX3 facility. >> >> The crypto initialization code is restructured as follows: >> >> * A new compilation unit is introduced to contain all interfaces >> and data structures related to configuring a guest's CRYCB for >> both the refactoring of crypto initialization as well as all >> subsequent patches introducing AP virtualization support. >> >> * Currently, the asm code for querying the AP configuration is >> duplicated in the AP bus as well as in KVM. Since the KVM >> code was introduced, the AP bus has externalized the interface >> for querying the AP configuration. The KVM interface will be >> replaced with a call to the AP bus interface. Of course, this >> will be moved to the new compilation unit mentioned above. >> >> * An interface to format the CRYCBD field will be provided via >> the new compilation unit and called from the KVM vm >> initialization. >> >> Signed-off-by: Tony Krowiak >> --- >> MAINTAINERS | 10 ++++++ >> arch/s390/include/asm/kvm-ap.h | 16 ++++++++++ >> arch/s390/include/asm/kvm_host.h | 1 + >> arch/s390/kvm/Kconfig | 1 + >> arch/s390/kvm/Makefile | 2 +- >> arch/s390/kvm/kvm-ap.c | 48 +++++++++++++++++++++++++++++ >> arch/s390/kvm/kvm-s390.c | 61 >> ++++--------------------------------- >> 7 files changed, 84 insertions(+), 55 deletions(-) >> create mode 100644 arch/s390/include/asm/kvm-ap.h >> create mode 100644 arch/s390/kvm/kvm-ap.c >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 0ec5881..72742d5 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -11875,6 +11875,16 @@ W: >> http://www.ibm.com/developerworks/linux/linux390/ >> S: Supported >> F: drivers/s390/crypto/ >> >> +S390 VFIO AP DRIVER >> +M: Tony Krowiak >> +M: Christian Borntraeger >> +M: Martin Schwidefsky >> +L: linux-s390@vger.kernel.org >> +W: http://www.ibm.com/developerworks/linux/linux390/ >> +S: Supported >> +F: arch/s390/include/asm/kvm/kvm-ap.h >> +F: arch/s390/kvm/kvm-ap.c >> + >> S390 ZFCP DRIVER >> M: Steffen Maier >> M: Benjamin Block >> diff --git a/arch/s390/include/asm/kvm-ap.h >> b/arch/s390/include/asm/kvm-ap.h >> new file mode 100644 >> index 0000000..362846c >> --- /dev/null >> +++ b/arch/s390/include/asm/kvm-ap.h >> @@ -0,0 +1,16 @@ >> +/* >> + * Adjunct Processor (AP) configuration management for KVM guests >> + * >> + * Copyright IBM Corp. 2017 >> + * >> + * Author(s): Tony Krowiak >> + */ >> + >> +#ifndef _ASM_KVM_AP >> +#define _ASM_KVM_AP >> +#include >> +#include >> + >> +void kvm_ap_build_crycbd(struct kvm *kvm); >> + >> +#endif /* _ASM_KVM_AP */ >> diff --git a/arch/s390/include/asm/kvm_host.h >> b/arch/s390/include/asm/kvm_host.h >> index 34c9b5b..65a944e 100644 >> --- a/arch/s390/include/asm/kvm_host.h >> +++ b/arch/s390/include/asm/kvm_host.h >> @@ -257,6 +257,7 @@ struct kvm_s390_sie_block { >> __u8 reservedf0[12]; /* 0x00f0 */ >> #define CRYCB_FORMAT1 0x00000001 >> #define CRYCB_FORMAT2 0x00000003 >> +#define CRYCB_FORMAT_MASK 0x00000003 >> __u32 crycbd; /* 0x00fc */ >> __u64 gcr[16]; /* 0x0100 */ >> __u64 gbea; /* 0x0180 */ >> diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig >> index a3dbd45..4ca9077 100644 >> --- a/arch/s390/kvm/Kconfig >> +++ b/arch/s390/kvm/Kconfig >> @@ -33,6 +33,7 @@ config KVM >> select HAVE_KVM_INVALID_WAKEUPS >> select SRCU >> select KVM_VFIO >> + select ZCRYPT > > I do not think it is a good solution to *always* enable ZCRYPT > when we have KVM. If CONFIG_ZCRYPT is not selected, then the kvm_ap_apxa_installed() function will not compile because it calls a zcrypt interface. How would you suggest we make sure zcrypt interfaces used in KVM are built if CONFIG_ZCRYPT is not selected? > > Pierre > >