From: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: outreachy@lists.linux.dev, parthiban.veerasooran@microchip.com,
christian.gromm@microchip.com, drv@mailo.com, dave@stgolabs.net,
yang.lee@linux.alibaba.com, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] staging: most: use inline functions for iface_to_hdm
Date: Mon, 20 Mar 2023 20:26:22 +0200 [thread overview]
Message-ID: <d0ba154b-c975-574e-657e-c9c7098231af@gmail.com> (raw)
In-Reply-To: <ZBh/Yw49fubf1GDb@kroah.com>
On ٢٠/٣/٢٠٢٣ ١٧:٤٤, Greg KH wrote:
> On Mon, Mar 20, 2023 at 12:33:35PM +0200, Menna Mahmoud wrote:
>> Convert `iface_to_hdm` macro into a static inline function.
>> it is not great to have macro that use `container_of` macro,
>> because from looking at the definition one cannot tell
>> what type it applies to.
>>
>> One can get the same benefit from an efficiency point of view
>> by making an inline function.
>>
>> Suggested-by: Julia Lawall <julia.lawall@inria.fr>
>> Signed-off-by: Menna Mahmoud <eng.mennamahmoud.mm@gmail.com>
>> ---
>> drivers/staging/most/dim2/dim2.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
> Your subject line has a " " when it should have just a " " :(
I see, I will fix it.
>
> Please fix up and send a v2.
I will.
>
> thanks,
>
> greg k-h
Thanks,
Menna
prev parent reply other threads:[~2023-03-20 18:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 10:33 [PATCH] staging: most: use inline functions for iface_to_hdm Menna Mahmoud
2023-03-20 15:44 ` Greg KH
2023-03-20 18:26 ` Menna Mahmoud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ba154b-c975-574e-657e-c9c7098231af@gmail.com \
--to=eng.mennamahmoud.mm@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=dave@stgolabs.net \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=parthiban.veerasooran@microchip.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).