From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: Mike Christie <michael.christie@oracle.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: John Youn <John.Youn@synopsys.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v2 2/4] target: Implement TMR_ABORT_TASK_SET
Date: Tue, 19 Jul 2022 23:05:45 +0000 [thread overview]
Message-ID: <d0bfb66f-1934-c9a2-524e-0f0665cb7d2f@synopsys.com> (raw)
In-Reply-To: <74bf1df3-a466-9d78-1a25-7425c89b9fa3@oracle.com>
On 7/19/2022, Mike Christie wrote:
> On 7/18/22 9:07 PM, Thinh Nguyen wrote:
>> Task ABORT TASK SET function is required by SCSI transport protocol
> What OS is using this and how do they use it? For the latter, does the
> OS try an abort for each cmd first, then try an abort task set if the
> aborts fail (does fail mean get a response that indicates failure and
> also does a timeout count)? Or does it start with the abort task set?
It's not from any real driver. It's from the USB Compliant Verification
(https://www.usb.org/document-library/usb3cv). It uses the command for
UASP compliant test.
The test only ever aborts a single command at a time, so I can't confirm
your following questions. The SAM4-r14 wasn't clear on those questions
either.
> I'm asking because it looks like if it does an abort first, then the
> abort task set will always return TMR_TASK_DOES_NOT_EXIST. For the abort
> we will remove the cmds from the state_list so if the abort task set runs
> after the initiator has tried to abort all the commands it will never
> find any.
I didn't notice since I dropped a patch where I removed the
TMR_TASK_DOES_NOT_EXIST and UASP converts this to RC_TMF_COMPLETE. UASP
respond to FUNCTION COMPLETE with RC_TMF_COMPLETE. I'll can make a fix
to that.
If there's any suggestion to implement this, please advise.
Thanks,
Thinh
>> standards (SAM-4 r14 section 7.3). It is similar to ABORT TASK
>> function, but it applies to all commands received on a specified I_T
>> nexus rather than a specific referenced command. Modify
>> core_tmr_abort_task() to support TMR_ABORT_TASK_SET.
>>
next prev parent reply other threads:[~2022-07-19 23:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-19 2:06 [PATCH v2 0/4] target: Updates related to UASP Thinh Nguyen
2022-07-19 2:07 ` [PATCH v2 2/4] target: Implement TMR_ABORT_TASK_SET Thinh Nguyen
2022-07-19 15:56 ` Mike Christie
2022-07-19 23:05 ` Thinh Nguyen [this message]
2022-07-20 15:41 ` Konstantin Shelekhin
2022-07-19 2:07 ` [PATCH v2 3/4] target: Properly set Sense Data Length of CHECK CONDITION Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0bfb66f-1934-c9a2-524e-0f0665cb7d2f@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=John.Youn@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).