From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
<jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <dmurphy@ti.com>,
<robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH v2] dt-bindings: leds: Document commonly used LED triggers
Date: Sun, 13 Dec 2020 11:03:22 +0800 [thread overview]
Message-ID: <d0f81c59-384e-482d-ff1d-6bea55792589@huawei.com> (raw)
In-Reply-To: <ba1d261c-3ce9-1511-2677-29274f5ee170@huawei.com>
On 2020/12/13 10:39, Leizhen (ThunderTown) wrote:
>
>
> On 2020/12/10 16:24, Manivannan Sadhasivam wrote:
>> This commit documents the LED triggers used commonly in the SoCs. Not
>> all triggers are documented as some of them are very application specific.
>> Most of the triggers documented here are currently used in devicetrees
>> of many SoCs.
>>
>> While at it, let's also sort the triggers in ascending order.
>>
>> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>> ---
>>
>> Changes in v2:
>>
>> * Added more triggers, fixed the regex
>> * Sorted triggers in ascending order
>>
>> .../devicetree/bindings/leds/common.yaml | 78 ++++++++++++++-----
>> 1 file changed, 60 insertions(+), 18 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
>> index f1211e7045f1..3c2e2208c1da 100644
>> --- a/Documentation/devicetree/bindings/leds/common.yaml
>> +++ b/Documentation/devicetree/bindings/leds/common.yaml
>> @@ -79,24 +79,66 @@ properties:
>> the LED.
>> $ref: /schemas/types.yaml#definitions/string
>>
>> - enum:
>> - # LED will act as a back-light, controlled by the framebuffer system
>> - - backlight
>> - # LED will turn on (but for leds-gpio see "default-state" property in
>> - # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
>> - - default-on
>> - # LED "double" flashes at a load average based rate
>> - - heartbeat
>> - # LED indicates disk activity
>> - - disk-activity
>> - # LED indicates IDE disk activity (deprecated), in new implementations
>> - # use "disk-activity"
>> - - ide-disk
>> - # LED flashes at a fixed, configurable rate
>> - - timer
>> - # LED alters the brightness for the specified duration with one software
>> - # timer (requires "led-pattern" property)
>> - - pattern
>> + oneOf:
>> + - items:
>> + - enum:
>> + # LED indicates mic mute state
>> + - audio-micmute
>> + # LED indicates audio mute state
>> + - audio-mute
>> + # LED will act as a back-light, controlled by the framebuffer system
>> + - backlight
>> + # LED indicates bluetooth power state
>> + - bluetooth-power
>> + # LED indicates activity of all CPUs
>> + - cpu
>> + # LED will turn on (but for leds-gpio see "default-state" property in
>> + # Documentation/devicetree/bindings/leds/leds-gpio.yaml)
>> + - default-on
>> + # LED indicates disk activity
>> + - disk-activity
>> + # LED indicates disk read activity
>> + - disk-read
>> + # LED indicates disk write activity
>> + - disk-write
>> + # LED indicates camera flash state
>> + - flash
>> + # LED "double" flashes at a load average based rate
>> + - heartbeat
>> + # LED indicates IDE disk activity (deprecated), in new implementations
>> + # use "disk-activity"
>> + - ide-disk
>> + # LED indicates MTD memory activity
>> + - mtd
>> + # LED indicates NAND memory activity (deprecated),
>> + # in new implementations use "mtd"
>> + - nand-disk
>> + # No trigger assigned to the LED. This is the default mode
>> + # if trigger is absent
>> + - none
>> + # LED alters the brightness for the specified duration with one software
>> + # timer (requires "led-pattern" property)
>> + - pattern
>> + # LED flashes at a fixed, configurable rate
>> + - timer
>> + # LED indicates camera torch state
>> + - torch
>> + # LED indicates USB gadget activity
>> + - usb-gadget
>> + # LED indicates USB host activity
>> + - usb-host
>> + - items:
>> + # LED indicates activity of [N]th CPU
>> + - pattern: "^cpu[0-9]{1,2}$"
>> + - items:
>> + # LED indicates power status of [N]th Bluetooth HCI device
>> + - pattern: "^hci[0-9]{1,2}-power$"
>> + - items:
>> + # LED indicates [N]th MMC storage activity
>> + - pattern: "^mmc[0-9]{1,2}$"
>> + - items:
>> + # LED indicates [N]th WLAN Tx activity
>> + - pattern: "^phy[0-9]{1,2}tx$"
>
> Only the last three are not listed:
> phy0rx
> ir-power-click
> ir-user-click
I don't know if you're familiar with these two triggers. You can also
consider leaving it to the owner of the corresponding module to update.
Because I just found out there are a lot of unlisted triggers on arm32.
>
> And the first one is easily supported by:
> - # LED indicates [N]th WLAN Tx activity
> - - pattern: "^phy[0-9]{1,2}tx$"
> + # LED indicates [N]th WLAN Tx/Rx activity
> + - pattern: "^phy[0-9]{1,2}(tx|rx)$"
>
> Tested-by: Zhen Lei <thunder.leizhen@huawei.com>
>
>>
>> led-pattern:
>> description: |
>>
next prev parent reply other threads:[~2020-12-13 3:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 8:24 [PATCH v2] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2020-12-13 2:39 ` Leizhen (ThunderTown)
2020-12-13 3:03 ` Leizhen (ThunderTown) [this message]
2020-12-14 22:36 ` Rob Herring
2020-12-30 19:20 ` Pavel Machek
2021-01-27 1:38 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0f81c59-384e-482d-ff1d-6bea55792589@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).