From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luca Weiss <luca.weiss@fairphone.com>, linux-arm-msm@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] dt-bindings: interconnect: qcom: Reuse new rpmh-common bindings
Date: Fri, 20 May 2022 12:33:48 +0200 [thread overview]
Message-ID: <d1072c55-9e1c-83df-0184-7405448bbade@linaro.org> (raw)
In-Reply-To: <20220520070318.48521-4-luca.weiss@fairphone.com>
On 20/05/2022 09:03, Luca Weiss wrote:
> Stop defining the properties twice and use the ones provided in the new
> qcom,rpmh-common.yaml.
>
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> Changes since v1:
> * New patch
>
> .../bindings/interconnect/qcom,rpmh.yaml | 22 +++++--------------
> 1 file changed, 5 insertions(+), 17 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> index fae3363fed02..e822dc099339 100644
> --- a/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh.yaml
> @@ -18,6 +18,9 @@ description: |
> least one RPMh device child node pertaining to their RSC and each provider
> can map to multiple RPMh resources.
>
> +allOf:
> + - $ref: qcom,rpmh-common.yaml#
> +
> properties:
> reg:
> maxItems: 1
> @@ -131,28 +134,13 @@ properties:
> - qcom,sm8450-pcie-anoc
> - qcom,sm8450-system-noc
>
> - '#interconnect-cells':
> - enum: [ 1, 2 ]
> -
> - qcom,bcm-voters:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> - items:
> - maxItems: 1
> - description: |
> - List of phandles to qcom,bcm-voter nodes that are required by
> - this interconnect to send RPMh commands.
> -
> - qcom,bcm-voter-names:
> - description: |
> - Names for each of the qcom,bcm-voters specified.
> + '#interconnect-cells': true
>
So this explains why your previous patch had such values... The order is
messed up - first you move common parts to common file, then you add
SM6350 support.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-20 10:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 7:03 [PATCH v2 0/5] Add interconnect support for SM6350 Luca Weiss
2022-05-20 7:03 ` [PATCH v2 1/5] interconnect: qcom: icc-rpmh: Support child NoC device probe Luca Weiss
2022-05-20 7:03 ` [PATCH v2 2/5] dt-bindings: interconnect: Add Qualcomm SM6350 NoC support Luca Weiss
2022-05-20 10:31 ` Krzysztof Kozlowski
2022-05-20 12:04 ` Luca Weiss
2022-05-20 14:24 ` Krzysztof Kozlowski
2022-05-23 14:32 ` Luca Weiss
2022-05-24 17:30 ` Krzysztof Kozlowski
2022-05-20 7:03 ` [PATCH v2 3/5] dt-bindings: interconnect: qcom: Reuse new rpmh-common bindings Luca Weiss
2022-05-20 10:33 ` Krzysztof Kozlowski [this message]
2022-05-20 11:42 ` Luca Weiss
2022-05-20 7:03 ` [PATCH v2 4/5] interconnect: qcom: Add SM6350 driver support Luca Weiss
2022-05-20 7:03 ` [PATCH v2 5/5] arm64: dts: qcom: sm6350: Add interconnect support Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1072c55-9e1c-83df-0184-7405448bbade@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=okukatla@codeaurora.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).