From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/6] RTC subsystem, class
Date: Wed, 21 Dec 2005 14:43:01 -0500 [thread overview]
Message-ID: <d120d5000512211143ge189479qf1916741479586b4@mail.gmail.com> (raw)
In-Reply-To: <20051221105001.226178f1@inspiron>
On 12/21/05, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> On Tue, 20 Dec 2005 21:01:39 -0500
> Dmitry Torokhov <dtor_core@ameritech.net> wrote:
>
>
> > > +if (ops->read_time) {
> > > +memset(tm, 0, sizeof(struct rtc_time));
> > >
> >
> > What guarantees that ops is not NULL here? Userspace can keep the
> > attribute (file) open and issue read after class_device was unregistered
> > and devdata set to NULL.
>
> Right. For /proc and /dev there's a try_module_get(ops->owner) in place.
>
> Should I add it to every rtc_sysfs_show_xxx or there's
> a better way to do it?
>
Well, I don't know what will it buy you: if ops is NULL
try_module_get(ops->owner) will OOPS just as happily as original code.
Your class_device has to hold on to all data structures that are
referenced from sysfs attributes untils its ->release() function is
called. Alternatively you could stuck a mutex and a flag somewhere in
driver data and take it when unregistering class device and also in
all attributes (and chech the flag there).
--
Dmitry
next prev parent reply other threads:[~2005-12-21 19:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-20 20:45 [RFC][PATCH 1/6] RTC subsystem, class Alessandro Zummo
2005-12-20 21:13 ` Christoph Hellwig
2005-12-20 21:23 ` Alessandro Zummo
2005-12-21 1:50 ` Mitchell Blank Jr
2005-12-21 9:30 ` Alessandro Zummo
2005-12-20 21:30 ` Russell King
2005-12-21 2:01 ` Dmitry Torokhov
2005-12-21 9:50 ` Alessandro Zummo
2005-12-21 19:43 ` Dmitry Torokhov [this message]
2005-12-21 23:10 ` Alessandro Zummo
2005-12-22 13:35 ` Pavel Machek
2005-12-26 2:47 ` Alessandro Zummo
2005-12-26 20:16 ` Pavel Machek
2005-12-27 3:16 ` Alessandro Zummo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000512211143ge189479qf1916741479586b4@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=alessandro.zummo@towertech.it \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).