From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Hanselmann <linux-kernel@hansmi.ch>,
linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz, linuxppc-dev@ozlabs.org,
linux-kernel@killerfox.forkbomb.ch,
Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks
Date: Fri, 13 Jan 2006 17:08:31 -0500 [thread overview]
Message-ID: <d120d5000601131408s41d1a60amfa31a3821019389c@mail.gmail.com> (raw)
In-Reply-To: <d120d5000601131405w4e20e37fna17767624a4ebf6@mail.gmail.com>
On 1/13/06, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> On 1/13/06, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > That should be "MODULE_PARM_DESC(pb_fn_mode, ...)". Also, since this is
> > > for compatibility with ADB, why do we have 3 options? Doesn't ADB have
> > > only 2?
> >
> > No, the ADB keyboard can operate in 2 modes that can be set with a PMU
> > command, I forgot about that in my earlier comments. In one mode, you get
> > the "special" behaviour by default on the Fx keys and you get Fx when
> > pressing Fn-Fx, and in the other mode, you get the Fx by default and the
> > special behaviour when pressing Fn-Fx.
> >
>
> Right, so do we need "no translation, fnkeyfirst and fnkeylast" option
> or just "fnkeyfirst and fnkeyast"?
>
> > > > +static inline struct hidinput_key_translation *find_translation(
> > >
> > > I thought is was agreed that we'd avoid "inlines" in .c files?
> >
> > Ah ? I have certainly missed that discussion ...
>
> Newer GCCs, unit-at-a-time, etc. etc. - teher was pretty long
> discussion about letting GCC decide on inlining.
>
> >
> > > > + struct hidinput_key_translation *table, u16 from)
> > > > +{
> > > > + struct hidinput_key_translation *trans;
> > > > +
> > > > + /* Look for the translation */
> > > > + for(trans = table; trans->from && (trans->from != from); trans++);
> > > > +
> > > > + return (trans->from?trans:NULL);
> > > > +}
> > >
> > > I'd prefer liberal amount of spaces applied here </extreme nitpick mode>
> >
> > Me too :)
> >
> > > > + try_translate = test_bit(usage->code, usbhid_pb_numlock)?1:
> > > > + test_bit(LED_NUML, input->led);
> > > > + if (try_translate) {
> > >
> > > Isn't this the same as
> > >
> > > if (test_bit(usage->code, usbhid_pb_numlock) || test_bit(LED_NUML, input->led))
> > >
> > > but harder to read?
> >
> > No. If the first one is 0, the second one will not matter in the first
> > version, while it will in yours.
> >
>
> Huh? You mean 1, right?
>
> try_translate = 0;
> if (test_bit(usage->code, usbhid_pb_numlock))
> try_translate = 1;
> else if (test_bit(LED_NUML, input->led))
> try_translate = 1;
> else
>
Uhg, accidentially hit send, sorry... Ok, nevermind, I see your other message ;)
--
Dmitry
next prev parent reply other threads:[~2006-01-13 22:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-25 21:20 [PATCH/RFC?] usb/input: Add support for fn key on Apple PowerBooks Michael Hanselmann
2005-12-25 21:57 ` Benjamin Herrenschmidt
2005-12-26 4:04 ` Dmitry Torokhov
2005-12-26 5:46 ` Benjamin Herrenschmidt
2006-01-11 21:07 ` Dmitry Torokhov
2006-01-11 21:20 ` Michael Hanselmann
2006-01-11 21:34 ` Benjamin Herrenschmidt
2006-01-11 21:38 ` Michael Hanselmann
2006-01-11 21:41 ` Benjamin Herrenschmidt
2006-01-11 21:43 ` Michael Hanselmann
2006-01-11 21:47 ` Vojtech Pavlik
2006-01-11 21:50 ` Michael Hanselmann
2006-01-11 21:54 ` Benjamin Herrenschmidt
2006-01-11 21:30 ` Benjamin Herrenschmidt
2006-01-11 21:45 ` Vojtech Pavlik
2006-01-11 21:46 ` Michael Hanselmann
2006-01-11 23:26 ` Michael Hanselmann
2006-01-11 23:41 ` Benjamin Herrenschmidt
2006-01-12 0:08 ` Michael Hanselmann
2006-01-13 4:12 ` Dmitry Torokhov
2006-01-13 6:53 ` Michael Hanselmann
2006-01-13 7:47 ` Vojtech Pavlik
2006-01-13 22:02 ` Michael Hanselmann
2006-01-14 4:58 ` Dmitry Torokhov
2006-01-14 10:41 ` Vojtech Pavlik
2006-01-14 10:57 ` Michael Hanselmann
2006-01-13 21:55 ` Benjamin Herrenschmidt
2006-01-13 21:57 ` Benjamin Herrenschmidt
2006-01-13 22:05 ` Dmitry Torokhov
2006-01-13 22:08 ` Dmitry Torokhov [this message]
2006-01-13 22:14 ` Benjamin Herrenschmidt
2006-01-13 22:25 ` Dmitry Torokhov
2006-01-12 9:07 ` Vojtech Pavlik
2006-01-12 23:39 ` Michael Hanselmann
2006-01-13 1:53 ` Benjamin Herrenschmidt
2005-12-31 23:51 ` Michael Hanselmann
2006-01-01 1:33 ` Michael Hanselmann
2006-01-01 2:56 ` Benjamin Herrenschmidt
2006-01-01 3:03 ` Michael Hanselmann
2006-01-01 6:09 ` Benjamin Herrenschmidt
2006-01-02 22:46 ` Michael Hanselmann
2006-01-03 2:29 ` Ben Collins
2006-01-03 19:14 ` Michael Hanselmann
2006-01-03 19:18 ` Ben Collins
2006-01-03 19:25 ` Michael Hanselmann
2006-01-02 12:06 ` Stelian Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d120d5000601131408s41d1a60amfa31a3821019389c@mail.gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=dtor_core@ameritech.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@killerfox.forkbomb.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).