From: Shuah Khan <skhan@linuxfoundation.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: john.stultz@linaro.org, tglx@linutronix.de, sboyd@kernel.org,
shuah@kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: timers: rtcpie: skip test if default RTC device does not exist
Date: Fri, 4 Jun 2021 15:36:12 -0600 [thread overview]
Message-ID: <d1366904-f297-e995-2a6c-42721f28bc06@linuxfoundation.org> (raw)
In-Reply-To: <20210525023614.7251-1-po-hsu.lin@canonical.com>
On 5/24/21 8:36 PM, Po-Hsu Lin wrote:
> This test will require /dev/rtc0, the default RTC device, or one
> specified by user to run. Since this default RTC is not guaranteed to
> exist on all of the devices, so check its existence first, otherwise
> skip this test with the kselftest skip code 4.
>
> Without this patch this test will fail like this on a s390x zVM:
> # selftests: timers: rtcpie
> # /dev/rtc0: No such file or directory
> not ok 1 selftests: timers: rtcpie # exit=22
>
> With this patch:
> # selftests: timers: rtcpie
> # Default RTC /dev/rtc0 does not exist. Test Skipped!
> not ok 9 selftests: timers: rtcpie # SKIP
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
Thank you for the patch. Will pick this up for 5.14
thanks,
-- Shuah
prev parent reply other threads:[~2021-06-04 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 2:36 [PATCH] selftests: timers: rtcpie: skip test if default RTC device does not exist Po-Hsu Lin
2021-06-04 21:36 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1366904-f297-e995-2a6c-42721f28bc06@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=po-hsu.lin@canonical.com \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).