From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CC71ECE58D for ; Sat, 5 Oct 2019 14:04:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DED50222CA for ; Sat, 5 Oct 2019 14:04:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="o19Ecgek" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727466AbfJEOEt (ORCPT ); Sat, 5 Oct 2019 10:04:49 -0400 Received: from mout.web.de ([212.227.15.4]:60395 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbfJEOEs (ORCPT ); Sat, 5 Oct 2019 10:04:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1570284251; bh=yU952EgA76+1w3jlwz/sumRdXN+HoC5Bxy+AmRv95+o=; h=X-UI-Sender-Class:Cc:References:Subject:To:From:Date:In-Reply-To; b=o19EcgekqyfW5/C7YiaUIjG6oxyd9XdP3J5V9tczIzoak+qHxYFMxaP079FSFVaGb vyK2zY1Lx/sh3hoWh9K8HXl8h666Kxvx0juon7/nVmpE+Ah7+dmB0ISgSKGmumDG0i TlvZaOQba2m2t22Jlunt6/cqIRe/GGOEvdiVzBRE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([93.135.178.111]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0Lcgp5-1hs6ph3jbL-00k5uy; Sat, 05 Oct 2019 16:04:11 +0200 Cc: Navid Emamdoost , Kangjie Lu , Stephen McCamant , Brian Norris , David Woodhouse , Kyungmin Park , Marek Vasut , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191004171909.6378-1-navid.emamdoost@gmail.com> Subject: Re: [PATCH v2] mtd: onenand: prevent memory leak in onenand_scan To: Navid Emamdoost , linux-mtd@lists.infradead.org From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Sat, 5 Oct 2019 16:04:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191004171909.6378-1-navid.emamdoost@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:FkskqHrQv+ChCOFRBvXSqr/LIQNCCcSFDX0jYWFMitIhRKRX9kX GoDxQAOYmvt1mg/yOdd2OSQR59MjF1fI7AWsEZC2YJ3U2Vkg6rhEXqzfk4UXfQrg28qcJ1o nihrO+OSeNrQeOubwOL7Q0uagHc9X3Y9hyLU9ql3U4ufczlDe2fxxOgXohWV9SupDcJU+CZ qiknTVuuq6F2k6ldeIN7w== X-UI-Out-Filterresults: notjunk:1;V03:K0:/9QwR6ExVMU=:/deUgzO9xlTfD3I/KeeQax h3XU4t0S2Yemc8r2kfmQVi31hpf8fAMF+lCJ7YXHFEIAtKDQF7qasKoClzCRnalY40XvpS5ur bsHu9O20/JzRvKJr/xRzkJG3HtUmpnLyRxmSkm13bl7sOBVQuliNSKBs/wnYHAzLMQLuGJTnR XYcxCSvx6swOsKFDLQc0IUx4NlUb0Ath6j/rTV+HZJglk16lYYo6bwbUTiWokpWcgYlAM877a 8YT2Hb3XB1aGgEp0qFNe6prYstYbJd/p6y+g7JTV6h76C06kqBC9XPOSoDGJRyrvUgIyGGg8J qdCpzuSm8FQ8SFB3LlxrhAUL7VIyurBl5JZ6hkKV3JyyvMTfd/pGAihnTkj/79c8fuzS5uAph 2+vMnbBalZBHCg4AZu5BskRG6erbFGfZcn+/+9r/vM2woGGiI+JTKBxrlQ8k0vs50pU1+viIB TB8SUwiCLIJAEp2Y0qHTqRFJk+W9uoEVho0VTZ7Ts9IkTonzl7cWNfuvsCyB78WMmgrdASKFo NjSj/1KxkzE81HCG1THwe3mrMxIRSO/fVy+QfqGy1Tcad3UUYw6mNsVVKEXHVEESkfPubKVhu z1P+/d25Vc0MF2yi1BDII63pazYr1+l0od6JVshlLWzMem80Son0SglDlNz63NPa6OzuvI7UT 4CFhObQbZSbNqJlMCBBq/KC5omuePXEyrbSYFMWY2/j9C4a3VT9KkByfMlAq4PmKomMQlHhLW ep9qWnZ5hcHBe7CSh2CjMeDcqTD5+AMm22vVXNh1dlhFSpX0l8wKz3iTUlVaYYu2mkRFk4Emd ckwMPkFWJ9KPwFcUkJRykoKCejlDWxLl162ifjEeybAxaqjMopeIOIPAMARgNVorGbuZFQhcQ ECdppQ5ZwILLOkABM7glvtzhXl3h/Z7bMa/80HCk6xD5Xv+gu1i+G+qAVT49jRPcsgWTjydyI hst22IE41aQgO1degSmwGNyRByP1/M/WT6VaS0BZ//e2NjTziQfQGL9QvGj5Y5tICmToBX1d4 gDKBUXKSHsHkcqmHUIemf7azWmkE4RSSYmGbhEayjImaGODv3tddgpnOwOn6iH3w8NlH00i1e F6Ldq/gyCyoni3hBFH4RfM9V1VEZQjBZMHcSGc/2yaFEfFeDyHYL+bnE0XGRL8AMDomkv7Fop o4cXttqRBTPrBHt0t1jWofEv0FpNO34HXMN7KwyG77lvHOuiCX2xtB8w8R8QZpZJV4N/5TlYi UbBQznSsC9AaZycgJ2exDc/1dSblAmfNMEq/2TI6iEx9DFaJUDMTZspFLE3g= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > In onenand_scan if scan_bbt fails the allocated buffers for oob_buf, > verify_buf, and page_buf should be released. Can a wording like the following be nicer for the change description? Release the memory for the buffers =E2=80=9Coob_buf=E2=80=9D, =E2=80=9Cv= erify_buf=E2=80=9D and =E2=80=9Cpage_buf=E2=80=9D after a call of the function =E2=80=9Cscan_bbt=E2=80=9D failed in the im= plementation of the function =E2=80=9Conenand_scan=E2=80=9D. > Fixes: 5988af231978 ("mtd: Flex-OneNAND support") =E2=80=A6 > --- > Changes in v2: =E2=80=A6 > for the hint). Did you take another review comment into account for this patch change log= ? > --- Please replace the delimiter at this place by a blank line in subsequent m= essages. > drivers/mtd/nand/onenand/onenand_base.c | 8 +++++++- =E2=80=A6 Regards, Markus