From: David Laight <David.Laight@ACULAB.COM>
To: "'Valentin Vidić'" <vvidic@valentin-vidic.from.hr>,
"Al Viro" <viro@zeniv.linux.org.uk>
Cc: Valdis Kletnieks <valdis.kletnieks@vt.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] staging: exfat: cleanup braces for if/else statements
Date: Wed, 4 Sep 2019 09:38:55 +0000 [thread overview]
Message-ID: <d14cda319c584db9b8aa35b15b542f89@AcuMS.aculab.com> (raw)
In-Reply-To: <20190903181208.GA8469@valentin-vidic.from.hr>
From: Valentin Vidic
> Sent: 03 September 2019 19:12
> On Tue, Sep 03, 2019 at 06:32:49PM +0100, Al Viro wrote:
> > On Tue, Sep 03, 2019 at 06:47:32PM +0200, Valentin Vidic wrote:
> > > + } else if (uni == 0xFFFF) {
> > > skip = TRUE;
> >
> > While we are at it, could you get rid of that 'TRUE' macro?
>
> Sure, but maybe in a separate patch since TRUE/FALSE has more
> calls than just this.
I bet you can get rid of the 'skip' variable and simplify the code
by using continue/break/return (or maybe goto).
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-09-04 9:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 16:47 [PATCH] staging: exfat: cleanup braces for if/else statements Valentin Vidic
2019-09-03 17:32 ` Al Viro
2019-09-03 18:12 ` Valentin Vidić
2019-09-04 9:38 ` David Laight [this message]
2019-09-04 17:05 ` Valentin Vidić
2019-09-03 18:19 ` Greg Kroah-Hartman
2019-09-03 18:55 ` [PATCH] staging: exfat: drop local TRUE/FALSE defines Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d14cda319c584db9b8aa35b15b542f89@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=vvidic@valentin-vidic.from.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).