Re: [PULL] bcache: multiple updates

Re: [PULL] bcache: multiple updates

[Eric Wheeler]

On Thu, 27 Oct 2016, Jens Axboe wrote:

> On 10/27/2016 05:27 PM, Eric Wheeler wrote:
> > Hi Jens,
> >
> > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3:
> > (You may disregard the previous -rc1-based request.)
> >
> >   git pull https://bitbucket.org/ewheelerinc/linux.git
> >   v4.9-rc2-bcache-updates
> >
> > Thank you!
> >
> > --
> > Eric Wheeler
> >
> > ]# git log --oneline v4.9-rc2..HEAD
> > bd532a6 bcache: partition support: add 16 minors per bcacheN device
> > 3312845 bcache: Make gc wakeup sane, remove set_task_state()
> > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
> > 3d58a09 bcache: documentation for ioprio cache hinting
> > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback hints
> 
> How many of these are applicable to 4.9-rc3? I took a quick look at
> them, and some of them look like they should go into the 4.10 branch
> instead. We're after the merge window, so only strict fixes. Cleanups
> and no features, no go.

3312845 might need to be in 4.9.  Not sure, kent asked me to pick it up in 
my next pull request.  4.10 is fine for the rest.

Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?

See this thread: 
	Re: ciao set_task_state() (was Re: [PATCH -v4 6/8] locking/mutex: Restructure wait loop)
	http://www.gossamer-threads.com/lists/linux/kernel/2550193	


--
Eric Wheeler



> 
> -- 
> Jens Axboe
> 
> 
> 

Re: [PULL] bcache: multiple updates

[Davidlohr Bueso]

On Sat, 29 Oct 2016, Eric Wheeler wrote:

>Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?

No, not particularly. I can do my stuff whenever this is ends up being merged.

Thanks,
Davidlohr

Re: [PULL] bcache: multiple updates

[Kent Overstreet]

On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote:
> On Thu, 27 Oct 2016, Jens Axboe wrote:
> 
> > On 10/27/2016 05:27 PM, Eric Wheeler wrote:
> > > Hi Jens,
> > >
> > > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3:
> > > (You may disregard the previous -rc1-based request.)
> > >
> > >   git pull https://bitbucket.org/ewheelerinc/linux.git
> > >   v4.9-rc2-bcache-updates
> > >
> > > Thank you!
> > >
> > > --
> > > Eric Wheeler
> > >
> > > ]# git log --oneline v4.9-rc2..HEAD
> > > bd532a6 bcache: partition support: add 16 minors per bcacheN device
> > > 3312845 bcache: Make gc wakeup sane, remove set_task_state()
> > > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
> > > 3d58a09 bcache: documentation for ioprio cache hinting
> > > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback hints
> > 
> > How many of these are applicable to 4.9-rc3? I took a quick look at
> > them, and some of them look like they should go into the 4.10 branch
> > instead. We're after the merge window, so only strict fixes. Cleanups
> > and no features, no go.
> 
> 3312845 might need to be in 4.9.  Not sure, kent asked me to pick it up in 
> my next pull request.  4.10 is fine for the rest.
> 
> Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?

No, that can wait until 4.10.

Re: [PULL] bcache: multiple updates

[Jens Axboe]

On 10/30/2016 08:00 AM, Kent Overstreet wrote:
> On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote:
>> On Thu, 27 Oct 2016, Jens Axboe wrote:
>>
>>> On 10/27/2016 05:27 PM, Eric Wheeler wrote:
>>>> Hi Jens,
>>>>
>>>> Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3:
>>>> (You may disregard the previous -rc1-based request.)
>>>>
>>>>   git pull https://bitbucket.org/ewheelerinc/linux.git
>>>>   v4.9-rc2-bcache-updates
>>>>
>>>> Thank you!
>>>>
>>>> --
>>>> Eric Wheeler
>>>>
>>>> ]# git log --oneline v4.9-rc2..HEAD
>>>> bd532a6 bcache: partition support: add 16 minors per bcacheN device
>>>> 3312845 bcache: Make gc wakeup sane, remove set_task_state()
>>>> 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
>>>> 3d58a09 bcache: documentation for ioprio cache hinting
>>>> 2e8884b bcache: introduce per-process ioprio-based bypass/writeback hints
>>>
>>> How many of these are applicable to 4.9-rc3? I took a quick look at
>>> them, and some of them look like they should go into the 4.10 branch
>>> instead. We're after the merge window, so only strict fixes. Cleanups
>>> and no features, no go.
>>
>> 3312845 might need to be in 4.9.  Not sure, kent asked me to pick it up in
>> my next pull request.  4.10 is fine for the rest.
>>
>> Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?
>
> No, that can wait until 4.10.

Great, that's what it looked like.

Eric, three things. The first is that you based this branch as if it was
going into 4.9, which means if I pull it into my 4.10 branch, I get a
ton of extra stuff that has been added to master since. Not a huge
problem, I can just generate the patches and apply them.

Secondly, you are depending on REQ_THROTTLED, which in the 4.10 series,
has been modified:

commit 8d2bbd4c8236e9e38e6b36ac9e2c54fdcfe5b335
Author: Christoph Hellwig <hch@lst.de>
Date:   Thu Oct 20 15:12:12 2016 +0200

     block: replace REQ_THROTTLED with a bio flag

And lastly, would you mind using the regular git request-pull to
generate your pull requests? It's what everybody else is using, and
honestly I think it's a lot more readable than the oneline thing you are
doing.

Please resend the series against for-4.10/block and we can get it
applied, thanks.

-- 
Jens Axboe

Re: [PULL] bcache: multiple updates

[Eric Wheeler]

On Sun, 30 Oct 2016, Jens Axboe wrote:
> On 10/30/2016 08:00 AM, Kent Overstreet wrote:
> > On Sat, Oct 29, 2016 at 06:32:38PM -0700, Eric Wheeler wrote:
> > > On Thu, 27 Oct 2016, Jens Axboe wrote:
> > >
> > > > On 10/27/2016 05:27 PM, Eric Wheeler wrote:
> > > > > Hi Jens,
> > > > >
> > > > > Please pull this v4.9-rc2 based series of bcache updates for v4.9-rc3:
> > > > > (You may disregard the previous -rc1-based request.)
> > > > >
> > > > >   git pull https://bitbucket.org/ewheelerinc/linux.git
> > > > >   v4.9-rc2-bcache-updates
> > > > >
> > > > > Thank you!
> > > > >
> > > > > --
> > > > > Eric Wheeler
> > > > >
> > > > > ]# git log --oneline v4.9-rc2..HEAD
> > > > > bd532a6 bcache: partition support: add 16 minors per bcacheN device
> > > > > 3312845 bcache: Make gc wakeup sane, remove set_task_state()
> > > > > 6bb7f1e bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
> > > > > 3d58a09 bcache: documentation for ioprio cache hinting
> > > > > 2e8884b bcache: introduce per-process ioprio-based bypass/writeback
> > > > > hints
> > > >
> > > > How many of these are applicable to 4.9-rc3? I took a quick look at
> > > > them, and some of them look like they should go into the 4.10 branch
> > > > instead. We're after the merge window, so only strict fixes. Cleanups
> > > > and no features, no go.
> > >
> > > 3312845 might need to be in 4.9.  Not sure, kent asked me to pick it up in
> > > my next pull request.  4.10 is fine for the rest.
> > >
> > > Kent, Davidlohr, does 3312845 need to land in 4.9 for some reason?
> >
> > No, that can wait until 4.10.
> 
> Great, that's what it looked like.
> 
> Eric, three things. The first is that you based this branch as if it was
> going into 4.9, which means if I pull it into my 4.10 branch, I get a
> ton of extra stuff that has been added to master since. Not a huge
> problem, I can just generate the patches and apply them.
> 
> Secondly, you are depending on REQ_THROTTLED, which in the 4.10 series,
> has been modified:
> 
> commit 8d2bbd4c8236e9e38e6b36ac9e2c54fdcfe5b335
> Author: Christoph Hellwig <hch@lst.de>
> Date:   Thu Oct 20 15:12:12 2016 +0200
> 
>     block: replace REQ_THROTTLED with a bio flag
> 
> And lastly, would you mind using the regular git request-pull to
> generate your pull requests? It's what everybody else is using, and
> honestly I think it's a lot more readable than the oneline thing you are
> doing.
> 
> Please resend the series against for-4.10/block and we can get it
> applied, thanks.

Will do, thanks!

-Eric


--
Eric Wheeler


> 
> -- 
> Jens Axboe
> 
> 
> 

[PULL] bcache: based on for-4.10/block, multiple updates

[Eric Wheeler]

Hello Jens,

Please pull for 4.10:

Thank you!

This pull request is based on the git.kernel.dk for-4.10/block branch:

The following changes since commit 333ba053d145d6f9152f6b0311a345b876f0fed1:

  lightnvm: transform target get/set bad block (2016-11-29 12:12:51 -0700)

are available in the git repository at:

  https://bitbucket.org/ewheelerinc/linux.git for-4.10-block-bcache-updates

for you to fetch changes up to 951c0a8cc489aca1c68d80e5aaa576cd7e511191:

  bcache: partition support: add 16 minors per bcacheN device (2016-12-06 10:13:24 -0800)

----------------------------------------------------------------
Eric Wheeler (4):
      bcache: introduce per-process ioprio-based bypass/writeback hints
      bcache: documentation for ioprio cache hinting
      bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
      bcache: partition support: add 16 minors per bcacheN device

Kent Overstreet (1):
      bcache: Make gc wakeup sane, remove set_task_state()

 Documentation/bcache.txt      | 80 +++++++++++++++++++++++++++++++++++++++++++
 drivers/md/bcache/bcache.h    |  7 ++--
 drivers/md/bcache/btree.c     | 39 +++++++++++----------
 drivers/md/bcache/btree.h     |  3 +-
 drivers/md/bcache/request.c   | 31 +++++++++++++++--
 drivers/md/bcache/super.c     |  7 +++-
 drivers/md/bcache/sysfs.c     | 71 ++++++++++++++++++++++++++++++++++++++
 drivers/md/bcache/writeback.c |  8 +++++
 drivers/md/bcache/writeback.h | 27 ++++++++++++++-
 9 files changed, 245 insertions(+), 28 deletions(-)

Re: [PULL] bcache: based on for-4.10/block, multiple updates

[Eric Wheeler]

Hi Jens,

I know you're busy, so when you get a moment:

I've not yet seen your ack/nack on this yet and I want to make sure it 
gets in before the merge window closes for v4.10.  I rebased it on 
for-4.10/block as you asked so its tested and ready to go as of 12/6 
unless you see something that I've missed.

Thanks!

-Eric

--
Eric Wheeler

On Tue, 6 Dec 2016, Eric Wheeler wrote:

> Hello Jens,
> 
> Please pull for 4.10:
> 
> Thank you!
> 
> This pull request is based on the git.kernel.dk for-4.10/block branch:
> 
> The following changes since commit 333ba053d145d6f9152f6b0311a345b876f0fed1:
> 
>   lightnvm: transform target get/set bad block (2016-11-29 12:12:51 -0700)
> 
> are available in the git repository at:
> 
>   https://bitbucket.org/ewheelerinc/linux.git for-4.10-block-bcache-updates
> 
> for you to fetch changes up to 951c0a8cc489aca1c68d80e5aaa576cd7e511191:
> 
>   bcache: partition support: add 16 minors per bcacheN device (2016-12-06 10:13:24 -0800)
> 
> ----------------------------------------------------------------
> Eric Wheeler (4):
>       bcache: introduce per-process ioprio-based bypass/writeback hints
>       bcache: documentation for ioprio cache hinting
>       bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
>       bcache: partition support: add 16 minors per bcacheN device
> 
> Kent Overstreet (1):
>       bcache: Make gc wakeup sane, remove set_task_state()
> 
>  Documentation/bcache.txt      | 80 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/md/bcache/bcache.h    |  7 ++--
>  drivers/md/bcache/btree.c     | 39 +++++++++++----------
>  drivers/md/bcache/btree.h     |  3 +-
>  drivers/md/bcache/request.c   | 31 +++++++++++++++--
>  drivers/md/bcache/super.c     |  7 +++-
>  drivers/md/bcache/sysfs.c     | 71 ++++++++++++++++++++++++++++++++++++++
>  drivers/md/bcache/writeback.c |  8 +++++
>  drivers/md/bcache/writeback.h | 27 ++++++++++++++-
>  9 files changed, 245 insertions(+), 28 deletions(-)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PULL] bcache: based on for-4.10/block, multiple updates

[Jens Axboe]

On 12/14/2016 06:50 PM, Eric Wheeler wrote:
> Hi Jens,
> 
> I know you're busy, so when you get a moment:
> 
> I've not yet seen your ack/nack on this yet and I want to make sure it 
> gets in before the merge window closes for v4.10.  I rebased it on 
> for-4.10/block as you asked so its tested and ready to go as of 12/6 
> unless you see something that I've missed.

Pulled for 4.10, sorry about the delay.

-- 
Jens Axboe

Re: [PULL] bcache: based on for-4.10/block, multiple updates

[Eric Wheeler]

On Wed, 14 Dec 2016, Jens Axboe wrote:
> On 12/14/2016 06:50 PM, Eric Wheeler wrote:
> > Hi Jens,
> > 
> > I know you're busy, so when you get a moment:
> > 
> > I've not yet seen your ack/nack on this yet and I want to make sure it 
> > gets in before the merge window closes for v4.10.  I rebased it on 
> > for-4.10/block as you asked so its tested and ready to go as of 12/6 
> > unless you see something that I've missed.
> 
> Pulled for 4.10, sorry about the delay.

Hi Jens,

Looking at 4.10-rc6, I see these two commits were merged:

>       bcache: partition support: add 16 minors per bcacheN device
>       bcache: Make gc wakeup sane, remove set_task_state()

but these were in the same 'for-4.10-block-bcache-updates' and don't
appear to have been applied:

>       bcache: introduce per-process ioprio-based bypass/writeback hints
>       bcache: documentation for ioprio cache hinting
>       bcache: update bio->bi_opf bypass/writeback REQ_ flag hints

Did I miss an email that caused their exclusion?

Did these get bumped to 4.11 for some reason?

Original pull request is below for your reference.

Thank you for your help!

--
Eric Wheeler

[...] are available in the git repository at:

  https://bitbucket.org/ewheelerinc/linux.git for-4.10-block-bcache-updates

for you to fetch changes up to 951c0a8cc489aca1c68d80e5aaa576cd7e511191:

  bcache: partition support: add 16 minors per bcacheN device (2016-12-06 10:13:24 -0800)

----------------------------------------------------------------
Eric Wheeler (4):
      bcache: introduce per-process ioprio-based bypass/writeback hints
      bcache: documentation for ioprio cache hinting
      bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
      bcache: partition support: add 16 minors per bcacheN device

Kent Overstreet (1):
      bcache: Make gc wakeup sane, remove set_task_state()

 Documentation/bcache.txt      | 80 +++++++++++++++++++++++++++++++++++++++++++
 drivers/md/bcache/bcache.h    |  7 ++--
 drivers/md/bcache/btree.c     | 39 +++++++++++----------
 drivers/md/bcache/btree.h     |  3 +-
 drivers/md/bcache/request.c   | 31 +++++++++++++++--
 drivers/md/bcache/super.c     |  7 +++-
 drivers/md/bcache/sysfs.c     | 71 ++++++++++++++++++++++++++++++++++++++
 drivers/md/bcache/writeback.c |  8 +++++
 drivers/md/bcache/writeback.h | 27 ++++++++++++++-
 9 files changed, 245 insertions(+), 28 deletions(-)




> 
> -- 
> Jens Axboe
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PULL] bcache: based on for-4.10/block, multiple updates

[Jens Axboe]

On 01/31/2017 11:14 AM, Eric Wheeler wrote:
> On Wed, 14 Dec 2016, Jens Axboe wrote:
>> On 12/14/2016 06:50 PM, Eric Wheeler wrote:
>>> Hi Jens,
>>>
>>> I know you're busy, so when you get a moment:
>>>
>>> I've not yet seen your ack/nack on this yet and I want to make sure it 
>>> gets in before the merge window closes for v4.10.  I rebased it on 
>>> for-4.10/block as you asked so its tested and ready to go as of 12/6 
>>> unless you see something that I've missed.
>>
>> Pulled for 4.10, sorry about the delay.
> 
> Hi Jens,
> 
> Looking at 4.10-rc6, I see these two commits were merged:
> 
>>       bcache: partition support: add 16 minors per bcacheN device
>>       bcache: Make gc wakeup sane, remove set_task_state()
> 
> but these were in the same 'for-4.10-block-bcache-updates' and don't
> appear to have been applied:
> 
>>       bcache: introduce per-process ioprio-based bypass/writeback hints
>>       bcache: documentation for ioprio cache hinting
>>       bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
> 
> Did I miss an email that caused their exclusion?
> 
> Did these get bumped to 4.11 for some reason?

I thought I sent out that reply, maybe I didn't. I dropped the
last three for two reasons:

1) They happened after the merge window, and it's really a feature
   addon that should have gone in earlier

2) There seemed to be confusion and discussion around the interface
   that needed to be resolved first.

Hope that explains it.

-- 
Jens Axboe

Re: [PULL] bcache: based on for-4.10/block, multiple updates

[Eric Wheeler]

On Tue, 31 Jan 2017, Jens Axboe wrote:
> On 01/31/2017 11:14 AM, Eric Wheeler wrote:
> > On Wed, 14 Dec 2016, Jens Axboe wrote:
> >> On 12/14/2016 06:50 PM, Eric Wheeler wrote:
> >>> Hi Jens,
> >>>
> >>> I know you're busy, so when you get a moment:
> >>>
> >>> I've not yet seen your ack/nack on this yet and I want to make sure it 
> >>> gets in before the merge window closes for v4.10.  I rebased it on 
> >>> for-4.10/block as you asked so its tested and ready to go as of 12/6 
> >>> unless you see something that I've missed.
> >>
> >> Pulled for 4.10, sorry about the delay.
> > 
> > Hi Jens,
> > 
> > Looking at 4.10-rc6, I see these two commits were merged:
> > 
> >>       bcache: partition support: add 16 minors per bcacheN device
> >>       bcache: Make gc wakeup sane, remove set_task_state()
> > 
> > but these were in the same 'for-4.10-block-bcache-updates' and don't
> > appear to have been applied:
> > 
> >>       bcache: introduce per-process ioprio-based bypass/writeback hints
> >>       bcache: documentation for ioprio cache hinting
> >>       bcache: update bio->bi_opf bypass/writeback REQ_ flag hints
> > 
> > Did I miss an email that caused their exclusion?
> > 
> > Did these get bumped to 4.11 for some reason?
> 
> I thought I sent out that reply, maybe I didn't. I dropped the
> last three for two reasons:
> 
> 1) They happened after the merge window, and it's really a feature
>    addon that should have gone in earlier
  
Onto 4.11 then.   Hopefully this is early enough :)

> 
> 2) There seemed to be confusion and discussion around the interface
>    that needed to be resolved first.

None that I'm aware of.  This is a bcache-only feature and doesn't affect 
non-bcache users. In fact, people are using it as a patch with good 
results since they can control their erase-block churn.  Kent Overstreet 
acked it, too.

Can you pull this for 4.11?

Thank you for your help!

--
Eric Wheeler



> 
> Hope that explains it.
> 
> -- 
> Jens Axboe
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PULL] bcache: based on for-4.10/block, multiple updates

[Eric Wheeler]

On Wed, 14 Dec 2016, Jens Axboe wrote:
> On 12/14/2016 06:50 PM, Eric Wheeler wrote:
> > Hi Jens,
> > 
> > I know you're busy, so when you get a moment:
> > 
> > I've not yet seen your ack/nack on this yet and I want to make sure it 
> > gets in before the merge window closes for v4.10.  I rebased it on 
> > for-4.10/block as you asked so its tested and ready to go as of 12/6 
> > unless you see something that I've missed.
> 
> Pulled for 4.10, sorry about the delay.

Hi Jens,

Checking in:

Can you get this in for 4.11 since it was missed for 4.10 and we're not in 
4.11-rc1 yet?

Here it is again:

  https://bitbucket.org/ewheelerinc/linux.git for-4.10-block-bcache-updates


--
Eric Wheeler


> 
> -- 
> Jens Axboe
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>