From: Chao Yu <chao@kernel.org>
To: Yunlong Song <yunlong.song@huawei.com>,
jaegeuk@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com
Cc: linux-fsdevel@vger.kernel.org, miaoxie@huawei.com,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim
Date: Fri, 13 Oct 2017 20:24:15 +0800 [thread overview]
Message-ID: <d171c827-9a6d-2c45-75cb-352658f04652@kernel.org> (raw)
In-Reply-To: <ec42530e-ec96-65dd-64c3-9cc1e42d0ef7@huawei.com>
On 2017/10/13 19:20, Yunlong Song wrote:
> Yep, both are OK, since I do not care it is foreground or background. Here it just needs to do gc.
But you only set need_gc as true for foreground GC case.
Thanks,
>
> On 2017/10/13 19:09, Chao Yu wrote:
>> On 2017/10/11 21:51, Yunlong Song wrote:
>>> This can help us to debug on some corner case.
>>>
>>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>>> ---
>>> fs/f2fs/gc.c | 6 +++++-
>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>>> index 197ebf4..960503e 100644
>>> --- a/fs/f2fs/gc.c
>>> +++ b/fs/f2fs/gc.c
>>> @@ -986,6 +986,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>> .ilist = LIST_HEAD_INIT(gc_list.ilist),
>>> .iroot = RADIX_TREE_INIT(GFP_NOFS),
>>> };
>>> + bool need_gc = false;
>> How about changing variable name to need_fggc for better readability?
>>
>> Thanks,
>>
>>> trace_f2fs_gc_begin(sbi->sb, sync, background,
>>> get_pages(sbi, F2FS_DIRTY_NODES),
>>> @@ -1018,8 +1019,10 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>> if (ret)
>>> goto stop;
>>> }
>>> - if (has_not_enough_free_secs(sbi, 0, 0))
>>> + if (has_not_enough_free_secs(sbi, 0, 0)) {
>>> gc_type = FG_GC;
>>> + need_gc = true;
>>> + }
>>> }
>>> /* f2fs_balance_fs doesn't need to do BG_GC in critical path. */
>>> @@ -1028,6 +1031,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>>> goto stop;
>>> }
>>> if (!__get_victim(sbi, &segno, gc_type)) {
>>> + f2fs_bug_on(sbi, !total_freed && need_gc);
>>> ret = -ENODATA;
>>> goto stop;
>>> }
>>>
>> .
>>
>
next prev parent reply other threads:[~2017-10-13 12:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 13:51 [PATCH] f2fs: add bug_on when f2fs_gc even fails to get one victim Yunlong Song
2017-10-12 23:23 ` Jaegeuk Kim
2017-10-13 1:09 ` Yunlong Song
2017-10-13 2:29 ` Jaegeuk Kim
2017-10-13 11:09 ` [f2fs-dev] " Chao Yu
2017-10-13 11:20 ` Yunlong Song
2017-10-13 12:24 ` Chao Yu [this message]
2017-10-13 13:31 ` [PATCH v2] " Yunlong Song
2017-10-14 0:17 ` [f2fs-dev] " Chao Yu
2017-10-14 12:34 ` Yunlong Song
2017-10-16 3:25 ` Chao Yu
2017-10-31 1:32 ` Yunlong Song
2017-10-31 3:17 ` Chao Yu
2017-10-31 3:30 ` Yunlong Song
2017-11-03 3:28 ` Yunlong Song
2017-11-03 3:44 ` Jaegeuk Kim
2017-11-03 15:08 ` 宋云龙
2017-11-06 1:12 ` Yunlong Song
2017-11-07 2:38 ` Jaegeuk Kim
2017-11-07 2:40 ` Jaegeuk Kim
2017-11-07 3:16 ` Yunlong Song
2017-11-07 3:26 ` Jaegeuk Kim
2017-11-07 4:01 ` Yunlong Song
2017-11-07 6:56 ` Chao Yu
2017-11-08 3:06 ` Yunlong Song
2017-11-09 17:59 ` Jaegeuk Kim
2017-11-10 2:11 ` Yunlong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d171c827-9a6d-2c45-75cb-352658f04652@kernel.org \
--to=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=yuchao0@huawei.com \
--cc=yunlong.song@huawei.com \
--cc=yunlong.song@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).