linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: rjw@rjwysocki.net
Cc: mathieu.poirier@linaro.org, mingo@redhat.com,
	peterz@infradead.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, ulf.hansson@linaro.org
Subject: Re: [PATCH V6 1/3] cpuidle: play_idle: Make play_idle more flexible
Date: Wed, 6 Nov 2019 19:27:47 +0100	[thread overview]
Message-ID: <d185fdf8-8398-c8f5-b49a-47e5bb00607c@linaro.org> (raw)
In-Reply-To: <20191030075141.1039-1-daniel.lezcano@linaro.org>


Hi Rafael,


On 30/10/2019 08:51, Daniel Lezcano wrote:
> The play_idle function has two users, the intel powerclamp and the
> idle_injection.
> 
> The idle injection cooling device uses the function via the
> idle_injection powercap's APIs. Unfortunately, play_idle is currently
> limited by the idle state depth: by default the deepest idle state is
> selected. On the ARM[64] platforms, most of the time it is the cluster
> idle state, the exit latency and the residency can be very high. That
> reduces the scope of the idle injection usage because the impact on
> the performances can be very significant.
> 
> If the idle injection cycles can be done with a shallow state like a
> retention state, the cooling effect would eventually give similar
> results than the cpufreq cooling device.
> 
> In order to prepare the function to receive an idle state parameter,
> let's replace the 'use_deepest_state' boolean field with 'use_state'
> and use this value to enter the specific idle state.
> 
> The current code keeps the default behavior which is go to the deepest
> idle state.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Acked-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Is it possible to merge this series so I can make some progress on
upstreaming the idle cooling device which depends on these three patches?

Thanks

  -- Daniel






-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog


  parent reply	other threads:[~2019-11-06 18:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30  7:51 [PATCH V6 1/3] cpuidle: play_idle: Make play_idle more flexible Daniel Lezcano
2019-10-30  7:51 ` [PATCH V6 2/3] cpuidle: play_idle: Specify play_idle with an idle state Daniel Lezcano
2019-11-08  1:20   ` Rafael J. Wysocki
2019-11-08 10:47     ` Daniel Lezcano
2019-11-08 10:56       ` Rafael J. Wysocki
2019-11-08 13:32         ` Daniel Lezcano
2019-11-10 16:49           ` Rafael J. Wysocki
2019-11-13 12:37     ` Daniel Lezcano
2019-12-05 17:04   ` Martin Kepplinger
2019-12-05 18:02     ` Daniel Lezcano
2019-10-30  7:51 ` [PATCH V6 3/3] powercap/drivers/idle_inject: Specify the idle state to inject Daniel Lezcano
2019-11-08  1:24   ` Rafael J. Wysocki
2019-11-06 18:27 ` Daniel Lezcano [this message]
2019-11-08  0:53   ` [PATCH V6 1/3] cpuidle: play_idle: Make play_idle more flexible Rafael J. Wysocki
2019-11-08  1:03 ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d185fdf8-8398-c8f5-b49a-47e5bb00607c@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).