From: Stephen Warren <swarren@wwwdotorg.org>
To: Paul Kocialkowski <contact@paulk.fr>,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Alexandre Courbot <gnurou@gmail.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC
Date: Tue, 18 Apr 2017 10:15:45 -0600 [thread overview]
Message-ID: <d18b57d3-a44f-e44b-9bd5-526993dc91e4@wwwdotorg.org> (raw)
In-Reply-To: <20170418151159.31843-1-contact@paulk.fr>
On 04/18/2017 09:11 AM, Paul Kocialkowski wrote:
> This selects the tegra30 i2s and ahub controllers for the tegra124 SoC.
> These are needed when building without ARCH_TEGRA_3x_SOC set.
> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index efbe8d4c019e..bcd18d2cf7a7 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF
>
> config SND_SOC_TEGRA30_AHUB
> tristate
> - depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC
> + depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || ARCH_TEGRA_124_SOC)
Is this really a compile-time dependency? If so, don't we need to add
T210 and T186 entries into that || condition too, since we could be
building a kernel with just T210/T186 support and no T124 support?
next prev parent reply other threads:[~2017-04-18 16:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 15:11 [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC Paul Kocialkowski
2017-04-18 16:15 ` Stephen Warren [this message]
2017-04-18 16:38 ` Paul Kocialkowski
2017-04-19 22:00 ` Stephen Warren
2017-04-24 15:07 ` Paul Kocialkowski
2017-04-24 15:35 ` Stephen Warren
2017-04-24 18:41 ` Paul Kocialkowski
2017-04-25 16:57 ` Stephen Warren
2017-05-07 18:12 ` Paul Kocialkowski
2017-05-08 15:58 ` Stephen Warren
2017-05-31 16:59 ` Paul Kocialkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d18b57d3-a44f-e44b-9bd5-526993dc91e4@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=contact@paulk.fr \
--cc=gnurou@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).