From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757508AbdDRQY5 (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Apr 2017 12:24:57 -0400
Received: from avon.wwwdotorg.org ([70.85.31.133]:58458 "EHLO
        avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756106AbdDRQYx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Apr 2017 12:24:53 -0400
X-Greylist: delayed 535 seconds by postgrey-1.27 at vger.kernel.org; Tue, 18 Apr 2017 12:24:53 EDT
Subject: Re: [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for
 tegra124 SoC
To: Paul Kocialkowski <contact@paulk.fr>, linux-kernel@vger.kernel.org,
        Thierry Reding <thierry.reding@gmail.com>
References: <20170418151159.31843-1-contact@paulk.fr>
Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        Alexandre Courbot <gnurou@gmail.com>,
        Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Rob Herring <robh@kernel.org>
From: Stephen Warren <swarren@wwwdotorg.org>
Message-ID: <d18b57d3-a44f-e44b-9bd5-526993dc91e4@wwwdotorg.org>
Date: Tue, 18 Apr 2017 10:15:45 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <20170418151159.31843-1-contact@paulk.fr>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/18/2017 09:11 AM, Paul Kocialkowski wrote:
> This selects the tegra30 i2s and ahub controllers for the tegra124 SoC.
> These are needed when building without ARCH_TEGRA_3x_SOC set.

> diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig
> index efbe8d4c019e..bcd18d2cf7a7 100644
> --- a/sound/soc/tegra/Kconfig
> +++ b/sound/soc/tegra/Kconfig
> @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF
>
>  config SND_SOC_TEGRA30_AHUB
>  	tristate
> -	depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC
> +	depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || ARCH_TEGRA_124_SOC)

Is this really a compile-time dependency? If so, don't we need to add 
T210 and T186 entries into that || condition too, since we could be 
building a kernel with just T210/T186 support and no T124 support?