From: Stefan Schmidt <stefan@osg.samsung.com>
To: Chris Healy <cphealy@gmail.com>
Cc: Alexander Aring <aar@pengutronix.de>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-wpan@vger.kernel.org
Subject: Re: [PATCH] at86rf230: Allow slow GPIO pins for "rstn"
Date: Wed, 21 Dec 2016 22:01:15 +0100 [thread overview]
Message-ID: <d1a4cfb5-9c0a-1bbe-1a5a-67f3f9e79d43@osg.samsung.com> (raw)
In-Reply-To: <CAFXsbZpgiTM2qngYERVpfXHvePW8M8DN91YnZwc-voKO=FDUUA@mail.gmail.com>
Hello.
On 21/12/16 19:30, Chris Healy wrote:
>
>
> On Dec 21, 2016 5:11 AM, "Stefan Schmidt" <stefan@osg.samsung.com
> <mailto:stefan@osg.samsung.com>> wrote:
>
> Hello.
>
>
> On 19/12/16 00:25, Andrey Smirnov wrote:
>
> Driver code never touches "rstn" signal in atomic context, so
> there's
> no need to implicitly put such restriction on it by using
> gpio_set_value
> to manipulate it. Replace gpio_set_value to
> gpio_set_value_cansleep to
> fix that.
>
>
> We need to make sure we are not assuming it can be called in such a
> context in the future now. But that is something we can worry about
> if it comes up.
>
>
> As a an example of where such restriction might be inconvenient,
> consider a hardware design where "rstn" is connected to a pin of
> I2C/SPI
> GPIO expander chip.
>
>
> Is this a real life issue you run into?
>
>
> I have a platform with this configuration. The DTS for the platform is
> in the process of being mainlined right now.
Thanks for letting us know. What platform is that? I'm always interested
in hearing about devices that use the Linux ieee802154 subsystem. :)
regards
Stefan Schmidt
prev parent reply other threads:[~2016-12-21 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-18 23:25 [PATCH] at86rf230: Allow slow GPIO pins for "rstn" Andrey Smirnov
2016-12-21 12:30 ` Nikita Yushchenko
2016-12-21 13:11 ` [PATCH] " Stefan Schmidt
[not found] ` <CAFXsbZpgiTM2qngYERVpfXHvePW8M8DN91YnZwc-voKO=FDUUA@mail.gmail.com>
2016-12-21 21:01 ` Stefan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1a4cfb5-9c0a-1bbe-1a5a-67f3f9e79d43@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=aar@pengutronix.de \
--cc=andrew.smirnov@gmail.com \
--cc=cphealy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).