From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98F5BC43460 for ; Wed, 21 Apr 2021 16:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 651616140F for ; Wed, 21 Apr 2021 16:32:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241891AbhDUQdW (ORCPT ); Wed, 21 Apr 2021 12:33:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241136AbhDUQdQ (ORCPT ); Wed, 21 Apr 2021 12:33:16 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C72F4C06174A; Wed, 21 Apr 2021 09:32:42 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id m12so9672419pgr.9; Wed, 21 Apr 2021 09:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=dbbH5mU0eZQOvfNmncVtsU5aW1qxNpTR7xNLktkxO/8=; b=r2pyaVk2t6foNEjWeJgrpPuyNXGzX/dF+DIu22dYUss19nfc4lBaUxn8OQ7azwSplI nX0gqVnTVlg1Us4NtxIYike5JKI8ygpel1bfLgzbjgKWHP86RfWJwIFVWCEIGpfHMMen YSJ8fR20KjjLk761nB5Dh9Z5TpXopTYm1z9A+YSNH7rWN0FwIBk/c5x8UmyZpIEoRODx 2m6aBQSr+UxyCfr0cPeKKQgmonBo9iNxhzYfECMVWEI8ZqTf58H4wuJ/BiU9/ZwPvOSO 6aMPDMlnpWANyfXqvjOwsfzd2ak8rZOIK9LfFnmI4MC/LWPZv2B7nKoEMZvFeCsPEHd7 qW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dbbH5mU0eZQOvfNmncVtsU5aW1qxNpTR7xNLktkxO/8=; b=Rv5CrSZ5cenWSj0f63jb3CMTDooPHVjADd3/XJfbC33AIeT54XXz75WCNkbMR5njti USBeIrufxe7B4Xo6LMUj6vzqkVMjaAtdXAdq2h3tGvGn6tgmTnKBdfe9RxMvJx+pC8zJ eEj0ViQUFU2+6/i1D5c8IuFSwVjmsBeHS+BR7U65u3KVkTARzEwTQyHWH1VOFTbMtWVU hQDKIjlGWSgkxujWex2Xa2k36Mlrfdkz/es4fymas9Yh3Sb5vYrn9/ttdERCAWifJjjQ ddy77Gn2pPMglkEBE4QD0nCLZ62EO9jtsHEqMjik5l5ZPR6qCw6Hcl33urHIeFr3XQds 5quQ== X-Gm-Message-State: AOAM5319luzG+hHKZEfO7goTMHIm/GH/w7e0ymPsNHRCrnBMBKEnHlC1 431mvgUmFVt2saNtfD+4Oqfr56Y/sk4= X-Google-Smtp-Source: ABdhPJx6glrHRUC62q7tOtGWilSy1urFZAUxX7xDjf+r/jBBvgSwUma1em94Dza3fRJUG5e63dF7xQ== X-Received: by 2002:a17:90a:c209:: with SMTP id e9mr12234306pjt.104.1619022762408; Wed, 21 Apr 2021 09:32:42 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id s22sm2630721pjs.42.2021.04.21.09.32.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Apr 2021 09:32:41 -0700 (PDT) Subject: Re: [PATCH net-next v1] net: dsa: fix bridge support for drivers without port_bridge_flags callback To: Oleksij Rempel , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S. Miller" , Jakub Kicinski Cc: kernel@pengutronix.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King References: <20210421130540.12522-1-o.rempel@pengutronix.de> From: Florian Fainelli Message-ID: Date: Wed, 21 Apr 2021 09:32:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210421130540.12522-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/21/2021 6:05 AM, Oleksij Rempel wrote: > Starting with patch: > a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags") > > drivers without "port_bridge_flags" callback will fail to join the bridge. > Looking at the code, -EOPNOTSUPP seems to be the proper return value, > which makes at least microchip and atheros switches work again. > > Fixes: a8b659e7ff75 ("net: dsa: act as passthrough for bridge port flags") > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli -- Florian