From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967385AbdAKOlR (ORCPT ); Wed, 11 Jan 2017 09:41:17 -0500 Received: from resqmta-po-06v.sys.comcast.net ([96.114.154.165]:38350 "EHLO resqmta-po-06v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967369AbdAKOlO (ORCPT ); Wed, 11 Jan 2017 09:41:14 -0500 Reply-To: shuah@kernel.org Subject: Re: [PATCH] selftests/futex: Fix makefile dependencies References: <20170106041839.20363-1-shorne@gmail.com> <20170110221042.GD4371@f23x64.localdomain> <20170110221718.GE4371@f23x64.localdomain> <20170111043719.GA25986@lianli.shorne-pla.net> <20170111080755.GA36664@f23x64.localdomain> <20170111084851.GB25986@lianli.shorne-pla.net> To: Stafford Horne , Darren Hart Cc: linux-kernel@vger.kernel.org, dvhart@linux.intel.com, linux-kselftest@vger.kernel.org, Shuah Khan From: Shuah Khan Message-ID: Date: Wed, 11 Jan 2017 07:41:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170111084851.GB25986@lianli.shorne-pla.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFmQCbD92gYwVlMOKSMSGRq46Z5vMMkbO9KsmHpiHu9HFUQNMJ3zGmgX2XwGX1NJPoGk4o4rBupQu3ngygw59tkUEpvmbPgROooeP6uzhOoepfXC9ykL dYjOLSSEULls3QCIe4YtWgY4zAkOwYRHembB2XrG8tz6xdDdnp43bty5+Hbb2eKOYEUcotq1ygzU3a2fz8XC4KSjlRv/ECYwXE9TI9LqoxnjVqC65QhONHg0 G4jvv8VgAKNVmF3VI5o022U7E7OplFhwj3OB3vkMxzpYq+nzC+CK8FrV676R1q5vZb6QiajkDaoOKkIm4ztqlOg8pr8Uw/XdpfAhGu0OCgq+EcyPjUQXp3hR QUT88JRH Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/11/2017 01:48 AM, Stafford Horne wrote: > On Wed, Jan 11, 2017 at 12:07:55AM -0800, Darren Hart wrote: >> On Wed, Jan 11, 2017 at 01:37:19PM +0900, Stafford Horne wrote: >>> On Tue, Jan 10, 2017 at 02:17:18PM -0800, Darren Hart wrote: >>>> On Tue, Jan 10, 2017 at 02:10:42PM -0800, Darren Hart wrote: >>>>> On Fri, Jan 06, 2017 at 01:18:39PM +0900, Stafford Horne wrote: >>>>>> I am working on doing selftests for openrisc and found issues with the >>>>>> futex test is not building after changes to the tests source. >>>>>> >>>>>> This issue is that the TARGETS variable used in the futex Makefile is >>>>>> also used by the selftests Makefile, so when building from toplevel the >>>>>> TARGETS variable is clobbered and nothing gets built. Changed the >>>>>> variable name to get around that. >>>>>> >>>>>> Also, the futex makefile did not contain dependencies for all headers, >>>>>> so if we make changes to logging.h rebuild will not happen. Add headers >>>>>> to fix it up. >>>>>> >>>>>> Signed-off-by: Stafford Horne >>>>> >>>>> Thanks for catching this and the fix. >>>>> >>>>> +Shuah Khan >>>>> >>>>> Note: This appears also to be a problem for intel_pstate/Makefile >>>> >>>> Or, it would be if intel_pstate was listed in selftests/Makefile :-) >>> >>> Right, thanks for having a look. I actually have a small patch to also >>> add to logging.h. If you have not already fixed the >>> intel_pstate test I'll send them all together. >> >> Please do, thanks! > > Hello, > Actually I just had a look at Shuah's linux-kselftest repo on > kernel.org. It looks like Bamvor Jian has actually fixed a lot of these > issues on the next branch. > > I will see what is missing if anything. > > -Stafford > > Hi Stafford, Thanks for looking into the issues. Yes Bemovar fixed several issues. Could you please send me the patches you alre If you think [PATCH] selftests/futex: Fix makefile dependencies should be pulled in, please send it to me. I just Darren's response, don't have the original patch email in my Inbox. thanks, -- Shuah