From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86CB9C25B0E for ; Fri, 19 Aug 2022 09:17:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348087AbiHSJRw (ORCPT ); Fri, 19 Aug 2022 05:17:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348073AbiHSJRt (ORCPT ); Fri, 19 Aug 2022 05:17:49 -0400 Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8500F2D68; Fri, 19 Aug 2022 02:17:48 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 02DA1E031B; Fri, 19 Aug 2022 02:17:48 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vuvx1q-IectB; Fri, 19 Aug 2022 02:17:47 -0700 (PDT) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1660900667; bh=Jo9QL7raUD2BIWVuwvlATedJOyz9wfWXMd9342485kA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=gwtLUvDwZ3jddAsrm0b7mign2kCxfFLgAot46f6PaCr9wDf8QeCaXDr6SHHhszwdk QjJeLT9WsyTB6yPSwVNDoG8zfki/eOIgERjfIP2PDnW69QxRXLkjIHdL6DIFoWnaVm qy0berAxWmjfeXnvZ/OkkWIK4kAPMMP9ZybuVeh5Mll/QonaaXr8JcZtMABdiEAHWx a6gaGGRplptBNF8jKk9LECc/RF8D2Oluk546RId5dcx8aPYULvUrpw8Cc0/1asAYD/ upmL174Wi/mu6wXdzA4TyKqzd0Lop1CtCEHh2cH7jCTsfx7haqZESJezll+KoUKttF YEbS6UkXsfzbw== Subject: Re: [PATCH v6 1/2] power: domain: handle genpd correctly when needing interrupts From: Martin Kepplinger To: Ulf Hansson Cc: rafael@kernel.org, khilman@kernel.org, robh@kernel.org, krzysztof.kozlowski@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, pavel@ucw.cz, kernel@puri.sm, linux-imx@nxp.com, broonie@kernel.org, l.stach@pengutronix.de, aford173@gmail.com, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Date: Fri, 19 Aug 2022 11:17:40 +0200 In-Reply-To: References: <20220726083257.1730630-1-martin.kepplinger@puri.sm> <20220726083257.1730630-2-martin.kepplinger@puri.sm> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, dem 26.07.2022 um 17:07 +0200 schrieb Ulf Hansson: > On Tue, 26 Jul 2022 at 10:33, Martin Kepplinger > wrote: > > > > If for example the power-domains' power-supply node (regulator) > > needs > > interrupts to work, the current setup with noirq callbacks cannot > > work; for example a pmic regulator on i2c, when suspending, usually > > already > > times out during suspend_noirq: > > > > [   41.024193] buck4: failed to disable: -ETIMEDOUT > > > > So fix system suspend and resume for these power-domains by using > > the > > "outer" suspend/resume callbacks instead. Tested on the imx8mq- > > librem5 board, > > but by looking at the dts, this will fix imx8mq-evk and possibly > > many other > > boards too. > > > > This is designed so that genpd providers just say "this genpd needs > > interrupts" (by setting the flag) - without implying an > > implementation. > > > > Initially system suspend problems had been discussed at > > https://lore.kernel.org/linux-arm-kernel/20211002005954.1367653-8-l.stach@pengutronix.de/ > > which led to discussing the pmic that contains the regulators which > > serve as power-domain power-supplies: > > https://lore.kernel.org/linux-pm/573166b75e524517782471c2b7f96e03fd93d175.camel@puri.sm/T/ > > > > Signed-off-by: Martin Kepplinger > > --- > >  drivers/base/power/domain.c | 13 +++++++++++-- > >  include/linux/pm_domain.h   |  5 +++++ > >  2 files changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/base/power/domain.c > > b/drivers/base/power/domain.c > > index 5a2e0232862e..58376752a4de 100644 > > --- a/drivers/base/power/domain.c > > +++ b/drivers/base/power/domain.c > > @@ -130,6 +130,7 @@ static const struct genpd_lock_ops > > genpd_spin_ops = { > >  #define genpd_is_active_wakeup(genpd)  (genpd->flags & > > GENPD_FLAG_ACTIVE_WAKEUP) > >  #define genpd_is_cpu_domain(genpd)     (genpd->flags & > > GENPD_FLAG_CPU_DOMAIN) > >  #define genpd_is_rpm_always_on(genpd)  (genpd->flags & > > GENPD_FLAG_RPM_ALWAYS_ON) > > +#define genpd_irq_on(genpd)            (genpd->flags & > > GENPD_FLAG_IRQ_ON) > > > >  static inline bool irq_safe_dev_in_sleep_domain(struct device > > *dev, > >                 const struct generic_pm_domain *genpd) > > @@ -2065,8 +2066,15 @@ int pm_genpd_init(struct generic_pm_domain > > *genpd, > >         genpd->domain.ops.runtime_suspend = genpd_runtime_suspend; > >         genpd->domain.ops.runtime_resume = genpd_runtime_resume; > >         genpd->domain.ops.prepare = genpd_prepare; > > -       genpd->domain.ops.suspend_noirq = genpd_suspend_noirq; > > -       genpd->domain.ops.resume_noirq = genpd_resume_noirq; > > + > > +       if (genpd_irq_on(genpd)) { > > +               genpd->domain.ops.suspend = genpd_suspend_noirq; > > +               genpd->domain.ops.resume = genpd_resume_noirq; > > +       } else { > > +               genpd->domain.ops.suspend_noirq = > > genpd_suspend_noirq; > > +               genpd->domain.ops.resume_noirq = > > genpd_resume_noirq; > > As we discussed previously, I am thinking that it may be better to > move to using genpd->domain.ops.suspend_late and > genpd->domain.ops.resume_early instead. Wouldn't that better be a separate patch (on top)? Do you really want me to change the current behaviour (default case) to from noirq to late? Then I'll resend this series with such a patch added. thanks, martin > > Beside this, I think the $subject patch looks good to me. > > [...] > > Kind regards > Uffe