From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC96C433EF for ; Wed, 1 Jun 2022 09:19:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350147AbiFAJTS (ORCPT ); Wed, 1 Jun 2022 05:19:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350089AbiFAJTN (ORCPT ); Wed, 1 Jun 2022 05:19:13 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 034B917E32 for ; Wed, 1 Jun 2022 02:19:11 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id y19so2447972ejq.6 for ; Wed, 01 Jun 2022 02:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=w0q7w7agqeVzeJoFI0aW/0pLwg+C1kvsWYmBalugg8Q=; b=VixWWPTJ2XezaiMDn6QH/mc8juwDFuC9uioDoU9V+mrWz6fabTxHi48gVF79fLkNZI CAEjE4jKF00zgp2R4UuRtTGQ/V2DI9Wa6gfA8F0TkWEPQA58c1oHeIwhZFYibE4CuRTN 50joB2Zrq8ilMbr0GLmGfkchBBwuKjG/57DOTnBEr0zMiRcYrofNk933/tjhE6RX1A7x bLhyouUfCQCxLBhzjHo7kDDau9QgFwxecgC1mSCpMa12H5P+EdtH9vNDg2PcVGvxwDeu y3dptNbRzcQ1FMT4qajLIVJTLchACkZhMaHHabSNjF/6TCbkzeoi4pCduF/NGL07I2nF x/DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=w0q7w7agqeVzeJoFI0aW/0pLwg+C1kvsWYmBalugg8Q=; b=AhMHXFE7sxGX/kyLpsq0t4L7MyDepUExDk4UkvCiSohnyZ/TuD4sfYk+GsVoIbMlzw tyQePFq2gCf7TNFqXVxHNZ7r8Mp3UCDnmdE3srlossw/DsSP8zw7xGglIZfsto8ANyH3 gCPJ0QA4UTLaYtjFzViEeP/UV3CO64W08GPEkEW06TLaxWobEe1GqxRJ+7Jtc6paRhyD 9aytdvINBAtxS4q75MOG/5pySjr2FTkpQ/XKxN3ca67sF2eKkVOXlAco61isIlnmuUrk 7QKNbM2L4rhaQ7hfJsyhy5yd8oULYR7EyY0kRSS/RZvfzHQ/pgBKmsYCU4lMlVOOT8QD iMTw== X-Gm-Message-State: AOAM531F/TrG2mZhzHS10KOBNQDSntFIoTw+ruKYp6scCdJuDWDfQNeo aSOE9wi8hbHPvJBotv+jj+Kn+qqwoN31Q4zu X-Google-Smtp-Source: ABdhPJxIz5yKljtZ01n/8e8Iqvz6i01vdsc3Tj+8YIjD1XxI182o5dWwgzHRLoMv1YfZoH7CLyT2yA== X-Received: by 2002:a17:907:7f20:b0:6fe:f0c8:8e6f with SMTP id qf32-20020a1709077f2000b006fef0c88e6fmr40303647ejc.453.1654075149570; Wed, 01 Jun 2022 02:19:09 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id u9-20020aa7d889000000b0042b5cf75d6esm630769edq.97.2022.06.01.02.19.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 02:19:09 -0700 (PDT) Message-ID: Date: Wed, 1 Jun 2022 11:19:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 4/5] dt-bindings: crypto: add documentation for aspeed hace Content-Language: en-US To: Neal Liu , Herbert Xu , "David S . Miller" , Rob Herring , Krzysztof Kozlowski , Joel Stanley , Andrew Jeffery , Johnny Huang Cc: "linux-aspeed@lists.ozlabs.org" , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20220601054204.1522976-1-neal_liu@aspeedtech.com> <20220601054204.1522976-5-neal_liu@aspeedtech.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/06/2022 10:01, Neal Liu wrote: >>> + clocks: >>> + maxItems: 1 >>> + >>> + clock-names: >>> + maxItems: 1 >> >> You need to list clock names, however usually it does not make sense to have >> names for just one main device clock. >> > I think list clock-names is optional, I'll remove it from required list. I actually suggest to remove the clock-names property entirely, if is has one generic entry called "clk" (or "vclk" - the same). Do you already expect adding here more clocks? Best regards, Krzysztof