linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Julien Thierry <julien.thierry@arm.com>,
	Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
	peterz@infradead.org, marc.zyngier@arm.com, mingo@kernel.org
Subject: Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines
Date: Wed, 01 Aug 2018 08:33:45 -0700	[thread overview]
Message-ID: <d21f238a0aaa9f5f8323c1e3087612ebf12a86bd.camel@perches.com> (raw)
In-Reply-To: <df8f9f98-a1d3-e871-eec8-d805ff7cf5b7@arm.com>

On Wed, 2018-08-01 at 16:09 +0100, Julien Thierry wrote:
> On 01/08/18 04:07, Ricardo Neri wrote:
> > On Tue, Jul 24, 2018 at 12:07:04PM +0100, Julien Thierry wrote:
> > > +	    || WARN_ON(irq_settings_is_per_cpu_devid(desc))
> > > +	    || !irq_supports_nmi(desc))
> > 
> > Shouldn't the logical operators in a multi-line statement go at the end of
> > the line?
> 
> I couldn't find anything about this in the kernel coding style and 
> checkpatch didn't complain.

coding-style is a set of suggestions not dicta.

Many of the tests in checkpatch are not written out in
coding-style.

checkpatch does emit a message when used with --strict here:

The checkpatch test is:

# check for && or || at the start of a line
		if ($rawline =~ /^\+\s*(&&|\|\|)/) {
			CHK("LOGICAL_CONTINUATIONS",
			    "Logical continuations should be on the previous line\n" . $hereprev);
		}

This message is not always emitted because code outside of
net, drivers/net, and drivers/staging does not use --strict
by default.


  reply	other threads:[~2018-08-01 15:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 11:07 [PATCH 0/4] Provide core API for NMIs Julien Thierry
2018-07-24 11:07 ` [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines Julien Thierry
2018-08-01  3:07   ` Ricardo Neri
2018-08-01 15:09     ` Julien Thierry
2018-08-01 15:33       ` Joe Perches [this message]
2018-08-02  2:03       ` Ricardo Neri
2018-08-02  6:38         ` Marc Zyngier
2018-08-02  6:55           ` Thomas Gleixner
2018-08-02  7:35             ` Marc Zyngier
2018-08-02  9:40               ` Thomas Gleixner
2018-08-03  3:09                 ` Ricardo Neri
2018-08-03  7:59                   ` Thomas Gleixner
2018-07-24 11:07 ` [PATCH 2/4] genirq: Provide NMI management for percpu_devid interrupts Julien Thierry
2018-08-01  3:11   ` Ricardo Neri
2018-08-01 15:11     ` Julien Thierry
2018-07-24 11:07 ` [PATCH 3/4] genirq: Provide NMI handlers Julien Thierry
2018-07-24 11:07 ` [PATCH 4/4] irqdesc: Add domain handler for NMIs Julien Thierry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d21f238a0aaa9f5f8323c1e3087612ebf12a86bd.camel@perches.com \
    --to=joe@perches.com \
    --cc=julien.thierry@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ricardo.neri-calderon@linux.intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).