From: Philipp Zabel <p.zabel@pengutronix.de>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Steen Hegelund <steen.hegelund@microchip.com>,
Lars Povlsen <lars.povlsen@microchip.com>,
UNGLinuxDriver@microchip.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] reset: mchp: sparx5: fix return value check in mchp_sparx5_map_io()
Date: Mon, 07 Jun 2021 11:23:28 +0200 [thread overview]
Message-ID: <d222e3a93d192722099994441283193d6ed26a79.camel@pengutronix.de> (raw)
In-Reply-To: <20210519141638.3052456-1-weiyongjun1@huawei.com>
On Wed, 2021-05-19 at 14:16 +0000, Wei Yongjun wrote:
> In case of error, the function devm_platform_get_and_ioremap_resource()
> returns ERR_PTR() and never returns NULL. The NULL test in the return
> value check should be replaced with IS_ERR().
>
> Fixes: 453ed4283beb ("reset: mchp: sparx5: add switch reset driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thank you, applied to reset/fixes.
regards
Philipp
next prev parent reply other threads:[~2021-06-07 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:16 [PATCH -next] reset: mchp: sparx5: fix return value check in mchp_sparx5_map_io() Wei Yongjun
2021-06-07 9:23 ` Philipp Zabel [this message]
2021-06-07 9:33 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d222e3a93d192722099994441283193d6ed26a79.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steen.hegelund@microchip.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).