From: Daniel Baluta <daniel.baluta@nxp.com>
To: Anson Huang <anson.huang@nxp.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"festevam@gmail.com" <festevam@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module
Date: Thu, 11 Jun 2020 11:55:16 +0300 [thread overview]
Message-ID: <d23114e1-1a81-45cc-e8da-6fed53f455ab@nxp.com> (raw)
In-Reply-To: <DB3PR0402MB391645F95B19B2438736B546F5800@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On 11.06.2020 11:48, Anson Huang wrote:
> Hi, Daniel
>
>> Subject: Re: [PATCH V4 4/9] pinctrl: imx8mn: Support building as module
>>
>> Maybe this is obvious but I would really like to see an explanation
>>
>> of why we are switching from arch_initcall to platform_init.
>>
>> Commit message act as documentation for the reviewers.
> Yes, I noticed this, and it looks like unnecessary change, and I just replied in
> mail that I will change it back to arch_initcall() in order to make sure nothing
> changed for built-in config. Below is what I replied in cover-letter mail:
>
> " I will keep the arch_initcall() there in next version patch series, it can make sure
> the change does NOT impact built-in config. For module build, the arch_initcall()
> will be same as module_init(), user needs to insmod the .ko with correct sequence."
Ok, that's great. Lets try to keep in mind that the commit message should
answer to a simple question: "Why the change is needed" :).
Then, the details about the change should be added.
next prev parent reply other threads:[~2020-06-11 8:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 7:57 [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built as module Anson Huang
2020-06-10 7:57 ` [PATCH V4 1/9] pinctrl: imx: Support building SCU pinctrl driver " Anson Huang
2020-06-10 7:57 ` [PATCH V4 2/9] pinctrl: imx: Support building i.MX " Anson Huang
2020-06-10 7:57 ` [PATCH V4 3/9] pinctrl: imx8mm: Support building " Anson Huang
2020-06-10 7:57 ` [PATCH V4 4/9] pinctrl: imx8mn: " Anson Huang
2020-06-11 8:42 ` Daniel Baluta
2020-06-11 8:48 ` Anson Huang
2020-06-11 8:55 ` Daniel Baluta [this message]
2020-06-10 7:57 ` [PATCH V4 5/9] pinctrl: imx8mq: " Anson Huang
2020-06-10 7:57 ` [PATCH V4 6/9] pinctrl: imx8mp: " Anson Huang
2020-06-10 7:57 ` [PATCH V4 7/9] pinctrl: imx8qxp: " Anson Huang
2020-06-10 7:57 ` [PATCH V4 8/9] pinctrl: imx8qm: " Anson Huang
2020-06-10 7:57 ` [PATCH V4 9/9] pinctrl: imx8dxl: " Anson Huang
2020-06-11 8:34 ` [PATCH V4 0/9] Support i.MX8 SoCs pinctrl drivers built " Daniel Baluta
2020-06-11 8:44 ` Anson Huang
2020-06-11 8:49 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d23114e1-1a81-45cc-e8da-6fed53f455ab@nxp.com \
--to=daniel.baluta@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=anson.huang@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).