From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754307AbcICMnF (ORCPT ); Sat, 3 Sep 2016 08:43:05 -0400 Received: from mout.web.de ([212.227.15.4]:56088 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754161AbcICMm7 (ORCPT ); Sat, 3 Sep 2016 08:42:59 -0400 Subject: [PATCH 15/17] s390/debug: Improve a size determination in debug_raw_header_fn() To: linux-s390@vger.kernel.org, David Hildenbrand , Heiko Carstens , Joe Perches , Martin Schwidefsky References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: Date: Sat, 3 Sep 2016 14:36:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:6JEZaYltqU1D4mjXisR47Y63bHa8O8Bcvp00zOX6SznvHRO4192 1SmOHoH5HDtKlt5IJRrMpxL4pSLs/LhmblySgWVUmxCVVWriOc2XTo7DE/P8v15uXAbP3Zv ypVe8ZgCeR5Ivqa8FcPplinUEX6Z1PmAWYcacqPLWI7Z1/0z7zLdIgD7m9q2Xk5wW/pqmEa 7vPzl6iFuqsEu6Pu1NcSQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:bgIvdvG9gOQ=:9QkHA0GVXeRV12PnE65S33 bZII+F5lpJaYxvsMIGubH2OwAA9WFUDwVXgAc+xX9HSw85AVOErROyidTghLqcGRzfF8phBQ4 2fITYsd2JZw2V9R1TyX3TDerVGXmwaQGRatIEzq5gWWtyiiJPeYWVVfXuBHT0z17gW6AGojMD iKoWrNvVLkYFCrR5+5sCinz5sAo1ln85dzgW3Fh0iy/K+OyilQWOW/8mv8N4A1VJlpQGG0CY2 zZqnfj9IR5bNyawUrIrGYgsJ1e++0SlyzseuDOcRaHSb/ZwRNLEkECNasZNyEF52/m5fNj7U0 eWmLHqkHU0p9fbE7VmD+V0b5GmPonRYeN1mRDsRAd2kzuZhd5WLwfxeyh7n3xEBNJfkzssgwk D6YwXeinFSV3md099j92aWjkZ3b0bMTRUt3/vOqStMFmSnfuLW9P/hXj/Ka8hTr5feA8VkYI9 pr/r8T+Fy1nHpoNd4DTZa0/DAQrHEpZMF/kYfi34nKDPINThO5NUPf8ekcb4EGWVW7TxkHEWO u2vWVwTr/X4Cxm/u+TVkLSuiLo2kY2F7C6bysQxyIGR5xxjJI9oTpI+JpfWCf7Y1GNY4PpJGR XjJjOovrrM+I8v84SyeKfq1MgNHyMrCv5bo7DRyHy0pnQyZYKgNLGo9UkEL5iiJEry/oNNLNG fPUqhwc7Udy1iRST6R7SXeOS4tYxogVmMB9w9b8V3nJjePAF2LP70ARGP3Qw1RZNprWhu9eWu W3YrusJCmEROIKe9B3/6l90ewFxX85oinTdaSIIjsbQJo36zrCOqpRN16AWOOuQwvuo7yO9Dm BDROS6J Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 2 Sep 2016 14:34:22 +0200 * Replace the specification of a data type by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. * Return a constant directly without storing the desired value in a local variable. Signed-off-by: Markus Elfring --- arch/s390/kernel/debug.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/s390/kernel/debug.c b/arch/s390/kernel/debug.c index 6792a9c..ff8e705 100644 --- a/arch/s390/kernel/debug.c +++ b/arch/s390/kernel/debug.c @@ -1380,11 +1380,8 @@ static int debug_raw_header_fn(debug_info_t * id, struct debug_view *view, int area, debug_entry_t * entry, char *out_buf) { - int rc; - - rc = sizeof(debug_entry_t); - memcpy(out_buf, entry, sizeof(debug_entry_t)); - return rc; + memcpy(out_buf, entry, sizeof(*entry)); + return sizeof(*entry); } /* -- 2.9.3