From: Anshuman Khandual <anshuman.khandual@arm.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>, linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] mm/page_owner: Constify dump_page_owner
Date: Tue, 27 Apr 2021 09:01:21 +0530 [thread overview]
Message-ID: <d24e500b-22b2-7b8c-8141-4704b2b62259@arm.com> (raw)
In-Reply-To: <20210416231531.2521383-4-willy@infradead.org>
On 4/17/21 4:45 AM, Matthew Wilcox (Oracle) wrote:
> dump_page_owner() only uses struct page to find the page_ext, and
> lookup_page_ext() already takes a const argument.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> include/linux/page_owner.h | 6 +++---
> mm/page_owner.c | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/page_owner.h b/include/linux/page_owner.h
> index 3468794f83d2..719bfe5108c5 100644
> --- a/include/linux/page_owner.h
> +++ b/include/linux/page_owner.h
> @@ -14,7 +14,7 @@ extern void __set_page_owner(struct page *page,
> extern void __split_page_owner(struct page *page, unsigned int nr);
> extern void __copy_page_owner(struct page *oldpage, struct page *newpage);
> extern void __set_page_owner_migrate_reason(struct page *page, int reason);
> -extern void __dump_page_owner(struct page *page);
> +extern void __dump_page_owner(const struct page *page);
> extern void pagetypeinfo_showmixedcount_print(struct seq_file *m,
> pg_data_t *pgdat, struct zone *zone);
>
> @@ -46,7 +46,7 @@ static inline void set_page_owner_migrate_reason(struct page *page, int reason)
> if (static_branch_unlikely(&page_owner_inited))
> __set_page_owner_migrate_reason(page, reason);
> }
> -static inline void dump_page_owner(struct page *page)
> +static inline void dump_page_owner(const struct page *page)
> {
> if (static_branch_unlikely(&page_owner_inited))
> __dump_page_owner(page);
> @@ -69,7 +69,7 @@ static inline void copy_page_owner(struct page *oldpage, struct page *newpage)
> static inline void set_page_owner_migrate_reason(struct page *page, int reason)
> {
> }
> -static inline void dump_page_owner(struct page *page)
> +static inline void dump_page_owner(const struct page *page)
> {
> }
> #endif /* CONFIG_PAGE_OWNER */
> diff --git a/mm/page_owner.c b/mm/page_owner.c
> index adfabb560eb9..f51a57e92aa3 100644
> --- a/mm/page_owner.c
> +++ b/mm/page_owner.c
> @@ -392,7 +392,7 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn,
> return -ENOMEM;
> }
>
> -void __dump_page_owner(struct page *page)
> +void __dump_page_owner(const struct page *page)
> {
> struct page_ext *page_ext = lookup_page_ext(page);
> struct page_owner *page_owner;
>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
next prev parent reply other threads:[~2021-04-27 3:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 23:15 [RESEND][PATCH 0/6] Constify struct page arguments Matthew Wilcox (Oracle)
2021-04-16 23:15 ` [PATCH 1/6] mm: Make __dump_page static Matthew Wilcox (Oracle)
2021-04-23 14:49 ` Vlastimil Babka
2021-04-27 3:30 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 2/6] mm/debug: Factor PagePoisoned out of __dump_page Matthew Wilcox (Oracle)
2021-04-23 14:52 ` Vlastimil Babka
2021-04-27 3:30 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 3/6] mm/page_owner: Constify dump_page_owner Matthew Wilcox (Oracle)
2021-04-23 14:53 ` Vlastimil Babka
2021-04-27 3:31 ` Anshuman Khandual [this message]
2021-04-16 23:15 ` [PATCH 4/6] mm: Make compound_head const-preserving Matthew Wilcox (Oracle)
2021-04-23 14:58 ` Vlastimil Babka
2021-04-27 3:31 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 5/6] mm: Constify get_pfnblock_flags_mask and get_pfnblock_migratetype Matthew Wilcox (Oracle)
2021-04-23 14:59 ` Vlastimil Babka
2021-04-27 3:32 ` Anshuman Khandual
2021-04-16 23:15 ` [PATCH 6/6] mm: Constify page_count and page_ref_count Matthew Wilcox (Oracle)
2021-04-23 15:01 ` Vlastimil Babka
2021-04-27 3:32 ` Anshuman Khandual
2021-04-17 7:14 ` [RESEND][PATCH 0/6] Constify struct page arguments William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d24e500b-22b2-7b8c-8141-4704b2b62259@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).