Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600

From: Hans de Goede <hdegoede@redhat.com>
To: Maccraft123 <maccraft123mc@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: panel-orientation-quirks: Add quirk for Anbernic Win600
Date: Thu, 4 Aug 2022 10:32:26 +0200	[thread overview]
Message-ID: <d24e781c-3c84-26eb-14b9-8cb4ea3b32ba@redhat.com> (raw)
In-Reply-To: <20220803182402.1217293-1-maccraft123mc@gmail.com>

Hi,

On 8/3/22 20:24, Maccraft123 wrote:
> From: Maya Matuszczyk <maccraft123mc@gmail.com>
> 
> This device is another x86 gaming handheld, and as (hopefully) there is
> only one set of DMI IDs it's using DMI_EXACT_MATCH
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Since we are currently in the middle of the merge window
and this patch needs to go to a -fixes branch I'm not quite
sure how to handle this.

Hopefully one of the drm-misc maintainers can pick this
up (once rc1 is out?) .

Regards,

Hans

> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index d4e0f2e85548..a8681610ede7 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -128,6 +128,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"),
>  		},
>  		.driver_data = (void *)&lcd800x1280_rightside_up,
> +	}, {	/* Anbernic Win600 */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Anbernic"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Win600"),
> +		},
> +		.driver_data = (void *)&lcd720x1280_rightside_up,
>  	}, {	/* Asus T100HA */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),