From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
To: Valentin Vidic <Valentin.Vidic@CARNet.hr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Simon Sandström" <simon@nikanor.nu>,
"Marcus Wolf" <linux@Wolf-Entwicklungen.de>,
"Luca Söthe" <luca@acul.me>,
"Marcin Ciupak" <marcin.s.ciupak@gmail.com>,
"Michael Panzlaff" <michael.panzlaff@fau.de>,
"Derek Robson" <robsonde@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: pi433: add descriptions for mutex locks
Date: Fri, 23 Mar 2018 11:22:39 +0100 [thread overview]
Message-ID: <d263c605-f652-fe24-2034-c699f2d27693@smarthome-wolf.de> (raw)
In-Reply-To: <20180323094725.4904-1-Valentin.Vidic@CARNet.hr>
Hi Valentin,
could you please decribe in short words, why you think, that hte lock
isn't obsolete?
I wasn't sure, but close to remove the lock. That's why I putted the
comment.
Thanks,
Marcus
Am 23.03.2018 um 10:47 schrieb Valentin Vidic:
> Removes TODO for tx_fifo_lock as tx_fifo is modified from
> both pi433_tx_thread and pi433_write.
>
> Fixes checkpatch warning:
>
> CHECK: struct mutex definition without comment
>
> Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
> ---
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index d1e0ddbc79ce..f6f106a3ff8e 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -87,7 +87,7 @@ struct pi433_device {
>
> /* tx related values */
> STRUCT_KFIFO_REC_1(MSG_FIFO_SIZE) tx_fifo;
> - struct mutex tx_fifo_lock; // TODO: check, whether necessary or obsolete
> + struct mutex tx_fifo_lock; /* serialize access to tx_fifo */
> struct task_struct *tx_task_struct;
> wait_queue_head_t tx_wait_queue;
> u8 free_in_fifo;
> @@ -100,7 +100,7 @@ struct pi433_device {
> u32 rx_bytes_to_drop;
> u32 rx_bytes_dropped;
> unsigned int rx_position;
> - struct mutex rx_lock;
> + struct mutex rx_lock; /* serialize read requests */
> wait_queue_head_t rx_wait_queue;
>
> /* fifo wait queue */
>
--
Smarthome-Wolf UG (haftungsbeschränkt)
Helene-Lange-Weg 23
80637 München
Amtsgericht München, HRB 223529
Umastzsteuer-ID: DE304719911
Geschäftsführer: Marcus Wolf
next prev parent reply other threads:[~2018-03-23 10:22 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-23 9:47 [PATCH] staging: pi433: add descriptions for mutex locks Valentin Vidic
2018-03-23 10:22 ` Marcus Wolf [this message]
2018-03-23 11:42 ` Valentin Vidic
2018-03-23 15:38 ` Marcus Wolf
2018-03-23 18:00 ` Valentin Vidic
2018-03-23 22:18 ` Valentin Vidic
2018-03-24 22:09 ` [PATCH] staging: pi433: cleanup tx_fifo locking Valentin Vidic
2018-03-25 13:00 ` [PATCH] staging: pi433: add descriptions for mutex locks Marcus Wolf
2018-03-25 13:09 ` Valentin Vidic
2018-03-25 13:12 ` Marcus Wolf
2018-03-25 14:24 ` Valentin Vidic
2018-04-08 14:15 ` Marcus Wolf
2018-04-12 17:15 ` Valentin Vidic
2018-04-19 9:25 ` Marcus Wolf
2018-04-19 9:47 ` Valentin Vidic
2018-04-19 9:55 ` Marcus Wolf
2018-04-08 15:22 ` Marcus Wolf
2018-04-12 18:46 ` Valentin Vidic
2018-04-19 9:33 ` Marcus Wolf
2018-04-19 10:25 ` [PATCH v2] staging: pi433: cleanup tx_fifo locking Valentin Vidic
2018-04-19 10:40 ` Marcus Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d263c605-f652-fe24-2034-c699f2d27693@smarthome-wolf.de \
--to=marcus.wolf@smarthome-wolf.de \
--cc=Valentin.Vidic@CARNet.hr \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@Wolf-Entwicklungen.de \
--cc=luca@acul.me \
--cc=marcin.s.ciupak@gmail.com \
--cc=michael.panzlaff@fau.de \
--cc=robsonde@gmail.com \
--cc=simon@nikanor.nu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).