linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shivaprasad G Bhat <sbhat@linux.ibm.com>
To: "Michal Suchánek" <msuchanek@suse.de>,
	"Dan Williams" <dan.j.williams@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux NVDIMM <nvdimm@lists.linux.dev>
Subject: Re: ndctl tests usable?
Date: Thu, 28 Apr 2022 10:02:47 +0530	[thread overview]
Message-ID: <d2684252-8c85-ba0e-2356-29837e836f6f@linux.ibm.com> (raw)
In-Reply-To: <20220426180958.GJ163591@kunlun.suse.cz>

On 4/26/22 23:39, Michal Suchánek wrote:
> On Tue, Apr 26, 2022 at 09:47:19AM -0700, Dan Williams wrote:
>> On Tue, Apr 26, 2022 at 9:43 AM Michal Suchánek <msuchanek@suse.de> wrote:
>>>
>>> On Tue, Apr 26, 2022 at 09:32:24AM -0700, Dan Williams wrote:
>>>> On Tue, Apr 26, 2022 at 9:15 AM Michal Suchánek <msuchanek@suse.de> wrote:
>>>>>
>>>>> On Tue, Apr 26, 2022 at 08:51:25AM -0700, Dan Williams wrote:
>>>>>> On Tue, Apr 26, 2022 at 5:39 AM Michal Suchánek <msuchanek@suse.de> wrote:
>>>>>>>
> ...
>>>>
>>>> The modinfo just tells you what modules are available, but it does not
>>>> necessarily indicate which modules are actively loaded in the system
>>>> which is what ndctl_test_init() validates.
>>>
>>> Isn't what modinfo lists also what modrobe loads?

<snip>

> modules are not loaded before the test.
> 
> Maybe something goes wrong with the test module build?
> 
> It is very fragile and requires complete kernel source for each
> configuration built. See below for the package
> 
> https://build.opensuse.org/package/show/home:michals/nfit_test
> 
> Attaching the log of test run which does not report any missing tools,
> only complains about nfit.ko being production.

I have attempted to fix few of the known issues in the first 3 patches 
of the series posted here.

https://patchwork.kernel.org/project/linux-nvdimm/list/?series=633103

> 
> Thanks
> 
> Michal

  parent reply	other threads:[~2022-04-28  4:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 12:38 ndctl tests usable? Michal Suchánek
2022-04-26 15:51 ` Dan Williams
2022-04-26 16:14   ` Michal Suchánek
2022-04-26 16:32     ` Dan Williams
2022-04-26 16:38       ` Michal Suchánek
2022-04-26 16:47         ` Dan Williams
2022-04-26 18:09           ` Michal Suchánek
2022-04-26 18:22             ` Dan Williams
2022-04-27 11:26               ` Michal Suchánek
2022-04-28  4:32             ` Shivaprasad G Bhat [this message]
2022-04-28  8:51               ` Michal Suchánek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2684252-8c85-ba0e-2356-29837e836f6f@linux.ibm.com \
    --to=sbhat@linux.ibm.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msuchanek@suse.de \
    --cc=nvdimm@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).