From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>,
iommu@lists.linux-foundation.org,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: generic DMA bypass flag
Date: Wed, 13 Nov 2019 14:45:15 +0000 [thread overview]
Message-ID: <d27b7b29-df78-4904-8002-b697da5cb013@arm.com> (raw)
In-Reply-To: <20191113133731.20870-1-hch@lst.de>
On 13/11/2019 1:37 pm, Christoph Hellwig wrote:
> Hi all,
>
> I've recently beeing chatting with Lu about using dma-iommu and
> per-device DMA ops in the intel IOMMU driver, and one missing feature
> in dma-iommu is a bypass mode where the direct mapping is used even
> when an iommu is attached to improve performance. The powerpc
> code already has a similar mode, so I'd like to move it to the core
> DMA mapping code. As part of that I noticed that the current
> powerpc code has a little bug in that it used the wrong check in the
> dma_sync_* routines to see if the direct mapping code is used.
In all honesty, this seems silly. If we can set a per-device flag to say
"oh, bypass these ops and use some other ops instead", then we can just
as easily simply give the device the appropriate ops in the first place.
Because, y'know, the name of the game is "per-device ops".
> These two patches just add the generic code and move powerpc over,
> the intel IOMMU bits will require a separate discussion.
The ops need to match the default domain type, so the hard part of the
problem is choosing when and if to switch that (particularly fun if
there are multiple devices in the IOMMU group). Flipping between
iommu-dma and dma-direct at that point will be trivial.
I don't see a great benefit to pulling legacy cruft out into common code
instead of just working to get rid of it in-place, when said cruft pulls
in the opposite direction to where we're taking the common code (i.e.
it's inherently based on the premise of global ops).
Robin.
> The x86 AMD Gart code also has a bypass mode, but it is a lot
> strange, so I'm not going to touch it for now.
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>
next prev parent reply other threads:[~2019-11-13 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 13:37 generic DMA bypass flag Christoph Hellwig
2019-11-13 13:37 ` [PATCH 1/2] dma-mapping: add a dma_ops_bypass flag to struct device Christoph Hellwig
2019-11-13 13:37 ` [PATCH 2/2] powerpc: use the generic dma_ops_bypass mode Christoph Hellwig
2019-11-13 14:45 ` Robin Murphy [this message]
2019-11-14 7:41 ` generic DMA bypass flag Christoph Hellwig
2019-11-15 18:12 ` Robin Murphy
2019-11-16 6:22 ` Christoph Hellwig
2019-11-19 17:41 ` Robin Murphy
2019-11-20 11:16 ` Christoph Hellwig
2019-11-21 7:34 ` Christoph Hellwig
2019-11-21 16:44 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d27b7b29-df78-4904-8002-b697da5cb013@arm.com \
--to=robin.murphy@arm.com \
--cc=aik@ozlabs.ru \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).