* [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc_coherent
@ 2019-06-27 17:35 Fuqian Huang
2019-06-27 19:37 ` Chaitanya Kulkarni
2019-06-29 15:43 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Fuqian Huang @ 2019-06-27 17:35 UTC (permalink / raw)
Cc: Fuqian Huang, Damien Le Moal, Jens Axboe, linux-block, linux-kernel
In commit af7ddd8a627c
("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
---
drivers/block/skd_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index c479235862e5..51569c199a6c 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -2694,7 +2694,6 @@ static int skd_cons_skmsg(struct skd_device *skdev)
(FIT_QCMD_ALIGN - 1),
"not aligned: msg_buf %p mb_dma_address %pad\n",
skmsg->msg_buf, &skmsg->mb_dma_address);
- memset(skmsg->msg_buf, 0, SKD_N_FITMSG_BYTES);
}
err_out:
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc_coherent
2019-06-27 17:35 [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc_coherent Fuqian Huang
@ 2019-06-27 19:37 ` Chaitanya Kulkarni
2019-06-29 15:43 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Kulkarni @ 2019-06-27 19:37 UTC (permalink / raw)
To: Fuqian Huang; +Cc: Damien Le Moal, Jens Axboe, linux-block, linux-kernel
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 06/27/2019 10:35 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
>
> Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
> ---
> drivers/block/skd_main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index c479235862e5..51569c199a6c 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -2694,7 +2694,6 @@ static int skd_cons_skmsg(struct skd_device *skdev)
> (FIT_QCMD_ALIGN - 1),
> "not aligned: msg_buf %p mb_dma_address %pad\n",
> skmsg->msg_buf, &skmsg->mb_dma_address);
> - memset(skmsg->msg_buf, 0, SKD_N_FITMSG_BYTES);
> }
>
> err_out:
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc_coherent
2019-06-27 17:35 [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc_coherent Fuqian Huang
2019-06-27 19:37 ` Chaitanya Kulkarni
@ 2019-06-29 15:43 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2019-06-29 15:43 UTC (permalink / raw)
To: Fuqian Huang; +Cc: Damien Le Moal, linux-block, linux-kernel
On 6/27/19 11:35 AM, Fuqian Huang wrote:
> In commit af7ddd8a627c
> ("Merge tag 'dma-mapping-4.21' of git://git.infradead.org/users/hch/dma-mapping"),
> dma_alloc_coherent has already zeroed the memory.
> So memset is not needed.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-29 15:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-27 17:35 [PATCH 10/87] block: skd_main.c: Remove call to memset after dma_alloc_coherent Fuqian Huang
2019-06-27 19:37 ` Chaitanya Kulkarni
2019-06-29 15:43 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).